* Re: [PATCH] omap: Export various omap_hwmod related functions [not found] <1351699014-4259-1-git-send-email-panto@antoniou-consulting.com> @ 2012-10-30 18:22 ` Tony Lindgren 2012-10-30 18:24 ` Pantelis Antoniou 0 siblings, 1 reply; 2+ messages in thread From: Tony Lindgren @ 2012-10-30 18:22 UTC (permalink / raw) To: Pantelis Antoniou Cc: Paul Walmsley, Russell King, linux-omap, linux-kernel, Koen Kooi, Matt Porter, Russ Dill * Pantelis Antoniou <panto@antoniou-consulting.com> [121030 11:05]: > omap_hwmod_lookup / omap_device_build / omap_device_build_ss; > these functions can be used just fine by modules, there's no need not > to have them exported. Just curious, where do you plan to use these? These will be private to arch/arm/mach-omap2 and won't be available to drivers with the patches we have queued up in omap-for-v3.8/cleanup-headers branch. Regards, Tony > Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com> > --- > arch/arm/mach-omap2/omap_hwmod.c | 2 ++ > arch/arm/plat-omap/omap_device.c | 6 ++++-- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c > index b969ab1..5b8b6ec 100644 > --- a/arch/arm/mach-omap2/omap_hwmod.c > +++ b/arch/arm/mach-omap2/omap_hwmod.c > @@ -138,6 +138,7 @@ > #include <linux/spinlock.h> > #include <linux/slab.h> > #include <linux/bootmem.h> > +#include <linux/export.h> > > #include <plat/clock.h> > #include <plat/omap_hwmod.h> > @@ -3041,6 +3042,7 @@ struct omap_hwmod *omap_hwmod_lookup(const char *name) > > return oh; > } > +EXPORT_SYMBOL(omap_hwmod_lookup); > > /** > * omap_hwmod_for_each - call function for each registered omap_hwmod > diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c > index 7a7d1f2..a15b715 100644 > --- a/arch/arm/plat-omap/omap_device.c > +++ b/arch/arm/plat-omap/omap_device.c > @@ -663,7 +663,7 @@ void omap_device_delete(struct omap_device *od) > * information. Returns ERR_PTR(-EINVAL) if @oh is NULL; otherwise, > * passes along the return value of omap_device_build_ss(). > */ > -struct platform_device __init *omap_device_build(const char *pdev_name, int pdev_id, > +struct platform_device *omap_device_build(const char *pdev_name, int pdev_id, > struct omap_hwmod *oh, void *pdata, > int pdata_len, > struct omap_device_pm_latency *pm_lats, > @@ -678,6 +678,7 @@ struct platform_device __init *omap_device_build(const char *pdev_name, int pdev > pdata_len, pm_lats, pm_lats_cnt, > is_early_device); > } > +EXPORT_SYMBOL(omap_device_build); > > /** > * omap_device_build_ss - build and register an omap_device with multiple hwmods > @@ -696,7 +697,7 @@ struct platform_device __init *omap_device_build(const char *pdev_name, int pdev > * platform_device record. Returns an ERR_PTR() on error, or passes > * along the return value of omap_device_register(). > */ > -struct platform_device __init *omap_device_build_ss(const char *pdev_name, int pdev_id, > +struct platform_device *omap_device_build_ss(const char *pdev_name, int pdev_id, > struct omap_hwmod **ohs, int oh_cnt, > void *pdata, int pdata_len, > struct omap_device_pm_latency *pm_lats, > @@ -751,6 +752,7 @@ odbs_exit: > > return ERR_PTR(ret); > } > +EXPORT_SYMBOL(omap_device_build_ss); > > /** > * omap_early_device_register - register an omap_device as an early platform > -- > 1.7.12 > ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] omap: Export various omap_hwmod related functions 2012-10-30 18:22 ` [PATCH] omap: Export various omap_hwmod related functions Tony Lindgren @ 2012-10-30 18:24 ` Pantelis Antoniou 0 siblings, 0 replies; 2+ messages in thread From: Pantelis Antoniou @ 2012-10-30 18:24 UTC (permalink / raw) To: Tony Lindgren Cc: Paul Walmsley, Russell King, linux-omap, linux-kernel, Koen Kooi, Matt Porter, Russ Dill Hi Tony, The patches that use them are going to be posted in about 30mins. They will make this clear. Regards -- Pantelis On Oct 30, 2012, at 8:22 PM, Tony Lindgren wrote: > * Pantelis Antoniou <panto@antoniou-consulting.com> [121030 11:05]: >> omap_hwmod_lookup / omap_device_build / omap_device_build_ss; >> these functions can be used just fine by modules, there's no need not >> to have them exported. > > Just curious, where do you plan to use these? > > These will be private to arch/arm/mach-omap2 and won't be available > to drivers with the patches we have queued up in > omap-for-v3.8/cleanup-headers branch. > > Regards, > > Tony > >> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com> >> --- >> arch/arm/mach-omap2/omap_hwmod.c | 2 ++ >> arch/arm/plat-omap/omap_device.c | 6 ++++-- >> 2 files changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c >> index b969ab1..5b8b6ec 100644 >> --- a/arch/arm/mach-omap2/omap_hwmod.c >> +++ b/arch/arm/mach-omap2/omap_hwmod.c >> @@ -138,6 +138,7 @@ >> #include <linux/spinlock.h> >> #include <linux/slab.h> >> #include <linux/bootmem.h> >> +#include <linux/export.h> >> >> #include <plat/clock.h> >> #include <plat/omap_hwmod.h> >> @@ -3041,6 +3042,7 @@ struct omap_hwmod *omap_hwmod_lookup(const char *name) >> >> return oh; >> } >> +EXPORT_SYMBOL(omap_hwmod_lookup); >> >> /** >> * omap_hwmod_for_each - call function for each registered omap_hwmod >> diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c >> index 7a7d1f2..a15b715 100644 >> --- a/arch/arm/plat-omap/omap_device.c >> +++ b/arch/arm/plat-omap/omap_device.c >> @@ -663,7 +663,7 @@ void omap_device_delete(struct omap_device *od) >> * information. Returns ERR_PTR(-EINVAL) if @oh is NULL; otherwise, >> * passes along the return value of omap_device_build_ss(). >> */ >> -struct platform_device __init *omap_device_build(const char *pdev_name, int pdev_id, >> +struct platform_device *omap_device_build(const char *pdev_name, int pdev_id, >> struct omap_hwmod *oh, void *pdata, >> int pdata_len, >> struct omap_device_pm_latency *pm_lats, >> @@ -678,6 +678,7 @@ struct platform_device __init *omap_device_build(const char *pdev_name, int pdev >> pdata_len, pm_lats, pm_lats_cnt, >> is_early_device); >> } >> +EXPORT_SYMBOL(omap_device_build); >> >> /** >> * omap_device_build_ss - build and register an omap_device with multiple hwmods >> @@ -696,7 +697,7 @@ struct platform_device __init *omap_device_build(const char *pdev_name, int pdev >> * platform_device record. Returns an ERR_PTR() on error, or passes >> * along the return value of omap_device_register(). >> */ >> -struct platform_device __init *omap_device_build_ss(const char *pdev_name, int pdev_id, >> +struct platform_device *omap_device_build_ss(const char *pdev_name, int pdev_id, >> struct omap_hwmod **ohs, int oh_cnt, >> void *pdata, int pdata_len, >> struct omap_device_pm_latency *pm_lats, >> @@ -751,6 +752,7 @@ odbs_exit: >> >> return ERR_PTR(ret); >> } >> +EXPORT_SYMBOL(omap_device_build_ss); >> >> /** >> * omap_early_device_register - register an omap_device as an early platform >> -- >> 1.7.12 >> ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-30 18:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1351699014-4259-1-git-send-email-panto@antoniou-consulting.com>
2012-10-30 18:22 ` [PATCH] omap: Export various omap_hwmod related functions Tony Lindgren
2012-10-30 18:24 ` Pantelis Antoniou
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox