[PATCH 2/3] usb: musb: dsps: remove nop unregister

[PATCH 2/3] usb: musb: dsps: remove nop unregister

[Afzal Mohammed]

"usb: musb: dsps: remove explicit NOP device creation"
removed nop register, but not unregistering, remove nop
unregister in error and exit path.

Signed-off-by: Afzal Mohammed <afzal@ti.com>
---
 drivers/usb/musb/musb_dsps.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index 444346e..9d7ca4c 100644
--- a/drivers/usb/musb/musb_dsps.c
+++ b/drivers/usb/musb/musb_dsps.c
@@ -411,7 +411,6 @@ static int dsps_musb_init(struct musb *musb)
 	return 0;
 err0:
 	usb_put_phy(musb->xceiv);
-	usb_nop_xceiv_unregister();
 	return status;
 }
 
@@ -431,7 +430,6 @@ static int dsps_musb_exit(struct musb *musb)
 
 	/* NOP driver needs change if supporting dual instance */
 	usb_put_phy(musb->xceiv);
-	usb_nop_xceiv_unregister();
 
 	return 0;
 }
-- 
1.7.12

[PATCH 3/3] usb: musb: dsps: document dt bindings properly

[Afzal Mohammed]

DT bindings have '-' (hyphens) instead of '_' (underscore),
update the documentation to reflect it.

Signed-off-by: Afzal Mohammed <afzal@ti.com>
---
 Documentation/devicetree/bindings/usb/am33xx-usb.txt | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/am33xx-usb.txt b/Documentation/devicetree/bindings/usb/am33xx-usb.txt
index 9782585..6d5d5f0 100644
--- a/Documentation/devicetree/bindings/usb/am33xx-usb.txt
+++ b/Documentation/devicetree/bindings/usb/am33xx-usb.txt
@@ -3,12 +3,12 @@ AM33XX MUSB GLUE
  - ti,hwmods : must be "usb_otg_hs"
  - multipoint : Should be "1" indicating the musb controller supports
    multipoint. This is a MUSB configuration-specific setting.
- - num_eps : Specifies the number of endpoints. This is also a
+ - num-eps : Specifies the number of endpoints. This is also a
    MUSB configuration-specific setting. Should be set to "16"
- - ram_bits : Specifies the ram address size. Should be set to "12"
- - port0_mode : Should be "3" to represent OTG. "1" signifies HOST and "2"
+ - ram-bits : Specifies the ram address size. Should be set to "12"
+ - port0-mode : Should be "3" to represent OTG. "1" signifies HOST and "2"
    represents PERIPHERAL.
- - port1_mode : Should be "1" to represent HOST. "3" signifies OTG and "2"
+ - port1-mode : Should be "1" to represent HOST. "3" signifies OTG and "2"
    represents PERIPHERAL.
  - power : Should be "250". This signifies the controller can supply upto
    500mA when operating in host mode.
-- 
1.7.12

[PATCH 1/3] usb: otg: nop: add dt support

[Afzal Mohammed]

From: "B, Ravi" <ravibabu@ti.com>

Added device tree support for nop transceiver driver and updated the
Documentation with device tree binding information for am33xx platform.

Signed-off-by: Ravi Babu <ravibabu@ti.com>
Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
Signed-off-by: Afzal Mohammed <afzal@ti.com>
---

Hi,

This series is made over over Balbi's usb "master" branch.

It applies cleanly over "musb" branch too.

Regards
Afzal

 Documentation/devicetree/bindings/usb/am33xx-usb.txt |  3 +++
 drivers/usb/otg/nop-usb-xceiv.c                      | 10 ++++++++++
 2 files changed, 13 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/am33xx-usb.txt b/Documentation/devicetree/bindings/usb/am33xx-usb.txt
index ca8fa56..9782585 100644
--- a/Documentation/devicetree/bindings/usb/am33xx-usb.txt
+++ b/Documentation/devicetree/bindings/usb/am33xx-usb.txt
@@ -12,3 +12,6 @@ AM33XX MUSB GLUE
    represents PERIPHERAL.
  - power : Should be "250". This signifies the controller can supply upto
    500mA when operating in host mode.
+
+NOP USB PHY
+ - compatible : Should be "nop-xceiv-usb"
diff --git a/drivers/usb/otg/nop-usb-xceiv.c b/drivers/usb/otg/nop-usb-xceiv.c
index e52e35e..64bfbe4 100644
--- a/drivers/usb/otg/nop-usb-xceiv.c
+++ b/drivers/usb/otg/nop-usb-xceiv.c
@@ -27,6 +27,7 @@
  */
 
 #include <linux/module.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/dma-mapping.h>
 #include <linux/usb/otg.h>
@@ -154,12 +155,21 @@ static int __devexit nop_usb_xceiv_remove(struct platform_device *pdev)
 	return 0;
 }
 
+#ifdef CONFIG_OF
+static const struct of_device_id nop_xceiv_id_table[] = {
+	{ .compatible = "nop-xceiv-usb" },
+	{},
+};
+MODULE_DEVICE_TABLE(of, nop_xceiv_id_table);
+#endif
+
 static struct platform_driver nop_usb_xceiv_driver = {
 	.probe		= nop_usb_xceiv_probe,
 	.remove		= __devexit_p(nop_usb_xceiv_remove),
 	.driver		= {
 		.name	= "nop_usb_xceiv",
 		.owner	= THIS_MODULE,
+		.of_match_table = of_match_ptr(nop_xceiv_id_table),
 	},
 };
 
-- 
1.7.12

Re: [PATCH 1/3] usb: otg: nop: add dt support

[Afzal Mohammed]

Hi Balbi,

On Thursday 27 September 2012 11:15 AM, Afzal Mohammed wrote:

> This series is made over over Balbi's usb "master" branch.
>
> It applies cleanly over "musb" branch too.

Please ignore this series, a new series has been posted,
"usb: musb: dsps: fixes for -rc".

Regards
Afzal
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] usb: otg: nop: add dt support

[Michael Grzeschik]

Hi,

On Thu, Sep 27, 2012 at 11:15:05AM +0530, Afzal Mohammed wrote:
> From: "B, Ravi" <ravibabu@ti.com>
> 
> Added device tree support for nop transceiver driver and updated the
> Documentation with device tree binding information for am33xx platform.
> 
> Signed-off-by: Ravi Babu <ravibabu@ti.com>
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> ---
> 
> Hi,
> 
> This series is made over over Balbi's usb "master" branch.
> 
> It applies cleanly over "musb" branch too.
> 
> Regards
> Afzal
> 
>  Documentation/devicetree/bindings/usb/am33xx-usb.txt |  3 +++
>  drivers/usb/otg/nop-usb-xceiv.c                      | 10 ++++++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/am33xx-usb.txt b/Documentation/devicetree/bindings/usb/am33xx-usb.txt
> index ca8fa56..9782585 100644
> --- a/Documentation/devicetree/bindings/usb/am33xx-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/am33xx-usb.txt
> @@ -12,3 +12,6 @@ AM33XX MUSB GLUE
>     represents PERIPHERAL.
>   - power : Should be "250". This signifies the controller can supply upto
>     500mA when operating in host mode.
> +
> +NOP USB PHY
> + - compatible : Should be "nop-xceiv-usb"
> diff --git a/drivers/usb/otg/nop-usb-xceiv.c b/drivers/usb/otg/nop-usb-xceiv.c
> index e52e35e..64bfbe4 100644
> --- a/drivers/usb/otg/nop-usb-xceiv.c
> +++ b/drivers/usb/otg/nop-usb-xceiv.c
> @@ -27,6 +27,7 @@
>   */
>  
>  #include <linux/module.h>
> +#include <linux/of.h>
>  #include <linux/platform_device.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/usb/otg.h>
> @@ -154,12 +155,21 @@ static int __devexit nop_usb_xceiv_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +#ifdef CONFIG_OF
> +static const struct of_device_id nop_xceiv_id_table[] = {
> +	{ .compatible = "nop-xceiv-usb" },
> +	{},
> +};
> +MODULE_DEVICE_TABLE(of, nop_xceiv_id_table);
> +#endif
> +
>  static struct platform_driver nop_usb_xceiv_driver = {
>  	.probe		= nop_usb_xceiv_probe,
>  	.remove		= __devexit_p(nop_usb_xceiv_remove),
>  	.driver		= {
>  		.name	= "nop_usb_xceiv",
>  		.owner	= THIS_MODULE,
> +		.of_match_table = of_match_ptr(nop_xceiv_id_table),
>  	},
>  };
>  
> -- 
> 1.7.12
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

What happend to that patch? It did not show up in any new series. Is it
queued anywhere?

Regards,
Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

RE: [PATCH 1/3] usb: otg: nop: add dt support

[Mohammed, Afzal]

Hi Michael,

On Mon, Jan 28, 2013 at 03:10:05, Michael Grzeschik wrote:
> On Thu, Sep 27, 2012 at 11:15:05AM +0530, Afzal Mohammed wrote:

> > From: "B, Ravi" <ravibabu@ti.com>
> > 
> > Added device tree support for nop transceiver driver and updated the
> > Documentation with device tree binding information for am33xx platform.
> > 
> > Signed-off-by: Ravi Babu <ravibabu@ti.com>
> > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> > Signed-off-by: Afzal Mohammed <afzal@ti.com>

> What happend to that patch? It did not show up in any new series. Is it
> queued anywhere?

This patch was not required to get the single instance usb supported
on am335x.

Regards
Afzal