From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
linux-omap <linux-omap@vger.kernel.org>,
linux-arm-kernel@list.infradead.org
Subject: Re: [GIT PULL v2] ARM: omap2: twl-common update
Date: Thu, 28 Mar 2013 09:04:15 -0700 [thread overview]
Message-ID: <20130328160414.GU10155@atomide.com> (raw)
In-Reply-To: <51540D09.7000104@ti.com>
* Peter Ujfalusi <peter.ujfalusi@ti.com> [130328 02:32]:
> Hi Tony,
>
> On 03/27/2013 07:38 PM, Tony Lindgren wrote:
> > Sorry just noticed that this one adds:
> >
> > Section mismatch in reference from the variable omap3_power_pdata to the (unknown reference) .init.data:(unknown)
> > The variable omap3_power_pdata references
> > the (unknown reference) __initdata (unknown)
> > If the reference is valid then annotate the
> > variable with __init* or __refdata (see linux/init.h) or name the variable:
> > *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
> >
> > Is it safe to make it __initdata, or should also other power_pdata
> > have their __initdata flags removed if used by the drivers?
>
> We could make the whole stack of struct for the omap3_power_pdata as
> __initdata since the driver (mfd/twl4030-power) is bool.
What if you rebind the driver via sysfs unbind/bind?
Regards,
Tony
prev parent reply other threads:[~2013-03-28 16:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 10:12 [GIT PULL v2] ARM: omap2: twl-common update Peter Ujfalusi
2013-03-19 18:23 ` Tony Lindgren
2013-03-27 18:38 ` Tony Lindgren
2013-03-28 9:27 ` Peter Ujfalusi
2013-03-28 16:04 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130328160414.GU10155@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@list.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox