public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL v2] ARM: omap2: twl-common update
@ 2013-03-18 10:12 Peter Ujfalusi
  2013-03-19 18:23 ` Tony Lindgren
  0 siblings, 1 reply; 5+ messages in thread
From: Peter Ujfalusi @ 2013-03-18 10:12 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: Matthias Brugger, linux-omap, linux-arm-kernel

Hi Tony,

I have rebased the branch on 3.9-rc3 tag.
Is it still possible to send this for 3.9?

Regards,
Péter
---
The following changes since commit a937536b868b8369b98967929045f1df54234323:

  Linux 3.9-rc3 (2013-03-17 15:59:32 -0700)

are available in the git repository at:

  git://gitorious.org/omap-audio/linux-audio.git peter/upstream/for-tony

for you to fetch changes up to 282f21df32df9a01c66d68e7009150ffc69e4e0c:

  omap2: twl-common: Add default power configuration (2013-03-18 11:08:12 +0100)

----------------------------------------------------------------
Matthias Brugger (1):
      omap2: twl-common: Add default power configuration

 arch/arm/mach-omap2/twl-common.c | 38 ++++++++++++++++++++++++++++++++++++++
 arch/arm/mach-omap2/twl-common.h |  1 +
 2 files changed, 39 insertions(+)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [GIT PULL v2] ARM: omap2: twl-common update
  2013-03-18 10:12 [GIT PULL v2] ARM: omap2: twl-common update Peter Ujfalusi
@ 2013-03-19 18:23 ` Tony Lindgren
  2013-03-27 18:38   ` Tony Lindgren
  0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2013-03-19 18:23 UTC (permalink / raw)
  To: Peter Ujfalusi; +Cc: Matthias Brugger, linux-omap, linux-arm-kernel

* Peter Ujfalusi <peter.ujfalusi@ti.com> [130318 03:16]:
> Hi Tony,
> 
> I have rebased the branch on 3.9-rc3 tag.
> Is it still possible to send this for 3.9?

Let's see if we can still get this in. It's getting a bit late
for v3.9, so I'll apply this into a separate branch from other fixes
omap-for-v3.9-rc3/fix-twl-reboot branch just in case it's considered
too intrusive for the -rc.

Regards,

Tony
 
> Regards,
> Péter
> ---
> The following changes since commit a937536b868b8369b98967929045f1df54234323:
> 
>   Linux 3.9-rc3 (2013-03-17 15:59:32 -0700)
> 
> are available in the git repository at:
> 
>   git://gitorious.org/omap-audio/linux-audio.git peter/upstream/for-tony
> 
> for you to fetch changes up to 282f21df32df9a01c66d68e7009150ffc69e4e0c:
> 
>   omap2: twl-common: Add default power configuration (2013-03-18 11:08:12 +0100)
> 
> ----------------------------------------------------------------
> Matthias Brugger (1):
>       omap2: twl-common: Add default power configuration
> 
>  arch/arm/mach-omap2/twl-common.c | 38 ++++++++++++++++++++++++++++++++++++++
>  arch/arm/mach-omap2/twl-common.h |  1 +
>  2 files changed, 39 insertions(+)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [GIT PULL v2] ARM: omap2: twl-common update
  2013-03-19 18:23 ` Tony Lindgren
@ 2013-03-27 18:38   ` Tony Lindgren
  2013-03-28  9:27     ` Peter Ujfalusi
  0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2013-03-27 18:38 UTC (permalink / raw)
  To: Peter Ujfalusi; +Cc: Matthias Brugger, linux-omap, linux-arm-kernel

* Tony Lindgren <tony@atomide.com> [130319 11:28]:
> * Peter Ujfalusi <peter.ujfalusi@ti.com> [130318 03:16]:
> > Hi Tony,
> > 
> > I have rebased the branch on 3.9-rc3 tag.
> > Is it still possible to send this for 3.9?
> 
> Let's see if we can still get this in. It's getting a bit late
> for v3.9, so I'll apply this into a separate branch from other fixes
> omap-for-v3.9-rc3/fix-twl-reboot branch just in case it's considered
> too intrusive for the -rc.

Sorry just noticed that this one adds:

Section mismatch in reference from the variable omap3_power_pdata to the (unknown reference) .init.data:(unknown)
The variable omap3_power_pdata references
the (unknown reference) __initdata (unknown)
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

Is it safe to make it __initdata, or should also other power_pdata
have their __initdata flags removed if used by the drivers?

Regards,

Tony

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [GIT PULL v2] ARM: omap2: twl-common update
  2013-03-27 18:38   ` Tony Lindgren
@ 2013-03-28  9:27     ` Peter Ujfalusi
  2013-03-28 16:04       ` Tony Lindgren
  0 siblings, 1 reply; 5+ messages in thread
From: Peter Ujfalusi @ 2013-03-28  9:27 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: Matthias Brugger, linux-omap, linux-arm-kernel

Hi Tony,

On 03/27/2013 07:38 PM, Tony Lindgren wrote:
> Sorry just noticed that this one adds:
> 
> Section mismatch in reference from the variable omap3_power_pdata to the (unknown reference) .init.data:(unknown)
> The variable omap3_power_pdata references
> the (unknown reference) __initdata (unknown)
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
> 
> Is it safe to make it __initdata, or should also other power_pdata
> have their __initdata flags removed if used by the drivers?

We could make the whole stack of struct for the omap3_power_pdata as
__initdata since the driver (mfd/twl4030-power) is bool.

I resend the patch and update the branch (and rebase on -rc4) at the same time.

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [GIT PULL v2] ARM: omap2: twl-common update
  2013-03-28  9:27     ` Peter Ujfalusi
@ 2013-03-28 16:04       ` Tony Lindgren
  0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2013-03-28 16:04 UTC (permalink / raw)
  To: Peter Ujfalusi; +Cc: Matthias Brugger, linux-omap, linux-arm-kernel

* Peter Ujfalusi <peter.ujfalusi@ti.com> [130328 02:32]:
> Hi Tony,
> 
> On 03/27/2013 07:38 PM, Tony Lindgren wrote:
> > Sorry just noticed that this one adds:
> > 
> > Section mismatch in reference from the variable omap3_power_pdata to the (unknown reference) .init.data:(unknown)
> > The variable omap3_power_pdata references
> > the (unknown reference) __initdata (unknown)
> > If the reference is valid then annotate the
> > variable with __init* or __refdata (see linux/init.h) or name the variable:
> > *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
> > 
> > Is it safe to make it __initdata, or should also other power_pdata
> > have their __initdata flags removed if used by the drivers?
> 
> We could make the whole stack of struct for the omap3_power_pdata as
> __initdata since the driver (mfd/twl4030-power) is bool.

What if you rebind the driver via sysfs unbind/bind?

Regards,

Tony

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-03-28 16:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-18 10:12 [GIT PULL v2] ARM: omap2: twl-common update Peter Ujfalusi
2013-03-19 18:23 ` Tony Lindgren
2013-03-27 18:38   ` Tony Lindgren
2013-03-28  9:27     ` Peter Ujfalusi
2013-03-28 16:04       ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox