* [PATCH 5/7] drivers/usb/dwc3: don't check resource with devm_ioremap_resource [not found] <1389700739-3696-1-git-send-email-wsa@the-dreams.de> @ 2014-01-14 11:58 ` Wolfram Sang [not found] ` <1389700739-3696-5-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 0 siblings, 1 reply; 2+ messages in thread From: Wolfram Sang @ 2014-01-14 11:58 UTC (permalink / raw) To: linux-kernel Cc: Wolfram Sang, Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-omap devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang <wsa@the-dreams.de> --- Should go via subsystem tree drivers/usb/dwc3/dwc3-omap.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c index 7f7ea62..cbcd972 100644 --- a/drivers/usb/dwc3/dwc3-omap.c +++ b/drivers/usb/dwc3/dwc3-omap.c @@ -432,11 +432,6 @@ static int dwc3_omap_probe(struct platform_device *pdev) } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(dev, "missing memory base resource\n"); - return -EINVAL; - } - base = devm_ioremap_resource(dev, res); if (IS_ERR(base)) return PTR_ERR(base); -- 1.8.5.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
[parent not found: <1389700739-3696-5-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>]
* Re: [PATCH 5/7] drivers/usb/dwc3: don't check resource with devm_ioremap_resource [not found] ` <1389700739-3696-5-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> @ 2014-01-14 14:15 ` Felipe Balbi 0 siblings, 0 replies; 2+ messages in thread From: Felipe Balbi @ 2014-01-14 14:15 UTC (permalink / raw) To: Wolfram Sang Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Felipe Balbi, Greg Kroah-Hartman, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-omap-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 362 bytes --] On Tue, Jan 14, 2014 at 12:58:56PM +0100, Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> > --- > > Should go via subsystem tree too late for v3.14, I'll merge this for v3.15. -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-14 14:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1389700739-3696-1-git-send-email-wsa@the-dreams.de>
2014-01-14 11:58 ` [PATCH 5/7] drivers/usb/dwc3: don't check resource with devm_ioremap_resource Wolfram Sang
[not found] ` <1389700739-3696-5-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-01-14 14:15 ` Felipe Balbi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox