Re: [PATCH] ARM: dts: Revert disabling of smc91x for n900

["Pali Rohár" <pali.rohar@gmail.com>]

[-- Attachment #1: Type: Text/Plain, Size: 2038 bytes --]

On Tuesday 06 January 2015 20:44:43 Aaro Koskinen wrote:
> Hi,
> 
> On Tue, Jan 06, 2015 at 08:59:03AM -0800, Tony Lindgren wrote:
> > * Pavel Machek <pavel@ucw.cz> [150106 00:03]:
> > > On Mon 2015-01-05 15:02:29, Tony Lindgren wrote:
> > > > Revert "ARM: dts: Disable smc91x on n900 until
> > > > bootloader dependency is removed". We've now fixed the
> > > > issues that caused problems with uninitialized hardware
> > > > depending on the bootloader version. Mostly things got
> > > > fixed with the following commits:
> > > > 
> > > > 9a894953a97b ("ARM: dts: Fix bootloader version
> > > > dependencies by muxing n900 smc91x pins") 7d2911c43815
> > > > ("net: smc91x: Fix gpios for device tree based
> > > > booting")
> > > > 
> > > > Note that this only affects the early development boards
> > > > with Ethernet that we still have in a few automated boot
> > > > test systems.
> > > > 
> > > > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > > 
> > > Normally, the early development boards should have
> > > separate dts file (then include common parts), no?
> > 
> > In this case it won't matter. The GPMC hardware is there,
> > the probe just fails if no smsc91x is found.
> > 
> > > Could you at least add a note to the dts file what is it?
> > > Because I always thought it is a bug.
> > 
> > Sure, updated patch below. Can somebody please test boot it
> > on a production n900 too to make sure it no longer causes
> > issues?
> 
> Seems to work fine with normal n900.
> 
> Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> 
> I also tested with a development board, eth0 seemed to appear,
> but couldn't configure the MAC address with busybox ifconfig.
> How should it be done, I guess the interface does not have any
> MAC by default?
> 
> A.

Should not kernel generate some random mac address if driver does 
not provide one?

You can try to set (temporary) mac address to if with ifconfig:

$ ifconfig eth0 hw ether <mac>

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]