linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Roger Quadros <rogerq@ti.com>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: omap2plus_defconfig: Enable EXTCON_USB_GPIO
Date: Mon, 4 May 2015 09:11:27 -0700	[thread overview]
Message-ID: <20150504161126.GI24469@atomide.com> (raw)
In-Reply-To: <20150324170935.GC24168@saruman.tx.rr.com>

* Felipe Balbi <balbi@ti.com> [150324 10:10]:
> On Tue, Mar 24, 2015 at 11:57:54AM -0500, Nishanth Menon wrote:
> > On 11:44-20150324, Felipe Balbi wrote:
> > > On Tue, Mar 24, 2015 at 09:26:48AM -0500, Nishanth Menon wrote:
> > > > On 12:19-20150324, Roger Quadros wrote:
> > > > > We need to enable EXTCON_USB_GPIO_USB and not
> > > > > EXTCON_GPIO_USB.
> > > > > 
> > > > > Fixes: c08a54c0ebeb ("ARM: omap2plus_defconfig: Enable EXTCON_GPIO_USB")
> > > > > 
> > > > > Reported-by: Nishant Menon <nm@ti.com>
> > > > > Signed-off-by: Roger Quadros <rogerq@ti.com>
> > > > > ---
> > > > >  arch/arm/configs/omap2plus_defconfig | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > > > > index 04b4c8e..daf9412 100644
> > > > > --- a/arch/arm/configs/omap2plus_defconfig
> > > > > +++ b/arch/arm/configs/omap2plus_defconfig
> > > > > @@ -391,7 +391,7 @@ CONFIG_TI_EDMA=y
> > > > >  CONFIG_DMA_OMAP=y
> > > > >  # CONFIG_IOMMU_SUPPORT is not set
> > > > >  CONFIG_EXTCON=m
> > > > > -CONFIG_EXTCON_GPIO=m
> > > > > +CONFIG_EXTCON_USB_GPIO=m
> > > > >  CONFIG_EXTCON_PALMAS=m
> > > > >  CONFIG_TI_EMIF=m
> > > > >  CONFIG_PWM=y
> > > > > -- 
> > > > > 2.1.0
> > > > 
> > > > Yep and it finally works! Yipiee!!
> > > > http://pastebin.ubuntu.com/10669565/
> > > 
> > > I don't see the peripheral side IRQ in /proc/interrupts. What's going
> > > on? Can you load g_zero or g_mass_storage and verify peripheral side
> > > also works ?
> > my board is remote atm and does not have the usb peripheral cable hooked in.
> > However, I did load g_zero and looks like 73 is registered.
> 
> thanks, that should be enough :-)
> 
> Reviewed-by: Felipe Balbi <balbi@ti.com>
> Acked-by: Felipe Balbi <balbi@ti.com>

Applying into omap-for-v4.1/fixes thanks.

Tony

      reply	other threads:[~2015-05-04 16:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 10:19 [PATCH] ARM: omap2plus_defconfig: Enable EXTCON_USB_GPIO Roger Quadros
2015-03-24 14:26 ` Nishanth Menon
2015-03-24 16:44   ` Felipe Balbi
2015-03-24 16:57     ` Nishanth Menon
2015-03-24 17:09       ` Felipe Balbi
2015-05-04 16:11         ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150504161126.GI24469@atomide.com \
    --to=tony@atomide.com \
    --cc=balbi@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).