* [PATCH] arm: dts: dra7: arch timer sits in always-on power domain
@ 2015-07-13 20:41 Felipe Balbi
2015-07-13 20:53 ` Nishanth Menon
2015-07-15 9:24 ` Mark Rutland
0 siblings, 2 replies; 6+ messages in thread
From: Felipe Balbi @ 2015-07-13 20:41 UTC (permalink / raw)
To: Tony Lindgren
Cc: Nishanth Menon, Linux OMAP Mailing List, Felipe Balbi,
Linux ARM Kernel Mailing List
According to DRA7x TRM section 4.3.5 Realtime Counter (Master Counter),
the realtime counter sits in the Wakeup Always-On Power domain.
Furthermore, the counter will automatically switch the 32K clock source
when MPU goes into standby and automatically switch back to SYS_CLK or
ABE_LP when MPU goes out of standby.
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
arch/arm/boot/dts/dra7.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 8f1e25bcecbd..c1e6fd82485f 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -50,6 +50,7 @@
<GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>;
interrupt-parent = <&gic>;
+ always-on;
};
gic: interrupt-controller@48211000 {
--
2.4.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm: dts: dra7: arch timer sits in always-on power domain
2015-07-13 20:41 [PATCH] arm: dts: dra7: arch timer sits in always-on power domain Felipe Balbi
@ 2015-07-13 20:53 ` Nishanth Menon
2015-07-14 4:49 ` Tony Lindgren
2015-07-15 9:24 ` Mark Rutland
1 sibling, 1 reply; 6+ messages in thread
From: Nishanth Menon @ 2015-07-13 20:53 UTC (permalink / raw)
To: Felipe Balbi
Cc: Tony Lindgren, Linux OMAP Mailing List,
Linux ARM Kernel Mailing List
On Mon, Jul 13, 2015 at 3:41 PM, Felipe Balbi <balbi@ti.com> wrote:
> According to DRA7x TRM section 4.3.5 Realtime Counter (Master Counter),
> the realtime counter sits in the Wakeup Always-On Power domain.
> Furthermore, the counter will automatically switch the 32K clock source
> when MPU goes into standby and automatically switch back to SYS_CLK or
> ABE_LP when MPU goes out of standby.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
Acked-by: NIshanth Menon <nm@ti.com>
> ---
> arch/arm/boot/dts/dra7.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 8f1e25bcecbd..c1e6fd82485f 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -50,6 +50,7 @@
> <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
> <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>;
> interrupt-parent = <&gic>;
> + always-on;
> };
>
> gic: interrupt-controller@48211000 {
> --
> 2.4.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
---
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm: dts: dra7: arch timer sits in always-on power domain
2015-07-13 20:53 ` Nishanth Menon
@ 2015-07-14 4:49 ` Tony Lindgren
2015-07-14 7:05 ` Tony Lindgren
0 siblings, 1 reply; 6+ messages in thread
From: Tony Lindgren @ 2015-07-14 4:49 UTC (permalink / raw)
To: Nishanth Menon
Cc: Linux OMAP Mailing List, Linux ARM Kernel Mailing List,
Felipe Balbi
* Nishanth Menon <nm@ti.com> [150713 13:56]:
> On Mon, Jul 13, 2015 at 3:41 PM, Felipe Balbi <balbi@ti.com> wrote:
> > According to DRA7x TRM section 4.3.5 Realtime Counter (Master Counter),
> > the realtime counter sits in the Wakeup Always-On Power domain.
> > Furthermore, the counter will automatically switch the 32K clock source
> > when MPU goes into standby and automatically switch back to SYS_CLK or
> > ABE_LP when MPU goes out of standby.
That's good to hear. Is that the case also for 5432?
Regards,
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: dts: dra7: arch timer sits in always-on power domain
2015-07-14 4:49 ` Tony Lindgren
@ 2015-07-14 7:05 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2015-07-14 7:05 UTC (permalink / raw)
To: Nishanth Menon
Cc: Linux OMAP Mailing List, Linux ARM Kernel Mailing List,
Felipe Balbi
* Tony Lindgren <tony@atomide.com> [150713 21:52]:
> * Nishanth Menon <nm@ti.com> [150713 13:56]:
> > On Mon, Jul 13, 2015 at 3:41 PM, Felipe Balbi <balbi@ti.com> wrote:
> > > According to DRA7x TRM section 4.3.5 Realtime Counter (Master Counter),
> > > the realtime counter sits in the Wakeup Always-On Power domain.
> > > Furthermore, the counter will automatically switch the 32K clock source
> > > when MPU goes into standby and automatically switch back to SYS_CLK or
> > > ABE_LP when MPU goes out of standby.
>
> That's good to hear. Is that the case also for 5432?
Adding into omap-for-v4.2/fixes, if 5432 supports it too it
can be patched separately.
Regards,
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: dts: dra7: arch timer sits in always-on power domain
2015-07-13 20:41 [PATCH] arm: dts: dra7: arch timer sits in always-on power domain Felipe Balbi
2015-07-13 20:53 ` Nishanth Menon
@ 2015-07-15 9:24 ` Mark Rutland
2015-07-15 10:00 ` Tony Lindgren
1 sibling, 1 reply; 6+ messages in thread
From: Mark Rutland @ 2015-07-15 9:24 UTC (permalink / raw)
To: Felipe Balbi
Cc: Tony Lindgren, Nishanth Menon, Linux OMAP Mailing List,
Linux ARM Kernel Mailing List, marc.zyngier
On Mon, Jul 13, 2015 at 09:41:41PM +0100, Felipe Balbi wrote:
> According to DRA7x TRM section 4.3.5 Realtime Counter (Master Counter),
> the realtime counter sits in the Wakeup Always-On Power domain.
> Furthermore, the counter will automatically switch the 32K clock source
> when MPU goes into standby and automatically switch back to SYS_CLK or
> ABE_LP when MPU goes out of standby.
While the counter is in an always-on domain (the architecture mandates
this) I don't think that applies to the timers (i.e. the comparators
within a CPU), which are almost certainly not in an always-on domain.
I suspect that this is incorrect, and it will be very painful to debug
if it is...
Thanks,
Mark.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
> arch/arm/boot/dts/dra7.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 8f1e25bcecbd..c1e6fd82485f 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -50,6 +50,7 @@
> <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
> <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>;
> interrupt-parent = <&gic>;
> + always-on;
> };
>
> gic: interrupt-controller@48211000 {
> --
> 2.4.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm: dts: dra7: arch timer sits in always-on power domain
2015-07-15 9:24 ` Mark Rutland
@ 2015-07-15 10:00 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2015-07-15 10:00 UTC (permalink / raw)
To: Mark Rutland
Cc: Nishanth Menon, marc.zyngier, Linux OMAP Mailing List,
Linux ARM Kernel Mailing List, Felipe Balbi
* Mark Rutland <mark.rutland@arm.com> [150715 02:27]:
> On Mon, Jul 13, 2015 at 09:41:41PM +0100, Felipe Balbi wrote:
> > According to DRA7x TRM section 4.3.5 Realtime Counter (Master Counter),
> > the realtime counter sits in the Wakeup Always-On Power domain.
> > Furthermore, the counter will automatically switch the 32K clock source
> > when MPU goes into standby and automatically switch back to SYS_CLK or
> > ABE_LP when MPU goes out of standby.
>
> While the counter is in an always-on domain (the architecture mandates
> this) I don't think that applies to the timers (i.e. the comparators
> within a CPU), which are almost certainly not in an always-on domain.
>
> I suspect that this is incorrect, and it will be very painful to debug
> if it is...
OK good point. And there would have to be some wake-up line wired to the
IO chain or the PMIC in this case if the comparator was always on.
Dropping this patch for now anyways.
Regards,
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-07-15 10:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-13 20:41 [PATCH] arm: dts: dra7: arch timer sits in always-on power domain Felipe Balbi
2015-07-13 20:53 ` Nishanth Menon
2015-07-14 4:49 ` Tony Lindgren
2015-07-14 7:05 ` Tony Lindgren
2015-07-15 9:24 ` Mark Rutland
2015-07-15 10:00 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox