* Re: [PATCH] davinci_emac: fix setting the mac from DT [not found] <1476904973-13226-1-git-send-email-jhofstee@victronenergy.com> @ 2016-10-20 12:41 ` Tony Lindgren 2016-10-20 13:35 ` Jeroen Hofstee 0 siblings, 1 reply; 2+ messages in thread From: Tony Lindgren @ 2016-10-20 12:41 UTC (permalink / raw) To: Jeroen Hofstee Cc: netdev, David S . Miller, Anant Gole, Chaithrika U S, linux-omap * Jeroen Hofstee <jhofstee@victronenergy.com> [161019 12:39]: > commit 9120bd6e9f77 ("net: davinci_emac: Get device dm816x MAC address > using the cpsw code") sets the mac address to the one stored in the chip > unconditionally, overwritten the one already set from the device tree. > This patch makes sure the mac from DT is preserved. > > On a am3517 this address is incorrectly read as all zeros, making it > impossible to set a valid mac address without this patch. OK, at least I don't have better ideas for fixing this: Acked-by: Tony Lindgren <tony@atomide.com> ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] davinci_emac: fix setting the mac from DT 2016-10-20 12:41 ` [PATCH] davinci_emac: fix setting the mac from DT Tony Lindgren @ 2016-10-20 13:35 ` Jeroen Hofstee 0 siblings, 0 replies; 2+ messages in thread From: Jeroen Hofstee @ 2016-10-20 13:35 UTC (permalink / raw) To: Tony Lindgren Cc: netdev, David S . Miller, Anant Gole, Chaithrika U S, linux-omap Hi, On 20-10-16 14:41, Tony Lindgren wrote: > * Jeroen Hofstee <jhofstee@victronenergy.com> [161019 12:39]: >> commit 9120bd6e9f77 ("net: davinci_emac: Get device dm816x MAC address >> using the cpsw code") sets the mac address to the one stored in the chip >> unconditionally, overwritten the one already set from the device tree. >> This patch makes sure the mac from DT is preserved. >> >> On a am3517 this address is incorrectly read as all zeros, making it >> impossible to set a valid mac address without this patch. > OK, at least I don't have better ideas for fixing this: more details about the am3517 specific issue can be found here http://marc.info/?l=linux-omap&m=147678889732646&w=2 Regards, Jeroen ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-20 13:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1476904973-13226-1-git-send-email-jhofstee@victronenergy.com>
2016-10-20 12:41 ` [PATCH] davinci_emac: fix setting the mac from DT Tony Lindgren
2016-10-20 13:35 ` Jeroen Hofstee
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox