public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Bin Liu <b-liu-l0cyMroinI0@public.gmane.org>,
	Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Linux OMAP List
	<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)
Date: Fri, 7 Apr 2017 06:52:53 -0700	[thread overview]
Message-ID: <20170407135252.GG13234@atomide.com> (raw)
In-Reply-To: <20170406190722.GA12367@uda0271908>

* Bin Liu <b-liu-l0cyMroinI0@public.gmane.org> [170406 12:09]:
> On Wed, Apr 05, 2017 at 08:29:55AM -0700, Tony Lindgren wrote:
> > If the the port is configured as OTG, we should not need to
> > try to force any states during init. The change below will stop
> 
> True, but the code has been there for a very long time, any idea what
> causes the regression?

I think it's just that with commit d8e5f0eca1e8 we now have phy enabled
earlier and calling musb_host_setup() with phy enabled sends it into
a loop of trying to force the host mode with nothing connected. This
loops seems to end after few seconds if there are devices connected,
but keeps going if there's nothing connected.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-04-07 13:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04  7:09 usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8) Peter Ujfalusi
     [not found] ` <2bf73b02-6e59-627a-c370-552ed94e7795-l0cyMroinI0@public.gmane.org>
2017-04-04 12:27   ` Bin Liu
2017-04-04 14:03     ` Tony Lindgren
     [not found]       ` <20170404140341.GO10760-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-04-05  0:36         ` Tony Lindgren
     [not found]           ` <20170405003637.GB13234-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-04-05  7:13             ` Peter Ujfalusi
     [not found]               ` <dda7b6b0-b533-dfd6-1b12-b320bd69b623-l0cyMroinI0@public.gmane.org>
2017-04-05  7:29                 ` Peter Ujfalusi
2017-04-05 13:46                 ` Tony Lindgren
     [not found]                   ` <20170405134655.GD13234-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-04-05 15:29                     ` Tony Lindgren
     [not found]                       ` <20170405152954.GF13234-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-04-06 17:04                         ` Peter Ujfalusi
     [not found]                           ` <a86b6582-468f-04c8-cb22-0770f1e91e67-l0cyMroinI0@public.gmane.org>
2017-04-07 14:00                             ` Tony Lindgren
2017-04-06 19:07                         ` Bin Liu
2017-04-07 13:52                           ` Tony Lindgren [this message]
     [not found]                             ` <20170407135252.GG13234-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-04-07 14:18                               ` Bin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170407135252.GG13234@atomide.com \
    --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
    --cc=b-liu-l0cyMroinI0@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=peter.ujfalusi-l0cyMroinI0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox