Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

[Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>]

On 2017-04-05 10:13, Peter Ujfalusi wrote:
> I had similar hunch first, but did not worked. I have tested this patch
> and did not helped.
>
> To be precise this is what I have tried:
> - boot w/o cable connected
> - boot w/ board connected to PC (device mode)
> - boot w/ OTG-A cable with USB keyboard
> - boot w/ OTG-A cable connected to powered USB hub and the same keyboard
>
> w/ and w/o this patch I have the same flood of prints in all cases.

the config I have for linux-next:
https://pastebin.com/KixvyiRR

>
> Fwiw I have checked where the is_active is set - which causes the prints:
> musb_core.c:musb_start()
>
> if (musb->port_mode != MUSB_PORT_MODE_HOST &&
>         musb->xceiv->otg->state != OTG_STATE_A_WAIT_BCON &&
>         (devctl & MUSB_DEVCTL_VBUS) == MUSB_DEVCTL_VBUS) {
>     musb->is_active = 1;
> } else {
>     devctl |= MUSB_DEVCTL_SESSION;
> }
>
> this was the only place where the is_active was set to 1.
>
>
>> Regards,
>>
>> Tony
>>
>> 8< -----------------------
>> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
>> --- a/drivers/usb/musb/omap2430.c
>> +++ b/drivers/usb/musb/omap2430.c
>> @@ -91,12 +91,6 @@ static void omap2430_musb_set_vbus(struct musb
>> *musb, int is_on)
>>              }
>>
>>              otg_set_vbus(otg, 1);
>> -        } else {
>> -            musb->is_active = 1;
>> -            otg->default_a = 1;
>> -            musb->xceiv->otg->state = OTG_STATE_A_WAIT_VRISE;
>> -            devctl |= MUSB_DEVCTL_SESSION;
>> -            MUSB_HST_MODE(musb);
>>          }
>>      } else {
>>          musb->is_active = 0;
>
> - Péter
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

- Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html