* Re: [PATCH v2 0/2] USB: musb: PM fixes [not found] ` <20171005091436.GA2618@localhost> @ 2017-10-05 15:11 ` Tony Lindgren [not found] ` <20171005151154.GD3962-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Tony Lindgren @ 2017-10-05 15:11 UTC (permalink / raw) To: Johan Hovold Cc: Bin Liu, Greg Kroah-Hartman, linux-usb-u79uwXL29TY76Z2rM5mHXA, Sebastian Andrzej Siewior, Felipe Balbi, linux-omap-u79uwXL29TY76Z2rM5mHXA * Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> [171005 02:15]: > On Thu, Sep 07, 2017 at 03:37:46PM +0200, Johan Hovold wrote: > > These patches fix a couple of bugs introduced by the recent runtime-PM > > work (details in the individual commit messages). > > > > Note that the external abort was due to the irq work never being flushed > > on suspend, and that we may need similar fixes for the delayed reset and > > resume work which are likewise never cancelled on suspend. > > > > As I just mentioned in the v1 thread, there are a number of further issues with > > musb suspend (e.g. on BBB): > > > > 1. System suspend appears to break any active gadget (which then can be > > restarted manually). > > > > 2. The early_tx polling in musb_cppi41 lacks a timeout, something which can > > lead to the hrtimer rescheduling itself indefinitely if the fifo never > > empties (e.g. if a transfer is is initiated post suspend due to issue 1). > > > > See commit a655f481d83d ("usb: musb: musb_cppi41: handle pre-mature TX > > complete interrupt"). > > > > 3. In host mode, if a device is disconnected while the system is suspended, > > this will keep the controller runtime active after resume as the session > > bit is always set. > > Bin and Tony, any comments to this series? Oops sorry I forgot to test these after two recent conferences. I just gave these a try and they both behave for me. Nice fixes, for both: Tested-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20171005151154.GD3962-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH v2 0/2] USB: musb: PM fixes [not found] ` <20171005151154.GD3962-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> @ 2017-10-05 15:14 ` Johan Hovold 2017-10-06 16:27 ` Bin Liu 0 siblings, 1 reply; 4+ messages in thread From: Johan Hovold @ 2017-10-05 15:14 UTC (permalink / raw) To: Tony Lindgren Cc: Johan Hovold, Bin Liu, Greg Kroah-Hartman, linux-usb-u79uwXL29TY76Z2rM5mHXA, Sebastian Andrzej Siewior, Felipe Balbi, linux-omap-u79uwXL29TY76Z2rM5mHXA On Thu, Oct 05, 2017 at 08:11:55AM -0700, Tony Lindgren wrote: > * Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> [171005 02:15]: > > On Thu, Sep 07, 2017 at 03:37:46PM +0200, Johan Hovold wrote: > > > These patches fix a couple of bugs introduced by the recent runtime-PM > > > work (details in the individual commit messages). > > > > > > Note that the external abort was due to the irq work never being flushed > > > on suspend, and that we may need similar fixes for the delayed reset and > > > resume work which are likewise never cancelled on suspend. > > > > > > As I just mentioned in the v1 thread, there are a number of further issues with > > > musb suspend (e.g. on BBB): > > > > > > 1. System suspend appears to break any active gadget (which then can be > > > restarted manually). > > > > > > 2. The early_tx polling in musb_cppi41 lacks a timeout, something which can > > > lead to the hrtimer rescheduling itself indefinitely if the fifo never > > > empties (e.g. if a transfer is is initiated post suspend due to issue 1). > > > > > > See commit a655f481d83d ("usb: musb: musb_cppi41: handle pre-mature TX > > > complete interrupt"). > > > > > > 3. In host mode, if a device is disconnected while the system is suspended, > > > this will keep the controller runtime active after resume as the session > > > bit is always set. > > > > Bin and Tony, any comments to this series? > > Oops sorry I forgot to test these after two recent conferences. I just gave > these a try and they both behave for me. Nice fixes, for both: > > Tested-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> Great, thanks for testing! Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 0/2] USB: musb: PM fixes 2017-10-05 15:14 ` Johan Hovold @ 2017-10-06 16:27 ` Bin Liu [not found] ` <20171006162756.GD12182-zlS79ln5qqxp6PWD+TyudpdHMjK6IpyN@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Bin Liu @ 2017-10-06 16:27 UTC (permalink / raw) To: Johan Hovold Cc: Tony Lindgren, Greg Kroah-Hartman, linux-usb-u79uwXL29TY76Z2rM5mHXA, Sebastian Andrzej Siewior, Felipe Balbi, linux-omap-u79uwXL29TY76Z2rM5mHXA On Thu, Oct 05, 2017 at 05:14:24PM +0200, Johan Hovold wrote: > On Thu, Oct 05, 2017 at 08:11:55AM -0700, Tony Lindgren wrote: > > * Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> [171005 02:15]: > > > On Thu, Sep 07, 2017 at 03:37:46PM +0200, Johan Hovold wrote: > > > > These patches fix a couple of bugs introduced by the recent runtime-PM > > > > work (details in the individual commit messages). > > > > > > > > Note that the external abort was due to the irq work never being flushed > > > > on suspend, and that we may need similar fixes for the delayed reset and > > > > resume work which are likewise never cancelled on suspend. > > > > > > > > As I just mentioned in the v1 thread, there are a number of further issues with > > > > musb suspend (e.g. on BBB): > > > > > > > > 1. System suspend appears to break any active gadget (which then can be > > > > restarted manually). > > > > > > > > 2. The early_tx polling in musb_cppi41 lacks a timeout, something which can > > > > lead to the hrtimer rescheduling itself indefinitely if the fifo never > > > > empties (e.g. if a transfer is is initiated post suspend due to issue 1). > > > > > > > > See commit a655f481d83d ("usb: musb: musb_cppi41: handle pre-mature TX > > > > complete interrupt"). > > > > > > > > 3. In host mode, if a device is disconnected while the system is suspended, > > > > this will keep the controller runtime active after resume as the session > > > > bit is always set. > > > > > > Bin and Tony, any comments to this series? > > > > Oops sorry I forgot to test these after two recent conferences. I just gave > > these a try and they both behave for me. Nice fixes, for both: > > > > Tested-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> > > Great, thanks for testing! Tony, thanks for testing them. Johan, I recently have been over loaded with a non-usb work, and it probably will last for another month or two. But I will try my best to get these patches and others accumulated recently into upstream in next week. Sorry for the delay. Regards, -Bin. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20171006162756.GD12182-zlS79ln5qqxp6PWD+TyudpdHMjK6IpyN@public.gmane.org>]
* Re: [PATCH v2 0/2] USB: musb: PM fixes [not found] ` <20171006162756.GD12182-zlS79ln5qqxp6PWD+TyudpdHMjK6IpyN@public.gmane.org> @ 2017-10-09 8:09 ` Johan Hovold 0 siblings, 0 replies; 4+ messages in thread From: Johan Hovold @ 2017-10-09 8:09 UTC (permalink / raw) To: Bin Liu Cc: Johan Hovold, Tony Lindgren, Greg Kroah-Hartman, linux-usb-u79uwXL29TY76Z2rM5mHXA, Sebastian Andrzej Siewior, Felipe Balbi, linux-omap-u79uwXL29TY76Z2rM5mHXA On Fri, Oct 06, 2017 at 11:27:56AM -0500, Bin Liu wrote: > On Thu, Oct 05, 2017 at 05:14:24PM +0200, Johan Hovold wrote: > > On Thu, Oct 05, 2017 at 08:11:55AM -0700, Tony Lindgren wrote: > > > * Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> [171005 02:15]: > > > > Bin and Tony, any comments to this series? > > > > > > Oops sorry I forgot to test these after two recent conferences. I just gave > > > these a try and they both behave for me. Nice fixes, for both: > > > > > > Tested-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> > > > > Great, thanks for testing! > > Tony, thanks for testing them. > > Johan, I recently have been over loaded with a non-usb work, and it > probably will last for another month or two. But I will try my best to > get these patches and others accumulated recently into upstream in next > week. > > Sorry for the delay. No worries, thanks for letting me know. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-09 8:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170907133748.7400-1-johan@kernel.org>
[not found] ` <20171005091436.GA2618@localhost>
2017-10-05 15:11 ` [PATCH v2 0/2] USB: musb: PM fixes Tony Lindgren
[not found] ` <20171005151154.GD3962-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-10-05 15:14 ` Johan Hovold
2017-10-06 16:27 ` Bin Liu
[not found] ` <20171006162756.GD12182-zlS79ln5qqxp6PWD+TyudpdHMjK6IpyN@public.gmane.org>
2017-10-09 8:09 ` Johan Hovold
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox