From: Sam Ravnborg <sam@ravnborg.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
dri-devel@lists.freedesktop.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
thierry.reding@gmail.com, Jyri Sarha <jsarha@ti.com>,
letux-kernel@openphoenux.org
Subject: Re: [PATCH 0/5] Fix SPI module alias for panels used by omapdrm
Date: Mon, 7 Oct 2019 19:22:56 +0200 [thread overview]
Message-ID: <20191007172256.GA1956@ravnborg.org> (raw)
In-Reply-To: <20191007170801.27647-1-laurent.pinchart@ideasonboard.com>
Hi Laurent.
On Mon, Oct 07, 2019 at 08:07:56PM +0300, Laurent Pinchart wrote:
> Hello,
>
> This patch series fixes a module alias issue with the five recently
> added panel drivers used by omapdrm.
>
> Before those panel drivers, omapdrm had custom drivers for the panels,
> and prefixed the OF compatible strings with an "omapdss," prefix. The
> SPI device IDs are constructed by stripping the OF compatible string
> from the prefix, resulting in the "omapdss," prefix being removed, but
> the subsequence OF vendor prefix being kept. The SPI drivers thus had
> modules aliases that contained the vendor prefix.
>
> Now that the panels are supported by standard drivers and the "omapdss,"
> prefix is removed, the SPI device IDs are stripped from the OF vendor
> prefix. As the new panel drivers copied the module aliases from the
> omapdrm-specific drivers, they contain the vendor prefix in their SPI
> module aliases, and are thus not loaded automatically.
>
> Fix this by removing the vendor prefix from the SPI modules aliases in
> the drivers. For consistency reason, the manual module aliases are also
> moved to use an SPI module table.
Good explanation - thanks.
>
> These patches are based on the drm-misc-fixes branch as they fix v5.4
> regressions.
>
> Laurent Pinchart (5):
> drm/panel: lg-lb035q02: Fix SPI alias
> drm/panel: nec-nl8048hl11: Fix SPI alias
> drm/panel: sony-acx565akm: Fix SPI alias
> drm/panel: tpo-td028ttec1: Fix SPI alias
> drm/panel: tpo-td043mtea1: Fix SPI alias
Full series is:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
I expect someone else to pick them up or that you apply them.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-10-07 17:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 17:07 [PATCH 0/5] Fix SPI module alias for panels used by omapdrm Laurent Pinchart
2019-10-07 17:07 ` [PATCH 1/5] drm/panel: lg-lb035q02: Fix SPI alias Laurent Pinchart
2019-10-07 17:07 ` [PATCH 2/5] drm/panel: nec-nl8048hl11: " Laurent Pinchart
2019-10-07 17:07 ` [PATCH 3/5] drm/panel: sony-acx565akm: " Laurent Pinchart
2019-10-07 17:08 ` [PATCH 4/5] drm/panel: tpo-td028ttec1: " Laurent Pinchart
2019-10-07 17:58 ` [Letux-kernel] " Andreas Kemnade
2019-10-07 19:33 ` H. Nikolaus Schaller
2019-10-07 17:08 ` [PATCH 5/5] drm/panel: tpo-td043mtea1: " Laurent Pinchart
2019-10-07 19:34 ` H. Nikolaus Schaller
2019-10-07 17:22 ` Sam Ravnborg [this message]
2019-10-07 17:44 ` [PATCH 0/5] Fix SPI module alias for panels used by omapdrm Laurent Pinchart
2019-10-08 5:24 ` Tomi Valkeinen
2019-10-07 17:27 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007172256.GA1956@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-omap@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox