Re: [PATCH 0/5] Fix SPI module alias for panels used by omapdrm

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
	"H. Nikolaus Schaller" <hns@goldelico.com>,
	dri-devel@lists.freedesktop.org,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	thierry.reding@gmail.com, Jyri Sarha <jsarha@ti.com>,
	letux-kernel@openphoenux.org
Subject: Re: [PATCH 0/5] Fix SPI module alias for panels used by omapdrm
Date: Mon, 7 Oct 2019 20:44:26 +0300	[thread overview]
Message-ID: <20191007174426.GF11781@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20191007172256.GA1956@ravnborg.org>

Hi Sam,

On Mon, Oct 07, 2019 at 07:22:56PM +0200, Sam Ravnborg wrote:
> Hi Laurent.
> On Mon, Oct 07, 2019 at 08:07:56PM +0300, Laurent Pinchart wrote:
> > Hello,
> > 
> > This patch series fixes a module alias issue with the five recently
> > added panel drivers used by omapdrm.
> > 
> > Before those panel drivers, omapdrm had custom drivers for the panels,
> > and prefixed the OF compatible strings with an "omapdss," prefix. The
> > SPI device IDs are constructed by stripping the OF compatible string
> > from the prefix, resulting in the "omapdss," prefix being removed, but
> > the subsequence OF vendor prefix being kept. The SPI drivers thus had
> > modules aliases that contained the vendor prefix.
> > 
> > Now that the panels are supported by standard drivers and the "omapdss,"
> > prefix is removed, the SPI device IDs are stripped from the OF vendor
> > prefix. As the new panel drivers copied the module aliases from the
> > omapdrm-specific drivers, they contain the vendor prefix in their SPI
> > module aliases, and are thus not loaded automatically.
> > 
> > Fix this by removing the vendor prefix from the SPI modules aliases in
> > the drivers. For consistency reason, the manual module aliases are also
> > moved to use an SPI module table.
> 
> Good explanation - thanks.
> 
> > These patches are based on the drm-misc-fixes branch as they fix v5.4
> > regressions.
> > 
> > Laurent Pinchart (5):
> >   drm/panel: lg-lb035q02: Fix SPI alias
> >   drm/panel: nec-nl8048hl11: Fix SPI alias
> >   drm/panel: sony-acx565akm: Fix SPI alias
> >   drm/panel: tpo-td028ttec1: Fix SPI alias
> >   drm/panel: tpo-td043mtea1: Fix SPI alias
> 
> Full series is:
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> 
> I expect someone else to pick them up or that you apply them.

I'd like someone to test the patches first if possible :-) Tomi, could
you then pick these up as v5.4 fixes ?

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel