* [PATCH] arm: dts: am335x-boneblack-common: fix memory size @ 2020-01-06 13:09 Matwey V. Kornilov 2020-01-06 20:43 ` Robert Nelson 0 siblings, 1 reply; 6+ messages in thread From: Matwey V. Kornilov @ 2020-01-06 13:09 UTC (permalink / raw) To: Benoît Cousson, Tony Lindgren, Rob Herring, Mark Rutland Cc: matwey.kornilov, Matwey V. Kornilov, open list:OMAP DEVICE TREE SUPPORT, open list:OMAP DEVICE TREE SUPPORT, open list BeagleBone Black series is equipped with 512MB RAM whereas only 256MB is included from am335x-bone-common.dtsi This leads to an issue with unusual setups when devicetree is loaded by GRUB2 directly. Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru> --- arch/arm/boot/dts/am335x-boneblack-common.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/am335x-boneblack-common.dtsi b/arch/arm/boot/dts/am335x-boneblack-common.dtsi index 7ad079861efd..91f93bc89716 100644 --- a/arch/arm/boot/dts/am335x-boneblack-common.dtsi +++ b/arch/arm/boot/dts/am335x-boneblack-common.dtsi @@ -131,6 +131,11 @@ }; / { + memory@80000000 { + device_type = "memory"; + reg = <0x80000000 0x20000000>; /* 512 MB */ + }; + clk_mcasp0_fixed: clk_mcasp0_fixed { #clock-cells = <0>; compatible = "fixed-clock"; -- 2.16.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: dts: am335x-boneblack-common: fix memory size 2020-01-06 13:09 [PATCH] arm: dts: am335x-boneblack-common: fix memory size Matwey V. Kornilov @ 2020-01-06 20:43 ` Robert Nelson 2020-01-06 20:47 ` Matwey V. Kornilov 0 siblings, 1 reply; 6+ messages in thread From: Robert Nelson @ 2020-01-06 20:43 UTC (permalink / raw) To: Matwey V. Kornilov Cc: Benoît Cousson, Tony Lindgren, Rob Herring, Mark Rutland, open list:OMAP DEVICE TREE SUPPORT, open list:OMAP DEVICE TREE SUPPORT, open list, Matwey V. Kornilov On Mon, Jan 6, 2020 at 7:10 AM Matwey V. Kornilov <matwey@sai.msu.ru> wrote: > > BeagleBone Black series is equipped with 512MB RAM > whereas only 256MB is included from am335x-bone-common.dtsi FYI: While all versions from the factory are 512MB, some 3rd parties offered 1GB reballing upgrades.. and the SanCloud variant which uses this file, was built with 1GB: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/am335x-sancloud-bbe.dts > > This leads to an issue with unusual setups when devicetree > is loaded by GRUB2 directly. It's a miracle, since when did GRUB2 gain this ability? > > Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru> > --- > arch/arm/boot/dts/am335x-boneblack-common.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/am335x-boneblack-common.dtsi b/arch/arm/boot/dts/am335x-boneblack-common.dtsi > index 7ad079861efd..91f93bc89716 100644 > --- a/arch/arm/boot/dts/am335x-boneblack-common.dtsi > +++ b/arch/arm/boot/dts/am335x-boneblack-common.dtsi > @@ -131,6 +131,11 @@ > }; > > / { > + memory@80000000 { > + device_type = "memory"; > + reg = <0x80000000 0x20000000>; /* 512 MB */ > + }; > + > clk_mcasp0_fixed: clk_mcasp0_fixed { > #clock-cells = <0>; > compatible = "fixed-clock"; > -- > 2.16.4 > -- Robert Nelson https://rcn-ee.com/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: dts: am335x-boneblack-common: fix memory size 2020-01-06 20:43 ` Robert Nelson @ 2020-01-06 20:47 ` Matwey V. Kornilov 2020-01-06 21:05 ` Tony Lindgren 0 siblings, 1 reply; 6+ messages in thread From: Matwey V. Kornilov @ 2020-01-06 20:47 UTC (permalink / raw) To: Robert Nelson Cc: Benoît Cousson, Tony Lindgren, Rob Herring, Mark Rutland, open list:OMAP DEVICE TREE SUPPORT, open list:OMAP DEVICE TREE SUPPORT, open list пн, 6 янв. 2020 г. в 23:44, Robert Nelson <robertcnelson@gmail.com>: > > On Mon, Jan 6, 2020 at 7:10 AM Matwey V. Kornilov <matwey@sai.msu.ru> wrote: > > > > BeagleBone Black series is equipped with 512MB RAM > > whereas only 256MB is included from am335x-bone-common.dtsi > > FYI: While all versions from the factory are 512MB, some 3rd parties > offered 1GB reballing upgrades.. > > and the SanCloud variant which uses this file, was built with 1GB: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/am335x-sancloud-bbe.dts > > > > > This leads to an issue with unusual setups when devicetree > > is loaded by GRUB2 directly. > > It's a miracle, since when did GRUB2 gain this ability? > I am not sure about when. But Grub 2.02 has devicetree command, which can be used as the following: echo "Loading device tree blob ..." devicetree (tftp)/dtb/am335x-boneblack.dtb And you know, you can run Grub itself as EFI application on to of u-boot. > > > > Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru> > > --- > > arch/arm/boot/dts/am335x-boneblack-common.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm/boot/dts/am335x-boneblack-common.dtsi b/arch/arm/boot/dts/am335x-boneblack-common.dtsi > > index 7ad079861efd..91f93bc89716 100644 > > --- a/arch/arm/boot/dts/am335x-boneblack-common.dtsi > > +++ b/arch/arm/boot/dts/am335x-boneblack-common.dtsi > > @@ -131,6 +131,11 @@ > > }; > > > > / { > > + memory@80000000 { > > + device_type = "memory"; > > + reg = <0x80000000 0x20000000>; /* 512 MB */ > > + }; > > + > > clk_mcasp0_fixed: clk_mcasp0_fixed { > > #clock-cells = <0>; > > compatible = "fixed-clock"; > > -- > > 2.16.4 > > > > > -- > Robert Nelson > https://rcn-ee.com/ -- With best regards, Matwey V. Kornilov. Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia 119234, Moscow, Universitetsky pr-k 13, +7 (495) 9392382 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: dts: am335x-boneblack-common: fix memory size 2020-01-06 20:47 ` Matwey V. Kornilov @ 2020-01-06 21:05 ` Tony Lindgren 2020-01-07 18:32 ` Robert Nelson 0 siblings, 1 reply; 6+ messages in thread From: Tony Lindgren @ 2020-01-06 21:05 UTC (permalink / raw) To: Matwey V. Kornilov Cc: Robert Nelson, Benoît Cousson, Rob Herring, Mark Rutland, open list:OMAP DEVICE TREE SUPPORT, open list:OMAP DEVICE TREE SUPPORT, open list * Matwey V. Kornilov <matwey@sai.msu.ru> [200106 20:48]: > пн, 6 янв. 2020 г. в 23:44, Robert Nelson <robertcnelson@gmail.com>: > > > > On Mon, Jan 6, 2020 at 7:10 AM Matwey V. Kornilov <matwey@sai.msu.ru> wrote: > > > > > > BeagleBone Black series is equipped with 512MB RAM > > > whereas only 256MB is included from am335x-bone-common.dtsi > > > > FYI: While all versions from the factory are 512MB, some 3rd parties > > offered 1GB reballing upgrades.. So what's the conclusion, is it safe to bump the default size to 512MB then? The custom ones could use their own dts file if bootloader is not setting the RAM. Regards, Tony ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: dts: am335x-boneblack-common: fix memory size 2020-01-06 21:05 ` Tony Lindgren @ 2020-01-07 18:32 ` Robert Nelson 2020-01-13 17:50 ` Tony Lindgren 0 siblings, 1 reply; 6+ messages in thread From: Robert Nelson @ 2020-01-07 18:32 UTC (permalink / raw) To: Tony Lindgren Cc: Matwey V. Kornilov, Benoît Cousson, Rob Herring, Mark Rutland, open list:OMAP DEVICE TREE SUPPORT, open list:OMAP DEVICE TREE SUPPORT, open list On Mon, Jan 6, 2020 at 3:05 PM Tony Lindgren <tony@atomide.com> wrote: > > * Matwey V. Kornilov <matwey@sai.msu.ru> [200106 20:48]: > > пн, 6 янв. 2020 г. в 23:44, Robert Nelson <robertcnelson@gmail.com>: > > > > > > On Mon, Jan 6, 2020 at 7:10 AM Matwey V. Kornilov <matwey@sai.msu.ru> wrote: > > > > > > > > BeagleBone Black series is equipped with 512MB RAM > > > > whereas only 256MB is included from am335x-bone-common.dtsi > > > > > > FYI: While all versions from the factory are 512MB, some 3rd parties > > > offered 1GB reballing upgrades.. > > So what's the conclusion, is it safe to bump the default size to > 512MB then? > > The custom ones could use their own dts file if bootloader is not > setting the RAM. Yeah this is safe for factory devices. Classic u-boot will update these for modified boards. Regards, -- Robert Nelson https://rcn-ee.com/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: dts: am335x-boneblack-common: fix memory size 2020-01-07 18:32 ` Robert Nelson @ 2020-01-13 17:50 ` Tony Lindgren 0 siblings, 0 replies; 6+ messages in thread From: Tony Lindgren @ 2020-01-13 17:50 UTC (permalink / raw) To: Robert Nelson Cc: Matwey V. Kornilov, Benoît Cousson, Rob Herring, Mark Rutland, open list:OMAP DEVICE TREE SUPPORT, open list:OMAP DEVICE TREE SUPPORT, open list * Robert Nelson <robertcnelson@gmail.com> [200107 18:33]: > On Mon, Jan 6, 2020 at 3:05 PM Tony Lindgren <tony@atomide.com> wrote: > > > > * Matwey V. Kornilov <matwey@sai.msu.ru> [200106 20:48]: > > > пн, 6 янв. 2020 г. в 23:44, Robert Nelson <robertcnelson@gmail.com>: > > > > > > > > On Mon, Jan 6, 2020 at 7:10 AM Matwey V. Kornilov <matwey@sai.msu.ru> wrote: > > > > > > > > > > BeagleBone Black series is equipped with 512MB RAM > > > > > whereas only 256MB is included from am335x-bone-common.dtsi > > > > > > > > FYI: While all versions from the factory are 512MB, some 3rd parties > > > > offered 1GB reballing upgrades.. > > > > So what's the conclusion, is it safe to bump the default size to > > 512MB then? > > > > The custom ones could use their own dts file if bootloader is not > > setting the RAM. > > Yeah this is safe for factory devices. Classic u-boot will update > these for modified boards. OK applying into fixes thanks. Tony ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-13 17:50 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-01-06 13:09 [PATCH] arm: dts: am335x-boneblack-common: fix memory size Matwey V. Kornilov 2020-01-06 20:43 ` Robert Nelson 2020-01-06 20:47 ` Matwey V. Kornilov 2020-01-06 21:05 ` Tony Lindgren 2020-01-07 18:32 ` Robert Nelson 2020-01-13 17:50 ` Tony Lindgren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox