From: Tony Lindgren <tony@atomide.com>
To: "Raghavendra, Vignesh" <vigneshr@ti.com>
Cc: Reid Tonking <reidt@ti.com>,
aaro.koskinen@iki.fi, jmkrzyszt@gmail.com,
linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2] i2c: omap: Fix standard mode false ACK readings
Date: Fri, 28 Apr 2023 10:43:30 +0300 [thread overview]
Message-ID: <20230428074330.GJ14287@atomide.com> (raw)
In-Reply-To: <445b3cbf-ffbc-6f77-47db-c30fc599e88f@ti.com>
* Raghavendra, Vignesh <vigneshr@ti.com> [230427 13:18]:
> On 4/27/2023 1:19 AM, Reid Tonking wrote:
> > Using standard mode, rare false ACK responses were appearing with
> > i2cdetect tool. This was happening due to NACK interrupt triggering
> > ISR thread before register access interrupt was ready. Removing the
> > NACK interrupt's ability to trigger ISR thread lets register access
> > ready interrupt do this instead.
So is it safe to leave NACK interrupt unhandled until we get the next
interrupt, does the ARDY always trigger after hitting this?
Regards,
Tony
next prev parent reply other threads:[~2023-04-28 7:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 19:49 [PATCH v2] i2c: omap: Fix standard mode false ACK readings Reid Tonking
2023-04-27 13:18 ` Raghavendra, Vignesh
2023-04-28 7:43 ` Tony Lindgren [this message]
2023-04-28 18:30 ` Reid Tonking
2023-05-03 6:03 ` Tony Lindgren
2024-09-11 9:40 ` H. Nikolaus Schaller
2024-09-13 12:09 ` Andreas Kemnade
2024-09-13 12:28 ` H. Nikolaus Schaller
2024-09-13 13:32 ` Andreas Kemnade
2024-09-13 15:01 ` H. Nikolaus Schaller
2024-11-06 9:23 ` Andreas Kemnade
2024-11-06 12:16 ` H. Nikolaus Schaller
2024-11-06 15:09 ` H. Nikolaus Schaller
2025-02-02 22:42 ` Ing. Josua Mayer
2023-04-30 5:52 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230428074330.GJ14287@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=jmkrzyszt@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=reidt@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox