public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 1/3] ARM: dts: ti: omap: add missing phy_gmii_sel unit address for dra7 SoC
@ 2024-01-23  8:55 Romain Naour
  2024-01-23  8:55 ` [PATCH v2 2/3] ARM: dts: ti: omap: add missing sys_32k_ck " Romain Naour
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Romain Naour @ 2024-01-23  8:55 UTC (permalink / raw)
  To: linux-omap, devicetree
  Cc: Benoît Cousson, Tony Lindgren, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Romain Naour

From: Romain Naour <romain.naour@skf.com>

phy_gmii_sel node have 'reg' so it must have unit address to fix dtc
W=1 warnings:

  Warning (unit_address_vs_reg): /ocp/interconnect@4a000000/segment@0/target-module@2000/scm@0/scm_conf@0/phy-gmii-sel: node has a reg or ranges property, but no unit name

Signed-off-by: Romain Naour <romain.naour@skf.com>
---
v2: update commit log
---
 arch/arm/boot/dts/ti/omap/dra7-l4.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi b/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
index 5733e3a4ea8e..6e67d99832ac 100644
--- a/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
+++ b/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
@@ -80,7 +80,7 @@ pbias_mmc_reg: pbias_mmc_omap5 {
 						};
 					};
 
-					phy_gmii_sel: phy-gmii-sel {
+					phy_gmii_sel: phy-gmii-sel@554 {
 						compatible = "ti,dra7xx-phy-gmii-sel";
 						reg = <0x554 0x4>;
 						#phy-cells = <1>;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 2/3] ARM: dts: ti: omap: add missing sys_32k_ck unit address for dra7 SoC
  2024-01-23  8:55 [PATCH v2 1/3] ARM: dts: ti: omap: add missing phy_gmii_sel unit address for dra7 SoC Romain Naour
@ 2024-01-23  8:55 ` Romain Naour
  2024-01-23  8:55 ` [PATCH v2 3/3] ARM: dts: ti: omap: add missing abb_{mpu,ivahd,dspeve,gpu} unit addresses " Romain Naour
  2024-02-26 11:56 ` [PATCH v2 1/3] ARM: dts: ti: omap: add missing phy_gmii_sel unit address " Tony Lindgren
  2 siblings, 0 replies; 4+ messages in thread
From: Romain Naour @ 2024-01-23  8:55 UTC (permalink / raw)
  To: linux-omap, devicetree
  Cc: Benoît Cousson, Tony Lindgren, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Romain Naour

From: Romain Naour <romain.naour@skf.com>

sys_32k_ck node have 'reg' so it must have unit address to fix dtc
W=1 warnings:

  Warning (unit_address_vs_reg): /ocp/interconnect@4a000000/segment@0/target-module@2000/scm@0/scm_conf@0/clocks/clock-sys-32k: node has a reg or ranges property, but no unit name

Signed-off-by: Romain Naour <romain.naour@skf.com>
---
v2: update commit log
---
 arch/arm/boot/dts/ti/omap/dra7xx-clocks.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/ti/omap/dra7xx-clocks.dtsi b/arch/arm/boot/dts/ti/omap/dra7xx-clocks.dtsi
index 04a7a6d1d529..06466d36caa9 100644
--- a/arch/arm/boot/dts/ti/omap/dra7xx-clocks.dtsi
+++ b/arch/arm/boot/dts/ti/omap/dra7xx-clocks.dtsi
@@ -1685,7 +1685,7 @@ ehrpwm2_tbclk: clock-ehrpwm2-tbclk-22@558 {
 		reg = <0x0558>;
 	};
 
-	sys_32k_ck: clock-sys-32k {
+	sys_32k_ck: clock-sys-32k@6c4 {
 		#clock-cells = <0>;
 		compatible = "ti,mux-clock";
 		clock-output-names = "sys_32k_ck";
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 3/3] ARM: dts: ti: omap: add missing abb_{mpu,ivahd,dspeve,gpu} unit addresses for dra7 SoC
  2024-01-23  8:55 [PATCH v2 1/3] ARM: dts: ti: omap: add missing phy_gmii_sel unit address for dra7 SoC Romain Naour
  2024-01-23  8:55 ` [PATCH v2 2/3] ARM: dts: ti: omap: add missing sys_32k_ck " Romain Naour
@ 2024-01-23  8:55 ` Romain Naour
  2024-02-26 11:56 ` [PATCH v2 1/3] ARM: dts: ti: omap: add missing phy_gmii_sel unit address " Tony Lindgren
  2 siblings, 0 replies; 4+ messages in thread
From: Romain Naour @ 2024-01-23  8:55 UTC (permalink / raw)
  To: linux-omap, devicetree
  Cc: Benoît Cousson, Tony Lindgren, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Romain Naour

From: Romain Naour <romain.naour@skf.com>

abb_{mpu,ivahd,dspeve,gpu} have 'reg' so they must have unit address to fix dtc
W=1 warnings:

  Warning (unit_address_vs_reg): /ocp/regulator-abb-mpu: node has a reg or ranges property, but no unit name
  Warning (unit_address_vs_reg): /ocp/regulator-abb-ivahd: node has a reg or ranges property, but no unit name
  Warning (unit_address_vs_reg): /ocp/regulator-abb-dspeve: node has a reg or ranges property, but no unit name
  Warning (unit_address_vs_reg): /ocp/regulator-abb-gpu: node has a reg or ranges property, but no unit name

Signed-off-by: Romain Naour <romain.naour@skf.com>
---
v2: update commit log
---
 arch/arm/boot/dts/ti/omap/dra7.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/ti/omap/dra7.dtsi b/arch/arm/boot/dts/ti/omap/dra7.dtsi
index 6509c742fb58..565ac7691a2a 100644
--- a/arch/arm/boot/dts/ti/omap/dra7.dtsi
+++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi
@@ -638,7 +638,7 @@ mmu_ipu2: mmu@0 {
 			};
 		};
 
-		abb_mpu: regulator-abb-mpu {
+		abb_mpu: regulator-abb-mpu@4ae07ddc {
 			compatible = "ti,abb-v3";
 			regulator-name = "abb_mpu";
 			#address-cells = <0>;
@@ -671,7 +671,7 @@ abb_mpu: regulator-abb-mpu {
 			>;
 		};
 
-		abb_ivahd: regulator-abb-ivahd {
+		abb_ivahd: regulator-abb-ivahd@4ae07e34 {
 			compatible = "ti,abb-v3";
 			regulator-name = "abb_ivahd";
 			#address-cells = <0>;
@@ -704,7 +704,7 @@ abb_ivahd: regulator-abb-ivahd {
 			>;
 		};
 
-		abb_dspeve: regulator-abb-dspeve {
+		abb_dspeve: regulator-abb-dspeve@4ae07e30 {
 			compatible = "ti,abb-v3";
 			regulator-name = "abb_dspeve";
 			#address-cells = <0>;
@@ -737,7 +737,7 @@ abb_dspeve: regulator-abb-dspeve {
 			>;
 		};
 
-		abb_gpu: regulator-abb-gpu {
+		abb_gpu: regulator-abb-gpu@4ae07de4 {
 			compatible = "ti,abb-v3";
 			regulator-name = "abb_gpu";
 			#address-cells = <0>;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/3] ARM: dts: ti: omap: add missing phy_gmii_sel unit address for dra7 SoC
  2024-01-23  8:55 [PATCH v2 1/3] ARM: dts: ti: omap: add missing phy_gmii_sel unit address for dra7 SoC Romain Naour
  2024-01-23  8:55 ` [PATCH v2 2/3] ARM: dts: ti: omap: add missing sys_32k_ck " Romain Naour
  2024-01-23  8:55 ` [PATCH v2 3/3] ARM: dts: ti: omap: add missing abb_{mpu,ivahd,dspeve,gpu} unit addresses " Romain Naour
@ 2024-02-26 11:56 ` Tony Lindgren
  2 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2024-02-26 11:56 UTC (permalink / raw)
  To: Romain Naour
  Cc: linux-omap, devicetree, Benoît Cousson, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Romain Naour

* Romain Naour <romain.naour@smile.fr> [240123 10:56]:
> From: Romain Naour <romain.naour@skf.com>
> 
> phy_gmii_sel node have 'reg' so it must have unit address to fix dtc
> W=1 warnings:

Adding all three into omap-for-v6.9/dt thanks.

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-02-26 11:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-23  8:55 [PATCH v2 1/3] ARM: dts: ti: omap: add missing phy_gmii_sel unit address for dra7 SoC Romain Naour
2024-01-23  8:55 ` [PATCH v2 2/3] ARM: dts: ti: omap: add missing sys_32k_ck " Romain Naour
2024-01-23  8:55 ` [PATCH v2 3/3] ARM: dts: ti: omap: add missing abb_{mpu,ivahd,dspeve,gpu} unit addresses " Romain Naour
2024-02-26 11:56 ` [PATCH v2 1/3] ARM: dts: ti: omap: add missing phy_gmii_sel unit address " Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox