Re: [PATCH] dt-bindings: omap: Add TI Pandaboard A4 variant

[Tom Rini <trini@konsulko.com>]

On Wed, Jan 22, 2025 at 09:32:36AM +0100, Andreas Kemnade wrote:
> Am Tue, 21 Jan 2025 18:12:40 -0600
> schrieb Tom Rini <trini@konsulko.com>:
> 
> > Document the ti,omap4-panda-a4 compatible string in the appropriate
> > place within the omap family binding file.
> > 
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> > Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
> > Cc: Andreas Kemnade <andreas@kemnade.info>
> > Cc: Kevin Hilman <khilman@baylibre.com>
> > Cc: Roger Quadros <rogerq@kernel.org>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> > Cc: Conor Dooley <conor+dt@kernel.org>
> > Cc: linux-omap@vger.kernel.org
> > Cc: devicetree@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > ---
> >  Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > index 93e04a109a12..28e23ca766b4 100644
> > --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > @@ -137,6 +137,7 @@ properties:
> >                - motorola,xyboard-mz609
> >                - motorola,xyboard-mz617
> >                - ti,omap4-panda
> > +              - ti,omap4-panda-a4
> >                - ti,omap4-sdp
> >            - const: ti,omap4430
> >            - const: ti,omap4
> 
> This allows compatible = "ti,omap4-panda-a4", "ti,omap4430", "ti,omap4"
> 
> According to your other patch, you want
> compatible = "ti,omap4-panda-a4", "ti,omap4-panda", "ti,omap4430",
> "ti,omap4"
> 
> so you need a construction similar to the "ti,omap3-beagle-ab4"

Do you mean the order should change, or it should be an enum? I'm not
sure where this is documented (the $id and $schema values in the file
are just 404s so I guess not something to read directly?).

-- 
Tom