From: Tom Rini <trini@konsulko.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Andreas Kemnade <andreas@kemnade.info>,
Kevin Hilman <khilman@baylibre.com>,
Roger Quadros <rogerq@kernel.org>,
Tony Lindgren <tony@atomide.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: omap: Add TI Pandaboard A4 variant
Date: Wed, 22 Jan 2025 13:52:06 -0600 [thread overview]
Message-ID: <20250122195206.GA60249@bill-the-cat> (raw)
In-Reply-To: <17d1708c-e326-468c-941a-1863dfdc946d@kernel.org>
On Wed, Jan 22, 2025 at 04:08:27PM +0100, Krzysztof Kozlowski wrote:
> On 22/01/2025 15:17, Tom Rini wrote:
> > On Wed, Jan 22, 2025 at 09:36:29AM +0100, Krzysztof Kozlowski wrote:
> >> On 22/01/2025 01:12, Tom Rini wrote:
> >>> Document the ti,omap4-panda-a4 compatible string in the appropriate
> >>> place within the omap family binding file.
> >>
> >> Why? Where is any user of this? Your commit msg should explain this,
> >> because it's not obvious. Obvious is to send binding with the user, but
> >> the second patch is missing.
> >
> > You were cc'd on
> > https://lore.kernel.org/all/20250121200749.4131923-1-trini@konsulko.com/
> I am cc-ed on 200 patches per day and it means nothing. Do you expect me
> to look for missing user in 1000 patches per week, for every 1000
> patches? Or how does it supposed to work?
Being an overwhelmed maintainer sucks, I really do get that, sorry for
my short reply.
> But regardless, the majority of review is done via patchwork and that
> DTS patch was not in that thread. It's missing.
>
> You are supposed to send the binding and the user DTS in the same
> patchset. Separate makes little sense in case of kernel.
>
> If you need the binding for other projects, then of course above changes
> into: always reference the other project submission.
It's fixing a 10 year old regression where the equally viable option is
to just delete the dts file as I'm 99.9% sure no one has even tried
using it in that time.
--
Tom
prev parent reply other threads:[~2025-01-22 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 0:12 [PATCH] dt-bindings: omap: Add TI Pandaboard A4 variant Tom Rini
2025-01-22 8:32 ` Andreas Kemnade
2025-01-22 14:20 ` Tom Rini
2025-01-22 22:20 ` Andreas Kemnade
2025-01-22 22:36 ` Robert Nelson
2025-01-22 8:36 ` Krzysztof Kozlowski
2025-01-22 14:17 ` Tom Rini
2025-01-22 15:08 ` Krzysztof Kozlowski
2025-01-22 19:52 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250122195206.GA60249@bill-the-cat \
--to=trini@konsulko.com \
--cc=aaro.koskinen@iki.fi \
--cc=andreas@kemnade.info \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox