From: Shree Ramamoorthy <s-ramamoorthy@ti.com>
To: <lgirdwood@gmail.com>, <broonie@kernel.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<aaro.koskinen@iki.fi>, <andreas@kemnade.info>,
<khilman@baylibre.com>, <rogerq@kernel.org>, <tony@atomide.com>,
<lee@kernel.org>, <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Cc: <m-leonard@ti.com>, <praneeth@ti.com>
Subject: [PATCH v6 3/9] mfd: tps65219: Remove regmap_read check
Date: Wed, 5 Mar 2025 15:03:45 -0600 [thread overview]
Message-ID: <20250305210351.249811-4-s-ramamoorthy@ti.com> (raw)
In-Reply-To: <20250305210351.249811-1-s-ramamoorthy@ti.com>
The chipid macro/variable and regmap_read function call is not needed
because the TPS65219_REG_TI_DEV_ID register value is not a consistent value
across TPS65219 PMIC config versions. Reading from the DEV_ID register
without a consistent value to compare it to isn't useful. There isn't a
way to verify the match data ID is the same ID read from the DEV_ID device
register. 0xF0 isn't a DEV_ID value consistent across TPS65219 NVM
configurations.
For TPS65215, there is a consistent value in bits 5-0 of the DEV_ID
register. However, there are other error checks in place within probe()
that apply to both PMICs rather than keeping this isolated check for one
PMIC.
Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com>
---
drivers/mfd/tps65219.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/mfd/tps65219.c b/drivers/mfd/tps65219.c
index 081c5a30b04a..4aca922658e3 100644
--- a/drivers/mfd/tps65219.c
+++ b/drivers/mfd/tps65219.c
@@ -221,7 +221,6 @@ static const struct regmap_irq_chip tps65219_irq_chip = {
static int tps65219_probe(struct i2c_client *client)
{
struct tps65219 *tps;
- unsigned int chipid;
bool pwr_button;
int ret;
@@ -246,12 +245,6 @@ static int tps65219_probe(struct i2c_client *client)
if (ret)
return ret;
- ret = regmap_read(tps->regmap, TPS65219_REG_TI_DEV_ID, &chipid);
- if (ret) {
- dev_err(tps->dev, "Failed to read device ID: %d\n", ret);
- return ret;
- }
-
ret = devm_mfd_add_devices(tps->dev, PLATFORM_DEVID_AUTO,
tps65219_cells, ARRAY_SIZE(tps65219_cells),
NULL, 0, regmap_irq_get_domain(tps->irq_data));
--
2.43.0
next prev parent reply other threads:[~2025-03-05 21:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 21:03 [PATCH v6 0/9] Add TI TPS65214 & TPS65215 MFD & Regulator Support Shree Ramamoorthy
2025-03-05 21:03 ` [PATCH v6 1/9] regulator: dt-bindings: Add TI TPS65215 PMIC bindings Shree Ramamoorthy
2025-03-05 21:03 ` [PATCH v6 2/9] regulator: dt-bindings: Add TI TPS65214 " Shree Ramamoorthy
2025-03-06 7:25 ` Krzysztof Kozlowski
2025-03-06 22:58 ` Shree Ramamoorthy
2025-03-05 21:03 ` Shree Ramamoorthy [this message]
2025-03-05 21:03 ` [PATCH v6 4/9] mfd: tps65219: Add support for TI TPS65215 PMIC Shree Ramamoorthy
2025-03-05 21:03 ` [PATCH v6 5/9] mfd: tps65219: Add support for TI TPS65214 PMIC Shree Ramamoorthy
2025-03-05 21:03 ` [PATCH v6 6/9] regulator: tps65219: Update struct names Shree Ramamoorthy
2025-03-05 21:03 ` [PATCH v6 7/9] regulator: tps65219: Add support for TPS65215 regulator resources Shree Ramamoorthy
2025-03-05 21:03 ` [PATCH v6 8/9] regulator: tps65219: Add support for TPS65215 Regulator IRQs Shree Ramamoorthy
2025-03-05 21:03 ` [PATCH v6 9/9] regulator: tps65219: Add TI TPS65214 Regulator Support Shree Ramamoorthy
2025-03-06 7:27 ` [PATCH v6 0/9] Add TI TPS65214 & TPS65215 MFD & " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250305210351.249811-4-s-ramamoorthy@ti.com \
--to=s-ramamoorthy@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=andreas@kemnade.info \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m-leonard@ti.com \
--cc=praneeth@ti.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox