From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Pan Chuang <panchuang@vivo.com>
Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
William Breathitt Gray <wbg@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Julien Panis <jpanis@baylibre.com>,
David Lechner <david@lechnology.com>,
linux-iio@vger.kernel.org (open list:COUNTER SUBSYSTEM),
linux-stm32@st-md-mailman.stormreply.com (moderated
list:ARM/STM32 ARCHITECTURE),
linux-arm-kernel@lists.infradead.org (moderated list:ARM/STM32
ARCHITECTURE), linux-kernel@vger.kernel.org (open list),
linux-omap@vger.kernel.org (open list:TI ENHANCED CAPTURE (eCAP)
DRIVER)
Subject: Re: [PATCH 0/3] counter: Remove redundant error messages on IRQ request failure
Date: Wed, 15 Jul 2026 16:00:48 +0200 [thread overview]
Message-ID: <20260715160048.00000737@gmail.com> (raw)
In-Reply-To: <20260715135030.326290-1-panchuang@vivo.com>
On Wed, 15 Jul 2026 21:50:27 +0800
Pan Chuang <panchuang@vivo.com> wrote:
> Commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()") added automatic error logging to
> devm_request_threaded_irq() and devm_request_any_context_irq()
> via the new devm_request_result() helper, which prints device
> name, IRQ number, handler functions, and error code on failure.
>
> Since devm_request_irq() is a static inline wrapper around
> devm_request_threaded_irq(), it also benefits from this
> automatic logging.
>
> Remove the now-redundant dev_err() and dev_err_probe() calls
> in counter drivers that follow these devm_request_*_irq()
> functions, as the core now provides more detailed diagnostic
> information on failure.
>
> Pan Chuang (3):
> counter: stm32-timer-cnt: Remove redundant dev_err()
> counter: ti-ecap-capture: Remove redundant dev_err_probe()
> counter: ti-eqep: Remove redundant dev_err_probe()
>
> drivers/counter/stm32-timer-cnt.c | 10 ++--------
> drivers/counter/ti-ecap-capture.c | 2 +-
> drivers/counter/ti-eqep.c | 2 +-
> 3 files changed, 4 insertions(+), 10 deletions(-)
>
LGTM.
--
Kind regards
CJD
prev parent reply other threads:[~2026-07-15 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 13:50 [PATCH 0/3] counter: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-15 13:50 ` [PATCH 2/3] counter: ti-ecap-capture: Remove redundant dev_err_probe() Pan Chuang
2026-07-15 14:00 ` Joshua Crofts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260715160048.00000737@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=david@lechnology.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=jpanis@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=panchuang@vivo.com \
--cc=vigneshr@ti.com \
--cc=wbg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox