[PATCH 0/3] counter: Remove redundant error messages on IRQ request failure

[PATCH 0/3] counter: Remove redundant error messages on IRQ request failure

[Pan Chuang]

Commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()") added automatic error logging to
devm_request_threaded_irq() and devm_request_any_context_irq()
via the new devm_request_result() helper, which prints device
name, IRQ number, handler functions, and error code on failure.

Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this
automatic logging.

Remove the now-redundant dev_err() and dev_err_probe() calls
in counter drivers that follow these devm_request_*_irq()
functions, as the core now provides more detailed diagnostic
information on failure.

Pan Chuang (3):
  counter: stm32-timer-cnt: Remove redundant dev_err()
  counter: ti-ecap-capture: Remove redundant dev_err_probe()
  counter: ti-eqep: Remove redundant dev_err_probe()

 drivers/counter/stm32-timer-cnt.c | 10 ++--------
 drivers/counter/ti-ecap-capture.c |  2 +-
 drivers/counter/ti-eqep.c         |  2 +-
 3 files changed, 4 insertions(+), 10 deletions(-)

-- 
2.34.1

[PATCH 2/3] counter: ti-ecap-capture: Remove redundant dev_err_probe()

[Pan Chuang]

devm_request_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err_probe() call.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/counter/ti-ecap-capture.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/counter/ti-ecap-capture.c b/drivers/counter/ti-ecap-capture.c
index f69b6920463f..d77a256f0ed3 100644
--- a/drivers/counter/ti-ecap-capture.c
+++ b/drivers/counter/ti-ecap-capture.c
@@ -513,7 +513,7 @@ static int ecap_cnt_probe(struct platform_device *pdev)
 
 	ret = devm_request_irq(dev, ret, ecap_cnt_isr, 0, pdev->name, counter_dev);
 	if (ret)
-		return dev_err_probe(dev, ret, "failed to request irq\n");
+		return ret;
 
 	platform_set_drvdata(pdev, counter_dev);
 
-- 
2.34.1

Re: [PATCH 0/3] counter: Remove redundant error messages on IRQ request failure

[Joshua Crofts]

On Wed, 15 Jul 2026 21:50:27 +0800
Pan Chuang <panchuang@vivo.com> wrote:

> Commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()") added automatic error logging to
> devm_request_threaded_irq() and devm_request_any_context_irq()
> via the new devm_request_result() helper, which prints device
> name, IRQ number, handler functions, and error code on failure.
> 
> Since devm_request_irq() is a static inline wrapper around
> devm_request_threaded_irq(), it also benefits from this
> automatic logging.
> 
> Remove the now-redundant dev_err() and dev_err_probe() calls
> in counter drivers that follow these devm_request_*_irq()
> functions, as the core now provides more detailed diagnostic
> information on failure.
> 
> Pan Chuang (3):
>   counter: stm32-timer-cnt: Remove redundant dev_err()
>   counter: ti-ecap-capture: Remove redundant dev_err_probe()
>   counter: ti-eqep: Remove redundant dev_err_probe()
> 
>  drivers/counter/stm32-timer-cnt.c | 10 ++--------
>  drivers/counter/ti-ecap-capture.c |  2 +-
>  drivers/counter/ti-eqep.c         |  2 +-
>  3 files changed, 4 insertions(+), 10 deletions(-)
> 

LGTM.

-- 
Kind regards

CJD