* [PATCH 0/5] ARM: dts: fix faulty ohci/ehci node names
@ 2025-03-30 12:13 Wolfram Sang
2025-03-30 12:13 ` [PATCH 4/5] ARM: dts: ti: omap: " Wolfram Sang
2025-03-30 15:57 ` [PATCH 0/5] ARM: dts: " Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Wolfram Sang @ 2025-03-30 12:13 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Wolfram Sang, Alexey Charkov, Andrew Lunn, Conor Dooley,
devicetree, Gregory Clement, Krzysztof Kozlowski,
Krzysztof Kozlowski, linux-omap, Piotr Wojtaszczyk, Rob Herring,
Sebastian Hesselbarth, Shiraz Hashim, soc, Tony Lindgren,
Viresh Kumar, Vladimir Zapolskiy
After I fixed this for the at91-boards I was interested in, I let the
scripts run for the other boards, too, of course. Here is the outcome.
49 less dtbs_check errors. Build bots were happy. No dependencies, I
suggest sub-trees apply them on their own. Thanks!
Happy hacking,
Wolfram
Wolfram Sang (5):
ARM: dts: marvell: fix faulty ohci/ehci node names
ARM: dts: nxp: lpc: fix faulty ohci/ehci node names
ARM: dts: st: fix faulty ohci/ehci node names
ARM: dts: ti: omap: fix faulty ohci/ehci node names
ARM: dts: vt8500: fix faulty ohci/ehci node names
arch/arm/boot/dts/marvell/kirkwood-db.dtsi | 2 +-
arch/arm/boot/dts/marvell/kirkwood-dir665.dts | 2 +-
arch/arm/boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts | 2 +-
arch/arm/boot/dts/marvell/kirkwood.dtsi | 2 +-
arch/arm/boot/dts/marvell/orion5x.dtsi | 4 ++--
arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi | 2 +-
arch/arm/boot/dts/st/spear1310-evb.dts | 8 ++++----
arch/arm/boot/dts/st/spear1340-evb.dts | 8 ++++----
arch/arm/boot/dts/st/spear13xx.dtsi | 8 ++++----
arch/arm/boot/dts/st/spear300-evb.dts | 6 +++---
arch/arm/boot/dts/st/spear310-evb.dts | 6 +++---
arch/arm/boot/dts/st/spear320-evb.dts | 6 +++---
arch/arm/boot/dts/st/spear320-hmi.dts | 6 +++---
arch/arm/boot/dts/st/spear3xx.dtsi | 6 +++---
arch/arm/boot/dts/st/spear600.dtsi | 8 ++++----
arch/arm/boot/dts/ti/omap/omap3.dtsi | 4 ++--
arch/arm/boot/dts/ti/omap/omap4-l4.dtsi | 4 ++--
arch/arm/boot/dts/ti/omap/omap5-l4.dtsi | 4 ++--
arch/arm/boot/dts/vt8500/vt8500.dtsi | 2 +-
arch/arm/boot/dts/vt8500/wm8505.dtsi | 2 +-
arch/arm/boot/dts/vt8500/wm8650.dtsi | 2 +-
arch/arm/boot/dts/vt8500/wm8750.dtsi | 2 +-
arch/arm/boot/dts/vt8500/wm8850.dtsi | 2 +-
23 files changed, 49 insertions(+), 49 deletions(-)
--
2.47.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 4/5] ARM: dts: ti: omap: fix faulty ohci/ehci node names
2025-03-30 12:13 [PATCH 0/5] ARM: dts: fix faulty ohci/ehci node names Wolfram Sang
@ 2025-03-30 12:13 ` Wolfram Sang
2025-03-30 15:57 ` [PATCH 0/5] ARM: dts: " Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2025-03-30 12:13 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Wolfram Sang, Tony Lindgren, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-omap, devicetree
They should be named "usb@".
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/arm/boot/dts/ti/omap/omap3.dtsi | 4 ++--
arch/arm/boot/dts/ti/omap/omap4-l4.dtsi | 4 ++--
arch/arm/boot/dts/ti/omap/omap5-l4.dtsi | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/ti/omap/omap3.dtsi b/arch/arm/boot/dts/ti/omap/omap3.dtsi
index 92cd4c99dae7..817474ee2d13 100644
--- a/arch/arm/boot/dts/ti/omap/omap3.dtsi
+++ b/arch/arm/boot/dts/ti/omap/omap3.dtsi
@@ -862,14 +862,14 @@ usbhshost: usbhshost@48064000 {
#size-cells = <1>;
ranges;
- usbhsohci: ohci@48064400 {
+ usbhsohci: usb@48064400 {
compatible = "ti,ohci-omap3";
reg = <0x48064400 0x400>;
interrupts = <76>;
remote-wakeup-connected;
};
- usbhsehci: ehci@48064800 {
+ usbhsehci: usb@48064800 {
compatible = "ti,ehci-omap";
reg = <0x48064800 0x400>;
interrupts = <77>;
diff --git a/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi b/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi
index 150dd84c9e0f..4ee53dfb71b4 100644
--- a/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi
+++ b/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi
@@ -302,14 +302,14 @@ usbhshost: usbhshost@0 {
"refclk_60m_ext_p1",
"refclk_60m_ext_p2";
- usbhsohci: ohci@800 {
+ usbhsohci: usb@800 {
compatible = "ti,ohci-omap3";
reg = <0x800 0x400>;
interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
remote-wakeup-connected;
};
- usbhsehci: ehci@c00 {
+ usbhsehci: usb@c00 {
compatible = "ti,ehci-omap";
reg = <0xc00 0x400>;
interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
diff --git a/arch/arm/boot/dts/ti/omap/omap5-l4.dtsi b/arch/arm/boot/dts/ti/omap/omap5-l4.dtsi
index 3b505fe415ed..9f6100c7c34d 100644
--- a/arch/arm/boot/dts/ti/omap/omap5-l4.dtsi
+++ b/arch/arm/boot/dts/ti/omap/omap5-l4.dtsi
@@ -331,14 +331,14 @@ usbhshost: usbhshost@0 {
"refclk_60m_ext_p1",
"refclk_60m_ext_p2";
- usbhsohci: ohci@800 {
+ usbhsohci: usb@800 {
compatible = "ti,ohci-omap3";
reg = <0x800 0x400>;
interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
remote-wakeup-connected;
};
- usbhsehci: ehci@c00 {
+ usbhsehci: usb@c00 {
compatible = "ti,ehci-omap";
reg = <0xc00 0x400>;
interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
--
2.47.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 0/5] ARM: dts: fix faulty ohci/ehci node names
2025-03-30 12:13 [PATCH 0/5] ARM: dts: fix faulty ohci/ehci node names Wolfram Sang
2025-03-30 12:13 ` [PATCH 4/5] ARM: dts: ti: omap: " Wolfram Sang
@ 2025-03-30 15:57 ` Krzysztof Kozlowski
2025-03-30 15:59 ` Krzysztof Kozlowski
2025-03-30 16:38 ` Wolfram Sang
1 sibling, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-30 15:57 UTC (permalink / raw)
To: Wolfram Sang, linux-arm-kernel
Cc: Alexey Charkov, Andrew Lunn, Conor Dooley, devicetree,
Gregory Clement, Krzysztof Kozlowski, linux-omap,
Piotr Wojtaszczyk, Rob Herring, Sebastian Hesselbarth,
Shiraz Hashim, soc, Tony Lindgren, Viresh Kumar,
Vladimir Zapolskiy
On 30/03/2025 14:13, Wolfram Sang wrote:
> After I fixed this for the at91-boards I was interested in, I let the
> scripts run for the other boards, too, of course. Here is the outcome.
> 49 less dtbs_check errors. Build bots were happy. No dependencies, I
> suggest sub-trees apply them on their own. Thanks!
>
For this and the rest patches, I would not call it "fix" in the subject
because there is no bug to fix here and you just might confuse AUTOSEL.
What's more backporting this might actually cause regressions, because
in rare cases node name is an ABI. Therefore avoid calling anything here
fix.
You just adjust or align them with coding style or what
bindings/dtschema expect (but it expects due to generic naming
convention which is still just convention).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/5] ARM: dts: fix faulty ohci/ehci node names
2025-03-30 15:57 ` [PATCH 0/5] ARM: dts: " Krzysztof Kozlowski
@ 2025-03-30 15:59 ` Krzysztof Kozlowski
2025-03-30 16:38 ` Wolfram Sang
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-30 15:59 UTC (permalink / raw)
To: Wolfram Sang, linux-arm-kernel
Cc: Alexey Charkov, Andrew Lunn, Conor Dooley, devicetree,
Gregory Clement, Krzysztof Kozlowski, linux-omap,
Piotr Wojtaszczyk, Rob Herring, Sebastian Hesselbarth,
Shiraz Hashim, soc, Tony Lindgren, Viresh Kumar,
Vladimir Zapolskiy
On 30/03/2025 17:57, Krzysztof Kozlowski wrote:
> On 30/03/2025 14:13, Wolfram Sang wrote:
>> After I fixed this for the at91-boards I was interested in, I let the
>> scripts run for the other boards, too, of course. Here is the outcome.
>> 49 less dtbs_check errors. Build bots were happy. No dependencies, I
>> suggest sub-trees apply them on their own. Thanks!
>>
>
> For this and the rest patches, I would not call it "fix" in the subject
> because there is no bug to fix here and you just might confuse AUTOSEL.
> What's more backporting this might actually cause regressions, because
> in rare cases node name is an ABI. Therefore avoid calling anything here
> fix.
>
> You just adjust or align them with coding style or what
> bindings/dtschema expect (but it expects due to generic naming
> convention which is still just convention).
>
And I forgot:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/5] ARM: dts: fix faulty ohci/ehci node names
2025-03-30 15:57 ` [PATCH 0/5] ARM: dts: " Krzysztof Kozlowski
2025-03-30 15:59 ` Krzysztof Kozlowski
@ 2025-03-30 16:38 ` Wolfram Sang
1 sibling, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2025-03-30 16:38 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-arm-kernel, Alexey Charkov, Andrew Lunn, Conor Dooley,
devicetree, Gregory Clement, Krzysztof Kozlowski, linux-omap,
Piotr Wojtaszczyk, Rob Herring, Sebastian Hesselbarth,
Shiraz Hashim, soc, Tony Lindgren, Viresh Kumar,
Vladimir Zapolskiy
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
> You just adjust or align them with coding style or what
> bindings/dtschema expect (but it expects due to generic naming
> convention which is still just convention).
Ack, I will "fix" :) the subjects and add your tag. Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-03-30 16:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-30 12:13 [PATCH 0/5] ARM: dts: fix faulty ohci/ehci node names Wolfram Sang
2025-03-30 12:13 ` [PATCH 4/5] ARM: dts: ti: omap: " Wolfram Sang
2025-03-30 15:57 ` [PATCH 0/5] ARM: dts: " Krzysztof Kozlowski
2025-03-30 15:59 ` Krzysztof Kozlowski
2025-03-30 16:38 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox