* [PATCH v2] ti: fix possible memory leak in _ti_omap4_clkctrl_setup()
@ 2023-10-27 2:50 Hangyu Hua
2023-10-31 7:24 ` claudiu beznea
0 siblings, 1 reply; 2+ messages in thread
From: Hangyu Hua @ 2023-10-27 2:50 UTC (permalink / raw)
To: kristo, mturquette, sboyd, tony, dario.binacchi, claudiu.beznea,
robh, andriy.shevchenko
Cc: linux-omap, linux-clk, linux-kernel, Hangyu Hua
kstrndup() and kstrdup_and_replace() in clkctrl_get_name() can perform
dynamic memory allocation. So clkctrl_name() needs to be freed when
provider->clkdm_name is NULL.
Fixes: bd46cd0b802d ("clk: ti: clkctrl: check return value of kasprintf()")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
---
v2: fix commit info.
drivers/clk/ti/clkctrl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/ti/clkctrl.c b/drivers/clk/ti/clkctrl.c
index 607e34d8e289..cb4aa8a45bb2 100644
--- a/drivers/clk/ti/clkctrl.c
+++ b/drivers/clk/ti/clkctrl.c
@@ -591,6 +591,7 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node)
provider->clkdm_name = kasprintf(GFP_KERNEL,
"%s_clkdm", clkctrl_name);
if (!provider->clkdm_name) {
+ kfree(clkctrl_name);
kfree(provider);
return;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ti: fix possible memory leak in _ti_omap4_clkctrl_setup()
2023-10-27 2:50 [PATCH v2] ti: fix possible memory leak in _ti_omap4_clkctrl_setup() Hangyu Hua
@ 2023-10-31 7:24 ` claudiu beznea
0 siblings, 0 replies; 2+ messages in thread
From: claudiu beznea @ 2023-10-31 7:24 UTC (permalink / raw)
To: Hangyu Hua, kristo, mturquette, sboyd, tony, dario.binacchi,
claudiu.beznea, robh, andriy.shevchenko
Cc: linux-omap, linux-clk, linux-kernel
On 27.10.2023 05:50, Hangyu Hua wrote:
> kstrndup() and kstrdup_and_replace() in clkctrl_get_name() can perform
> dynamic memory allocation. So clkctrl_name() needs to be freed when
s/clkctrl_name()/clkctrl_name
> provider->clkdm_name is NULL.
>
> Fixes: bd46cd0b802d ("clk: ti: clkctrl: check return value of kasprintf()")
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
> ---
>
> v2: fix commit info.
>
> drivers/clk/ti/clkctrl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/ti/clkctrl.c b/drivers/clk/ti/clkctrl.c
> index 607e34d8e289..cb4aa8a45bb2 100644
> --- a/drivers/clk/ti/clkctrl.c
> +++ b/drivers/clk/ti/clkctrl.c
> @@ -591,6 +591,7 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node)
> provider->clkdm_name = kasprintf(GFP_KERNEL,
> "%s_clkdm", clkctrl_name);
> if (!provider->clkdm_name) {
> + kfree(clkctrl_name);
> kfree(provider);
> return;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-31 7:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-27 2:50 [PATCH v2] ti: fix possible memory leak in _ti_omap4_clkctrl_setup() Hangyu Hua
2023-10-31 7:24 ` claudiu beznea
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox