Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
* [PATCH] arm/dts: omap: Add omap-usb2 dt data
@ 2012-09-11  6:12 Kishon Vijay Abraham I
  2012-09-11  8:23 ` Benoit Cousson
  0 siblings, 1 reply; 3+ messages in thread
From: Kishon Vijay Abraham I @ 2012-09-11  6:12 UTC (permalink / raw)
  To: balbi-l0cyMroinI0, arnd-r2nGTMty4D4,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
	grant.likely-s3s/WqlpOiPyB63q8FvJNQ,
	rob.herring-bsGFqQB8/DxBDgjK7y7TUQ, b-cousson-l0cyMroinI0,
	rnayak-l0cyMroinI0, tony-4v6yS6AI5VpBDgjK7y7TUQ,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
	linux-doc-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-omap-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA
  Cc: ohad-Ix1uc/W3ht7QT0dZR+AlfA, linux-lFZ/pmaqli7XmaaqVzeoHQ,
	rusty-8n+1lVoiYb80n/F98K4Iww, Kishon Vijay Abraham I,
	myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ,
	swarren-DDmLM1+adcrQT0dZR+AlfA

Add omap-usb2 data node in omap4 device tree file. Since omap-usb2 is
connected to ocp2scp, omap-usb2 dt data is added as a child node
of ocp2scp.

Acked-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Signed-off-by: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
---
Applies on
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git for-next
 arch/arm/boot/dts/omap4.dtsi |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index 8a780b2..bdc21f1 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -302,6 +302,11 @@
 			#size-cells = <1>;
 			ranges;
 			ti,hwmods = "ocp2scp_usb_phy";
+			usb2phy@4a0ad080 {
+				compatible = "ti,omap-usb2";
+				reg = <0x4a0ad080 0x58>,
+				      <0x4a002300 0x4>;
+			};
 		};
 	};
 };
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm/dts: omap: Add omap-usb2 dt data
  2012-09-11  6:12 [PATCH] arm/dts: omap: Add omap-usb2 dt data Kishon Vijay Abraham I
@ 2012-09-11  8:23 ` Benoit Cousson
       [not found]   ` <504EF4FD.2080001-l0cyMroinI0@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Benoit Cousson @ 2012-09-11  8:23 UTC (permalink / raw)
  To: Kishon Vijay Abraham I
  Cc: balbi, arnd, akpm, grant.likely, rob.herring, rnayak, tony,
	gregkh, devicetree-discuss, linux-doc, linux-kernel,
	linux-arm-kernel, linux-omap, linux-usb, rob, linux, ohad,
	linus.walleij, myungjoo.ham, rusty, swarren

Hi Kishon,

On 09/11/2012 08:12 AM, Kishon Vijay Abraham I wrote:
> Add omap-usb2 data node in omap4 device tree file. Since omap-usb2 is
> connected to ocp2scp, omap-usb2 dt data is added as a child node
> of ocp2scp.

Could you add more details about the omap-usb2?

You must update the Documentation binding with that compatible name.
Is it already part of the driver serie? The MUSB driver is referring to
"ti,musb-omap2430" only.

> 
> Acked-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> Applies on
> git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git for-next
>  arch/arm/boot/dts/omap4.dtsi |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> index 8a780b2..bdc21f1 100644
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> @@ -302,6 +302,11 @@
>  			#size-cells = <1>;
>  			ranges;
>  			ti,hwmods = "ocp2scp_usb_phy";

There is no ocp2scp_usb_phy in the current omap4.dtsi?
What base did you used?

You have to use lo/devel-dt branch as a base. All the latest DTS patches
an in there for 3.7.

Regards,
Benoit

> +			usb2phy@4a0ad080 {
> +				compatible = "ti,omap-usb2";
> +				reg = <0x4a0ad080 0x58>,
> +				      <0x4a002300 0x4>;
> +			};
>  		};
>  	};
>  };
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm/dts: omap: Add omap-usb2 dt data
       [not found]   ` <504EF4FD.2080001-l0cyMroinI0@public.gmane.org>
@ 2012-09-11  8:50     ` ABRAHAM, KISHON VIJAY
  0 siblings, 0 replies; 3+ messages in thread
From: ABRAHAM, KISHON VIJAY @ 2012-09-11  8:50 UTC (permalink / raw)
  To: Benoit Cousson
  Cc: balbi-l0cyMroinI0, arnd-r2nGTMty4D4,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
	grant.likely-s3s/WqlpOiPyB63q8FvJNQ,
	rob.herring-bsGFqQB8/DxBDgjK7y7TUQ, rnayak-l0cyMroinI0,
	tony-4v6yS6AI5VpBDgjK7y7TUQ,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
	linux-doc-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-omap-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA, rob-VoJi6FS/r0vR7s880joybQ,
	linux-lFZ/pmaqli7XmaaqVzeoHQ, ohad-Ix1uc/W3ht7QT0dZR+AlfA,
	linus.walleij-QSEj5FYQhm4dnm+yROfE0A,
	myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ, rusty-8n+1lVoiYb80n/F98K4Iww,
	swarren-DDmLM1+adcrQT0dZR+AlfA

Hi,

On Tue, Sep 11, 2012 at 1:53 PM, Benoit Cousson <b-cousson-l0cyMroinI0@public.gmane.org> wrote:
> Hi Kishon,
>
> On 09/11/2012 08:12 AM, Kishon Vijay Abraham I wrote:
>> Add omap-usb2 data node in omap4 device tree file. Since omap-usb2 is
>> connected to ocp2scp, omap-usb2 dt data is added as a child node
>> of ocp2scp.
>
> Could you add more details about the omap-usb2?
I think information about omap-usb2 driver is added in
 *usb: phy: add a new driver for omap usb2 phy.*.
Do you want the same thing to be added here?
>
> You must update the Documentation binding with that compatible name.
Yes. It's part of *usb: phy: add a new driver for omap usb2 phy.*
> Is it already part of the driver serie? The MUSB driver is referring to
> "ti,musb-omap2430" only.

Will correct the Documentation for MUSB.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-09-11  8:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-11  6:12 [PATCH] arm/dts: omap: Add omap-usb2 dt data Kishon Vijay Abraham I
2012-09-11  8:23 ` Benoit Cousson
     [not found]   ` <504EF4FD.2080001-l0cyMroinI0@public.gmane.org>
2012-09-11  8:50     ` ABRAHAM, KISHON VIJAY

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox