[PATCH 1/1] gpio: omap: dts: Move interrupt-controller from #interrupt-cells description

[PATCH 1/1] gpio: omap: dts: Move interrupt-controller from #interrupt-cells description

[Javier Martinez Canillas]

The binding documentation for the OMAP GPIO controller has the description
for the "#interrupt-cells" property after the "interrupt-controller"
definition. This is confusing so is better to move "interrupt-controller"
after the "#interrupt-cells" description.

Reported-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
 .../devicetree/bindings/gpio/gpio-omap.txt         |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-omap.txt b/Documentation/devicetree/bindings/gpio/gpio-omap.txt
index bff51a2..8b9914c 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-omap.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-omap.txt
@@ -10,7 +10,6 @@ Required properties:
   - second cell is used to specify optional parameters (unused)
 - gpio-controller : Marks the device node as a GPIO controller.
 - #interrupt-cells : Should be 2.
-- interrupt-controller: Mark the device node as an interrupt controller
   The first cell is the GPIO number.
   The second cell is used to specify flags:
     bits[3:0] trigger type and level flags:
@@ -18,6 +17,7 @@ Required properties:
       2 = high-to-low edge triggered.
       4 = active high level-sensitive.
       8 = active low level-sensitive.
+- interrupt-controller: Mark the device node as an interrupt controller.
 
 OMAP specific properties:
 - ti,hwmods: Name of the hwmod associated to the GPIO:
-- 
1.7.7.6

Re: [PATCH 1/1] gpio: omap: dts: Move interrupt-controller from #interrupt-cells description

[Jon Hunter]

On 03/04/2013 12:35 PM, Javier Martinez Canillas wrote:
> The binding documentation for the OMAP GPIO controller has the description
> for the "#interrupt-cells" property after the "interrupt-controller"
> definition. This is confusing so is better to move "interrupt-controller"
> after the "#interrupt-cells" description.
> 
> Reported-by: Stephen Warren <swarren@nvidia.com>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>  .../devicetree/bindings/gpio/gpio-omap.txt         |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-omap.txt b/Documentation/devicetree/bindings/gpio/gpio-omap.txt
> index bff51a2..8b9914c 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-omap.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-omap.txt
> @@ -10,7 +10,6 @@ Required properties:
>    - second cell is used to specify optional parameters (unused)
>  - gpio-controller : Marks the device node as a GPIO controller.
>  - #interrupt-cells : Should be 2.
> -- interrupt-controller: Mark the device node as an interrupt controller
>    The first cell is the GPIO number.
>    The second cell is used to specify flags:
>      bits[3:0] trigger type and level flags:
> @@ -18,6 +17,7 @@ Required properties:
>        2 = high-to-low edge triggered.
>        4 = active high level-sensitive.
>        8 = active low level-sensitive.
> +- interrupt-controller: Mark the device node as an interrupt controller.
>  
>  OMAP specific properties:
>  - ti,hwmods: Name of the hwmod associated to the GPIO:
> 

Thanks. Do you mind putting "interrupt-controller" before
"#interrupt-cells" as I see this is how they have it in
Documenation/devicetree/bindings/interrupt-controller/interrupts.txt?
Otherwise ...

Acked-by: Jon Hunter <jon-hunter@ti.com>

Cheers
Jon

Re: [PATCH 1/1] gpio: omap: dts: Move interrupt-controller from #interrupt-cells description

[Javier Martinez Canillas]

On Mon, Mar 4, 2013 at 8:23 PM, Jon Hunter <jon-hunter@ti.com> wrote:
>
> On 03/04/2013 12:35 PM, Javier Martinez Canillas wrote:
>> The binding documentation for the OMAP GPIO controller has the description
>> for the "#interrupt-cells" property after the "interrupt-controller"
>> definition. This is confusing so is better to move "interrupt-controller"
>> after the "#interrupt-cells" description.
>>
>> Reported-by: Stephen Warren <swarren@nvidia.com>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> ---
>>  .../devicetree/bindings/gpio/gpio-omap.txt         |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-omap.txt b/Documentation/devicetree/bindings/gpio/gpio-omap.txt
>> index bff51a2..8b9914c 100644
>> --- a/Documentation/devicetree/bindings/gpio/gpio-omap.txt
>> +++ b/Documentation/devicetree/bindings/gpio/gpio-omap.txt
>> @@ -10,7 +10,6 @@ Required properties:
>>    - second cell is used to specify optional parameters (unused)
>>  - gpio-controller : Marks the device node as a GPIO controller.
>>  - #interrupt-cells : Should be 2.
>> -- interrupt-controller: Mark the device node as an interrupt controller
>>    The first cell is the GPIO number.
>>    The second cell is used to specify flags:
>>      bits[3:0] trigger type and level flags:
>> @@ -18,6 +17,7 @@ Required properties:
>>        2 = high-to-low edge triggered.
>>        4 = active high level-sensitive.
>>        8 = active low level-sensitive.
>> +- interrupt-controller: Mark the device node as an interrupt controller.
>>
>>  OMAP specific properties:
>>  - ti,hwmods: Name of the hwmod associated to the GPIO:
>>
>
> Thanks. Do you mind putting "interrupt-controller" before
> "#interrupt-cells" as I see this is how they have it in
> Documenation/devicetree/bindings/interrupt-controller/interrupts.txt?
> Otherwise ...
>
> Acked-by: Jon Hunter <jon-hunter@ti.com>
>
> Cheers
> Jon
> --

Hi Jon, thanks for the feedback.

I just looked at Documentation/devicetree/bindings/gpio/gpio.txt and
realized that gpio-controller and #gpio-cells should be flipped as
well.

Will send a v2 with both changes.

Best regards,
Javier