L3 custom error on OMAP4460

L3 custom error on OMAP4460

[Joachim Eastwood]

Hi,

I getting the following error on Linus master right now.

[ 2.166320] WARNING: CPU: 0 PID: 0 at drivers/bus/omap_l3_noc.c:113
l3_interrupt_handler+0xf4/0x154()
[ 2.166320] L3 custom error: MASTER:MPU TARGET:L4 PER2
[ 2.166320] Modules linked in:
[ 2.166351] CPU: 0 PID: 0 Comm: swapper/0 Not tainted
3.14.0-12542-gfb5ce8367c24 #11
[ 2.166381] [<c0014ea8>] (unwind_backtrace) from [<c0011b8c>]
(show_stack+0x10/0x14)
[ 2.166381] [<c0011b8c>] (show_stack) from [<c05a9580>] (dump_stack+0x84/0x94)
[ 2.166412] [<c05a9580>] (dump_stack) from [<c0036b08>]
(warn_slowpath_common+0x70/0x8c)
[ 2.166412] [<c0036b08>] (warn_slowpath_common) from [<c0036b54>]
(warn_slowpath_fmt+0x30/0x40)
[ 2.166412] [<c0036b54>] (warn_slowpath_fmt) from [<c02876f0>]
(l3_interrupt_handler+0xf4/0x154)
[ 2.166442] [<c02876f0>] (l3_interrupt_handler) from [<c0085c7c>]
(handle_irq_event_percpu+0x54/0x1cc)
[ 2.166473] [<c0085c7c>] (handle_irq_event_percpu) from [<c0085e30>]
(handle_irq_event+0x3c/0x5c)
[ 2.166473] [<c0085e30>] (handle_irq_event) from [<c0088e30>]
(handle_fasteoi_irq+0xac/0x1a0)
[ 2.166473] [<c0088e30>] (handle_fasteoi_irq) from [<c008535c>]
(generic_handle_irq+0x2c/0x3c)
[ 2.166503] [<c008535c>] (generic_handle_irq) from [<c000ea80>]
(handle_IRQ+0x40/0x90)
[ 2.166503] [<c000ea80>] (handle_IRQ) from [<c0008594>]
(gic_handle_irq+0x2c/0x5c)
[ 2.166534] [<c0008594>] (gic_handle_irq) from [<c05b0bc4>]
(__irq_svc+0x44/0x58)
[ 2.166534] Exception stack(0xc087bf58 to 0xc087bfa0)
[ 2.166534] bf40: 00000001 00000001
[ 2.166534] bf60: 00000000 c08856f8 c087a000 c087a000 c08d9544
c0882548 c087a000 ee7ffc40
[ 2.166564] bf80: c08824e0 c05b9cec 00000000 c087bfa0 c007a0f0
c000eda8 20000113 ffffffff
[ 2.166564] [<c05b0bc4>] (__irq_svc) from [<c000eda8>] (arch_cpu_idle+0x24/0x30)
[ 2.166595] [<c000eda8>] (arch_cpu_idle) from [<c00718b0>]
(cpu_startup_entry+0x138/0x204)
[ 2.166595] [<c00718b0>] (cpu_startup_entry) from [<c0814b10>]
(start_kernel+0x370/0x37c)
[ 2.166625] [<c0814b10>] (start_kernel) from [<80008074>] (0x80008074)

Not sure what to make of it. Anyone got any idea?

Right before the L3 custom WARN I also get these messages from the
des/aes crypot drivers. Might be unrelated, though.
[ 2.134643] omap-aes 4b501000.aes: _od_fail_runtime_resume: FIXME:
missing hwmod/omap_dev info
[ 2.143737] omap-aes 4b501000.aes: omap_aes_probe: failed to get_sync(-19)
[ 2.151000] omap-aes 4b501000.aes: initialization failed.
[ 2.157196] omap-des 480a5000.des: _od_fail_runtime_resume: FIXME:
missing hwmod/omap_dev info
[ 2.166290] omap-des 480a5000.des: OMAP DES hw accel rev: 0.0

The hardware is a VAR-STK-OM44 dev kit. I got one patch on top of
Linus master which is the DT support patch which I posted a couple of
hours ago.

best regards,
Joachim Eastwood

Re: L3 custom error on OMAP4460

[Santosh Shilimkar]

On Saturday 12 April 2014 05:06 PM, Joachim Eastwood wrote:
> Hi,
> 
> I getting the following error on Linus master right now.
> 
> [ 2.166320] WARNING: CPU: 0 PID: 0 at drivers/bus/omap_l3_noc.c:113
> l3_interrupt_handler+0xf4/0x154()
> [ 2.166320] L3 custom error: MASTER:MPU TARGET:L4 PER2
> [ 2.166320] Modules linked in:
> [ 2.166351] CPU: 0 PID: 0 Comm: swapper/0 Not tainted
> 3.14.0-12542-gfb5ce8367c24 #11
> [ 2.166381] [<c0014ea8>] (unwind_backtrace) from [<c0011b8c>]
> (show_stack+0x10/0x14)
> [ 2.166381] [<c0011b8c>] (show_stack) from [<c05a9580>] (dump_stack+0x84/0x94)
> [ 2.166412] [<c05a9580>] (dump_stack) from [<c0036b08>]
> (warn_slowpath_common+0x70/0x8c)
> [ 2.166412] [<c0036b08>] (warn_slowpath_common) from [<c0036b54>]
> (warn_slowpath_fmt+0x30/0x40)
> [ 2.166412] [<c0036b54>] (warn_slowpath_fmt) from [<c02876f0>]
> (l3_interrupt_handler+0xf4/0x154)
> [ 2.166442] [<c02876f0>] (l3_interrupt_handler) from [<c0085c7c>]
> (handle_irq_event_percpu+0x54/0x1cc)
> [ 2.166473] [<c0085c7c>] (handle_irq_event_percpu) from [<c0085e30>]
> (handle_irq_event+0x3c/0x5c)
> [ 2.166473] [<c0085e30>] (handle_irq_event) from [<c0088e30>]
> (handle_fasteoi_irq+0xac/0x1a0)
> [ 2.166473] [<c0088e30>] (handle_fasteoi_irq) from [<c008535c>]
> (generic_handle_irq+0x2c/0x3c)
> [ 2.166503] [<c008535c>] (generic_handle_irq) from [<c000ea80>]
> (handle_IRQ+0x40/0x90)
> [ 2.166503] [<c000ea80>] (handle_IRQ) from [<c0008594>]
> (gic_handle_irq+0x2c/0x5c)
> [ 2.166534] [<c0008594>] (gic_handle_irq) from [<c05b0bc4>]
> (__irq_svc+0x44/0x58)
> [ 2.166534] Exception stack(0xc087bf58 to 0xc087bfa0)
> [ 2.166534] bf40: 00000001 00000001
> [ 2.166534] bf60: 00000000 c08856f8 c087a000 c087a000 c08d9544
> c0882548 c087a000 ee7ffc40
> [ 2.166564] bf80: c08824e0 c05b9cec 00000000 c087bfa0 c007a0f0
> c000eda8 20000113 ffffffff
> [ 2.166564] [<c05b0bc4>] (__irq_svc) from [<c000eda8>] (arch_cpu_idle+0x24/0x30)
> [ 2.166595] [<c000eda8>] (arch_cpu_idle) from [<c00718b0>]
> (cpu_startup_entry+0x138/0x204)
> [ 2.166595] [<c00718b0>] (cpu_startup_entry) from [<c0814b10>]
> (start_kernel+0x370/0x37c)
> [ 2.166625] [<c0814b10>] (start_kernel) from [<80008074>] (0x80008074)
> 
> Not sure what to make of it. Anyone got any idea?
> 
> Right before the L3 custom WARN I also get these messages from the
> des/aes crypot drivers. Might be unrelated, though.
> [ 2.134643] omap-aes 4b501000.aes: _od_fail_runtime_resume: FIXME:
> missing hwmod/omap_dev info
> [ 2.143737] omap-aes 4b501000.aes: omap_aes_probe: failed to get_sync(-19)
> [ 2.151000] omap-aes 4b501000.aes: initialization failed.
> [ 2.157196] omap-des 480a5000.des: _od_fail_runtime_resume: FIXME:
> missing hwmod/omap_dev info
> [ 2.166290] omap-des 480a5000.des: OMAP DES hw accel rev: 0.0
> 
> The hardware is a VAR-STK-OM44 dev kit. I got one patch on top of
> Linus master which is the DT support patch which I posted a couple of
> hours ago.
> 
Have you tried removing AES from the build ? Probably worth a
try.

Regards,
Santosh

Re: L3 custom error on OMAP4460

[Joachim Eastwood]

On 14 April 2014 15:38, Santosh Shilimkar <santosh.shilimkar@ti.com> wrote:
> On Saturday 12 April 2014 05:06 PM, Joachim Eastwood wrote:
>> Hi,
>>
>> I getting the following error on Linus master right now.
>>
>> [ 2.166320] WARNING: CPU: 0 PID: 0 at drivers/bus/omap_l3_noc.c:113
>> l3_interrupt_handler+0xf4/0x154()
>> [ 2.166320] L3 custom error: MASTER:MPU TARGET:L4 PER2
>> [ 2.166320] Modules linked in:
>> [ 2.166351] CPU: 0 PID: 0 Comm: swapper/0 Not tainted
>> 3.14.0-12542-gfb5ce8367c24 #11
>> [ 2.166381] [<c0014ea8>] (unwind_backtrace) from [<c0011b8c>]
>> (show_stack+0x10/0x14)
>> [ 2.166381] [<c0011b8c>] (show_stack) from [<c05a9580>] (dump_stack+0x84/0x94)
>> [ 2.166412] [<c05a9580>] (dump_stack) from [<c0036b08>]
>> (warn_slowpath_common+0x70/0x8c)
>> [ 2.166412] [<c0036b08>] (warn_slowpath_common) from [<c0036b54>]
>> (warn_slowpath_fmt+0x30/0x40)
>> [ 2.166412] [<c0036b54>] (warn_slowpath_fmt) from [<c02876f0>]
>> (l3_interrupt_handler+0xf4/0x154)
>> [ 2.166442] [<c02876f0>] (l3_interrupt_handler) from [<c0085c7c>]
>> (handle_irq_event_percpu+0x54/0x1cc)
>> [ 2.166473] [<c0085c7c>] (handle_irq_event_percpu) from [<c0085e30>]
>> (handle_irq_event+0x3c/0x5c)
>> [ 2.166473] [<c0085e30>] (handle_irq_event) from [<c0088e30>]
>> (handle_fasteoi_irq+0xac/0x1a0)
>> [ 2.166473] [<c0088e30>] (handle_fasteoi_irq) from [<c008535c>]
>> (generic_handle_irq+0x2c/0x3c)
>> [ 2.166503] [<c008535c>] (generic_handle_irq) from [<c000ea80>]
>> (handle_IRQ+0x40/0x90)
>> [ 2.166503] [<c000ea80>] (handle_IRQ) from [<c0008594>]
>> (gic_handle_irq+0x2c/0x5c)
>> [ 2.166534] [<c0008594>] (gic_handle_irq) from [<c05b0bc4>]
>> (__irq_svc+0x44/0x58)
>> [ 2.166534] Exception stack(0xc087bf58 to 0xc087bfa0)
>> [ 2.166534] bf40: 00000001 00000001
>> [ 2.166534] bf60: 00000000 c08856f8 c087a000 c087a000 c08d9544
>> c0882548 c087a000 ee7ffc40
>> [ 2.166564] bf80: c08824e0 c05b9cec 00000000 c087bfa0 c007a0f0
>> c000eda8 20000113 ffffffff
>> [ 2.166564] [<c05b0bc4>] (__irq_svc) from [<c000eda8>] (arch_cpu_idle+0x24/0x30)
>> [ 2.166595] [<c000eda8>] (arch_cpu_idle) from [<c00718b0>]
>> (cpu_startup_entry+0x138/0x204)
>> [ 2.166595] [<c00718b0>] (cpu_startup_entry) from [<c0814b10>]
>> (start_kernel+0x370/0x37c)
>> [ 2.166625] [<c0814b10>] (start_kernel) from [<80008074>] (0x80008074)
>>
>> Not sure what to make of it. Anyone got any idea?
>>
>> Right before the L3 custom WARN I also get these messages from the
>> des/aes crypot drivers. Might be unrelated, though.
>> [ 2.134643] omap-aes 4b501000.aes: _od_fail_runtime_resume: FIXME:
>> missing hwmod/omap_dev info
>> [ 2.143737] omap-aes 4b501000.aes: omap_aes_probe: failed to get_sync(-19)
>> [ 2.151000] omap-aes 4b501000.aes: initialization failed.
>> [ 2.157196] omap-des 480a5000.des: _od_fail_runtime_resume: FIXME:
>> missing hwmod/omap_dev info
>> [ 2.166290] omap-des 480a5000.des: OMAP DES hw accel rev: 0.0
>>
>> The hardware is a VAR-STK-OM44 dev kit. I got one patch on top of
>> Linus master which is the DT support patch which I posted a couple of
>> hours ago.
>>
> Have you tried removing AES from the build ? Probably worth a
> try.

Removing the aes driver makes the warning from omap_l3_noc disappear.

I also tried tried the omap_l3_noc patches from Nishanth Menon that
was just posted but it had the same error when the aes driver was
built-in.

Would it be possible for someone to add hwmod data for the aes driver
to the kernel so that the aes could actually work?

regards,
Joachim Eastwood

> Regards,
> Santosh
>

Re: L3 custom error on OMAP4460 (AES/DES)

[Nishanth Menon]

On 04/14/2014 02:15 PM, Joachim Eastwood wrote:
> On 14 April 2014 15:38, Santosh Shilimkar <santosh.shilimkar@ti.com> wrote:
>> On Saturday 12 April 2014 05:06 PM, Joachim Eastwood wrote:
>>> Hi,
>>>
>>> I getting the following error on Linus master right now.
>>>
>>> [ 2.166320] WARNING: CPU: 0 PID: 0 at drivers/bus/omap_l3_noc.c:113
>>> l3_interrupt_handler+0xf4/0x154()
>>> [ 2.166320] L3 custom error: MASTER:MPU TARGET:L4 PER2
>>> [ 2.166320] Modules linked in:

[...]
>>> The hardware is a VAR-STK-OM44 dev kit. I got one patch on top of
>>> Linus master which is the DT support patch which I posted a couple of
>>> hours ago.
>>>
>> Have you tried removing AES from the build ? Probably worth a
>> try.
> 
> Removing the aes driver makes the warning from omap_l3_noc disappear.
> 
> I also tried tried the omap_l3_noc patches from Nishanth Menon that
> was just posted but it had the same error when the aes driver was
> built-in.
Yeah - it better :).. Good to know that driver continues to report bad
accesses by drivers to targets that are not active yet. will be great
if you could provide a "Tested-by" tag on my series :).

Btw, I just finished testing on PandaBoard ES and SDP4430 and I dont
see the error that you see on var som. I wonder why?

pandaboard-es:  Boot PASS: http://slexy.org/raw/s21Hsq97mt
sdp4430:  Boot PASS: http://slexy.org/raw/s2ZQJUqjrP

> 
> Would it be possible for someone to add hwmod data for the aes driver
> to the kernel so that the aes could actually work?

Joel, are you planning on posting OMAP4 hwmod data for AES/DES?

-- 
Regards,
Nishanth Menon

Re: L3 custom error on OMAP4460 (AES/DES)

[Nishanth Menon]

On 22:36-20140414, Joachim Eastwood wrote:
> On 14 April 2014 21:19, Nishanth Menon <nm@ti.com> wrote:
> > On 04/14/2014 02:15 PM, Joachim Eastwood wrote:
> >> On 14 April 2014 15:38, Santosh Shilimkar <santosh.shilimkar@ti.com> wrote:
> >>> On Saturday 12 April 2014 05:06 PM, Joachim Eastwood wrote:
> >>>> Hi,
> >>>>
> >>>> I getting the following error on Linus master right now.
> >>>>
> >>>> [ 2.166320] WARNING: CPU: 0 PID: 0 at drivers/bus/omap_l3_noc.c:113
> >>>> l3_interrupt_handler+0xf4/0x154()
> >>>> [ 2.166320] L3 custom error: MASTER:MPU TARGET:L4 PER2
> >>>> [ 2.166320] Modules linked in:
> >
> > [...]
> >>>> The hardware is a VAR-STK-OM44 dev kit. I got one patch on top of
> >>>> Linus master which is the DT support patch which I posted a couple of
> >>>> hours ago.
> >>>>
> >>> Have you tried removing AES from the build ? Probably worth a
> >>> try.
> >>
> >> Removing the aes driver makes the warning from omap_l3_noc disappear.
> >>
> >> I also tried tried the omap_l3_noc patches from Nishanth Menon that
> >> was just posted but it had the same error when the aes driver was
> >> built-in.
> > Yeah - it better :).. Good to know that driver continues to report bad
> > accesses by drivers to targets that are not active yet. will be great
> > if you could provide a "Tested-by" tag on my series :).
> 
> Sure. The patch set booted fine on my VAR-STK-OM44 (OMAP4460).
> Tested-by: Joachim Eastwood <manabian@gmail.com>
> 
> > Btw, I just finished testing on PandaBoard ES and SDP4430 and I dont
> > see the error that you see on var som. I wonder why?
> >
> > pandaboard-es:  Boot PASS: http://slexy.org/raw/s21Hsq97mt
> > sdp4430:  Boot PASS: http://slexy.org/raw/s2ZQJUqjrP
> 
> hmm. Maybe it's a combination of different config options.
> 
> I have attached the complete dmesg and config from my board. Maybe you
> could try the config out.
> 
> I noticed from your PandaBoard ES log that you only get this line:
> [ 0.555480] platform 4b501000.aes: Cannot lookup hwmod 'aes'
> 
> While on my board I first get the "Cannot lookup" message and then
> some other messages:
> [ 0.512847] platform 4b501000.aes: Cannot lookup hwmod 'aes'
> [ 2.341125] omap-aes 4b501000.aes: _od_fail_runtime_resume: FIXME:
> missing hwmod/omap_dev info
> [ 2.350219] omap-aes 4b501000.aes: omap_aes_probe: failed to get_sync(-19)
> [ 2.357482] omap-aes 4b501000.aes: initialization failed.

Yep, I was able to reproduce the error:
pandaboard-es-before: http://slexy.org/raw/s21rGPFnKl
pandaboard-es-after:  http://slexy.org/raw/s2A4UFQVna

Key was "omap-des 480a5000.des: OMAP DES hw accel rev: 0.0" in the log.

Please try the following patch:
--8<--
>From a5c1b5645eef74c88ea22f6ec99054ec0e9a2502 Mon Sep 17 00:00:00 2001
From: Nishanth Menon <nm@ti.com>
Date: Tue, 15 Apr 2014 08:55:44 -0500
Subject: [PATCH] crypto: omap-des - handle error of pm_runtime_get_sync

pm_runtime_get_sync may not always succeed depending on SoC involved. So
handle the error appropriately.

Signed-off-by: Nishanth Menon <nm@ti.com>
---

based on v3.15-rc1

 drivers/crypto/omap-des.c |   18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
index ec5f131..c2d362f 100644
--- a/drivers/crypto/omap-des.c
+++ b/drivers/crypto/omap-des.c
@@ -223,12 +223,18 @@ static void omap_des_write_n(struct omap_des_dev *dd, u32 offset,
 
 static int omap_des_hw_init(struct omap_des_dev *dd)
 {
+	int err;
+
 	/*
 	 * clocks are enabled when request starts and disabled when finished.
 	 * It may be long delays between requests.
 	 * Device might go to off mode to save power.
 	 */
-	pm_runtime_get_sync(dd->dev);
+	err = pm_runtime_get_sync(dd->dev);
+	if (err < 0) {
+		dev_err(dd->dev, "failed to get_sync(%d)\n", err);
+		return err;
+	}
 
 	if (!(dd->flags & FLAGS_INIT)) {
 		dd->flags |= FLAGS_INIT;
@@ -1083,7 +1089,11 @@ static int omap_des_probe(struct platform_device *pdev)
 	dd->phys_base = res->start;
 
 	pm_runtime_enable(dev);
-	pm_runtime_get_sync(dev);
+	err = pm_runtime_get_sync(dev);
+	if (err < 0) {
+		dev_err(dd->dev, "failed to get_sync(%d)\n", err);
+		goto err_get;
+	}
 
 	omap_des_dma_stop(dd);
 
@@ -1148,6 +1158,7 @@ err_algs:
 err_irq:
 	tasklet_kill(&dd->done_task);
 	tasklet_kill(&dd->queue_task);
+err_get:
 	pm_runtime_disable(dev);
 err_res:
 	dd = NULL;
@@ -1191,8 +1202,7 @@ static int omap_des_suspend(struct device *dev)
 
 static int omap_des_resume(struct device *dev)
 {
-	pm_runtime_get_sync(dev);
-	return 0;
+	return pm_runtime_get_sync(dev);
 }
 #endif
 
-- 
1.7.9.5



-- 
Regards,
Nishanth Menon

Re: L3 custom error on OMAP4460 (AES/DES)

[Joachim Eastwood]

On 15 April 2014 16:01, Nishanth Menon <nm@ti.com> wrote:
> On 22:36-20140414, Joachim Eastwood wrote:
>> On 14 April 2014 21:19, Nishanth Menon <nm@ti.com> wrote:
>> > On 04/14/2014 02:15 PM, Joachim Eastwood wrote:
>> >> On 14 April 2014 15:38, Santosh Shilimkar <santosh.shilimkar@ti.com> wrote:
>> >>> On Saturday 12 April 2014 05:06 PM, Joachim Eastwood wrote:
>> >>>> Hi,
>> >>>>
>> >>>> I getting the following error on Linus master right now.
>> >>>>
>> >>>> [ 2.166320] WARNING: CPU: 0 PID: 0 at drivers/bus/omap_l3_noc.c:113
>> >>>> l3_interrupt_handler+0xf4/0x154()
>> >>>> [ 2.166320] L3 custom error: MASTER:MPU TARGET:L4 PER2
>> >>>> [ 2.166320] Modules linked in:
>> >
>> > [...]
>> >>>> The hardware is a VAR-STK-OM44 dev kit. I got one patch on top of
>> >>>> Linus master which is the DT support patch which I posted a couple of
>> >>>> hours ago.
>> >>>>
>> >>> Have you tried removing AES from the build ? Probably worth a
>> >>> try.
>> >>
>> >> Removing the aes driver makes the warning from omap_l3_noc disappear.
>> >>
>> >> I also tried tried the omap_l3_noc patches from Nishanth Menon that
>> >> was just posted but it had the same error when the aes driver was
>> >> built-in.
>> > Yeah - it better :).. Good to know that driver continues to report bad
>> > accesses by drivers to targets that are not active yet. will be great
>> > if you could provide a "Tested-by" tag on my series :).
>>
>> Sure. The patch set booted fine on my VAR-STK-OM44 (OMAP4460).
>> Tested-by: Joachim Eastwood <manabian@gmail.com>
>>
>> > Btw, I just finished testing on PandaBoard ES and SDP4430 and I dont
>> > see the error that you see on var som. I wonder why?
>> >
>> > pandaboard-es:  Boot PASS: http://slexy.org/raw/s21Hsq97mt
>> > sdp4430:  Boot PASS: http://slexy.org/raw/s2ZQJUqjrP
>>
>> hmm. Maybe it's a combination of different config options.
>>
>> I have attached the complete dmesg and config from my board. Maybe you
>> could try the config out.
>>
>> I noticed from your PandaBoard ES log that you only get this line:
>> [ 0.555480] platform 4b501000.aes: Cannot lookup hwmod 'aes'
>>
>> While on my board I first get the "Cannot lookup" message and then
>> some other messages:
>> [ 0.512847] platform 4b501000.aes: Cannot lookup hwmod 'aes'
>> [ 2.341125] omap-aes 4b501000.aes: _od_fail_runtime_resume: FIXME:
>> missing hwmod/omap_dev info
>> [ 2.350219] omap-aes 4b501000.aes: omap_aes_probe: failed to get_sync(-19)
>> [ 2.357482] omap-aes 4b501000.aes: initialization failed.
>
> Yep, I was able to reproduce the error:
> pandaboard-es-before: http://slexy.org/raw/s21rGPFnKl
> pandaboard-es-after:  http://slexy.org/raw/s2A4UFQVna
>
> Key was "omap-des 480a5000.des: OMAP DES hw accel rev: 0.0" in the log.
>
> Please try the following patch:
> --8<--
> From a5c1b5645eef74c88ea22f6ec99054ec0e9a2502 Mon Sep 17 00:00:00 2001
> From: Nishanth Menon <nm@ti.com>
> Date: Tue, 15 Apr 2014 08:55:44 -0500
> Subject: [PATCH] crypto: omap-des - handle error of pm_runtime_get_sync
>
> pm_runtime_get_sync may not always succeed depending on SoC involved. So
> handle the error appropriately.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>
> based on v3.15-rc1
>
>  drivers/crypto/omap-des.c |   18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)

After this patch the warnings from omap_l3_noc disappear. Thanks Nishanth.
Tested-by: Joachim Eastwood <manabian@gmail.com>

I have some other issues on OMAP4460, unrelated to this. I'll send out
an email to the list later.

best regards,
Joachim Eastwood

Re: L3 custom error on OMAP4460 (AES/DES)

[Joel Fernandes]

Nishanth,

On 04/14/2014 02:19 PM, Nishanth Menon wrote:
> On 04/14/2014 02:15 PM, Joachim Eastwood wrote:
>> On 14 April 2014 15:38, Santosh Shilimkar <santosh.shilimkar@ti.com> wrote:
>>> On Saturday 12 April 2014 05:06 PM, Joachim Eastwood wrote:
>>>> Hi,
>>>>
>>>> I getting the following error on Linus master right now.
>>>>
>>>> [ 2.166320] WARNING: CPU: 0 PID: 0 at drivers/bus/omap_l3_noc.c:113
>>>> l3_interrupt_handler+0xf4/0x154()
>>>> [ 2.166320] L3 custom error: MASTER:MPU TARGET:L4 PER2
>>>> [ 2.166320] Modules linked in:
> 
> [...]
>>>> The hardware is a VAR-STK-OM44 dev kit. I got one patch on top of
>>>> Linus master which is the DT support patch which I posted a couple of
>>>> hours ago.
>>>>
>>> Have you tried removing AES from the build ? Probably worth a
>>> try.
>>
>> Removing the aes driver makes the warning from omap_l3_noc disappear.
>>
>> I also tried tried the omap_l3_noc patches from Nishanth Menon that
>> was just posted but it had the same error when the aes driver was
>> built-in.
> Yeah - it better :).. Good to know that driver continues to report bad
> accesses by drivers to targets that are not active yet. will be great
> if you could provide a "Tested-by" tag on my series :).
> 
> Btw, I just finished testing on PandaBoard ES and SDP4430 and I dont
> see the error that you see on var som. I wonder why?
> 
> pandaboard-es:  Boot PASS: http://slexy.org/raw/s21Hsq97mt
> sdp4430:  Boot PASS: http://slexy.org/raw/s2ZQJUqjrP
> 
>>
>> Would it be possible for someone to add hwmod data for the aes driver
>> to the kernel so that the aes could actually work?
> 
> Joel, are you planning on posting OMAP4 hwmod data for AES/DES?
> 

I was out sick yesterday, sorry for the late reply.

Yes, sure. I believe it wasn't posted due to another kernel problem
which I don't remember. I'll post it this week after some more testing
and rebasing.

Thanks for patching the pm_runtime return to handle this.

Regards,
-Joel

Re: L3 custom error on OMAP4460 (AES/DES)

[Nishanth Menon]

On 04/15/2014 12:15 PM, Joel Fernandes wrote:
[...]
>> Joel, are you planning on posting OMAP4 hwmod data for AES/DES?
>>
> 
> I was out sick yesterday, sorry for the late reply.
> 
> Yes, sure. I believe it wasn't posted due to another kernel problem
> which I don't remember. I'll post it this week after some more testing
> and rebasing.
> 
> Thanks for patching the pm_runtime return to handle this.

please do, thanks for following up.


-- 
Regards,
Nishanth Menon