ti,codec property in sound/soc/omap/omap-twl4030.c not used

ti,codec property in sound/soc/omap/omap-twl4030.c not used

[Belisko Marek]

Hi,

I'm looking at sources for omap-twl4030.c driver which is used by many
boards. In DT bindings documentation is property ti,codec described as
mandatory but it's never parsed in driver code. I did small experiment
in gta04 board and remove ti,codec from devicetree and sound was
working. I think it can be removed from documentation and also from
various device trees. Is my assumption correct? Thanks.

BR,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com

Re: ti,codec property in sound/soc/omap/omap-twl4030.c not used

[Peter Ujfalusi]

On 03/12/2015 12:12 AM, Belisko Marek wrote:
> Hi,
> 
> I'm looking at sources for omap-twl4030.c driver which is used by many
> boards. In DT bindings documentation is property ti,codec described as
> mandatory but it's never parsed in driver code. I did small experiment
> in gta04 board and remove ti,codec from devicetree and sound was
> working. I think it can be removed from documentation and also from
> various device trees. Is my assumption correct? Thanks.

Correct. The ti,twl4030-audio is for the MFD driver and the device for the
ASoC codec is created in there w/o actual DT compatible string. The audio part
of the twl4030 is responsible for the audio and the vibra functionality.

Are you going to send the patches?

Thanks,
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: ti,codec property in sound/soc/omap/omap-twl4030.c not used

[Belisko Marek]

Hi,

On Thu, Mar 12, 2015 at 10:19 AM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> On 03/12/2015 12:12 AM, Belisko Marek wrote:
>> Hi,
>>
>> I'm looking at sources for omap-twl4030.c driver which is used by many
>> boards. In DT bindings documentation is property ti,codec described as
>> mandatory but it's never parsed in driver code. I did small experiment
>> in gta04 board and remove ti,codec from devicetree and sound was
>> working. I think it can be removed from documentation and also from
>> various device trees. Is my assumption correct? Thanks.
>
> Correct. The ti,twl4030-audio is for the MFD driver and the device for the
> ASoC codec is created in there w/o actual DT compatible string. The audio part
> of the twl4030 is responsible for the audio and the vibra functionality.
Thanks for reply.
>
> Are you going to send the patches?
Yes will do.
>
> Thanks,
> Péter

BR,

marek



-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html