public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Dave Gerlach <d-gerlach@ti.com>
Cc: Nishanth Menon <nm@ti.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Lukasz Majewski <lukma@denx.de>, Rob Herring <robh+dt@kernel.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 2/4] Documentation: dt: add bindings for ti-cpufreq
Date: Thu, 09 Feb 2017 01:02:53 +0100	[thread overview]
Message-ID: <5995162.mH49F4H7nS@aspire.rjw.lan> (raw)
In-Reply-To: <2aba1159-9a48-329f-2a54-8079b32b06e2@ti.com>

On Wednesday, February 08, 2017 08:45:55 AM Dave Gerlach wrote:
> On 02/08/2017 08:44 AM, Rob Herring wrote:
> > On Fri, Feb 3, 2017 at 11:29 AM, Dave Gerlach <d-gerlach@ti.com> wrote:
> >> Add the device tree bindings document for the TI CPUFreq/OPP driver
> >> on AM33xx, AM43xx, DRA7xx, and AM57xx SoCs. The operating-points-v2
> >> binding allows us to provide an opp-supported-hw property for each OPP
> >> to define when it is available. This driver is responsible for reading
> >> and parsing registers to determine which OPPs can be selectively enabled
> >> based on the specific SoC in use by matching against the opp-supported-hw
> >> data.
> >>
> >> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> >> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> >> ---
> >
> > [...]
> >
> >> +/*
> >> + * cpu0 has different OPPs depending on SoC revision and some on revisions
> >> + * 0x2 and 0x4 have eFuse bits that indicate if they are available or not
> >> + */
> >> +cpu0_opp_table: opp_table {
> >
> > One step closer, but as I showed last time, use a '-', not '_'.
> 
> I apologize I thought the comment was only about the 0, completely missed the 
> underscore, you are correct, thanks.

Please send an update of this patch, then.

Thanks,
Rafael

  reply	other threads:[~2017-02-09  0:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-03 17:29 [PATCH v5 0/4] cpufreq: Introduce TI CPUFreq/OPP Driver Dave Gerlach
     [not found] ` <20170203172929.23940-1-d-gerlach-l0cyMroinI0@public.gmane.org>
2017-02-03 17:29   ` [PATCH v5 1/4] PM / OPP: Expose _of_get_opp_desc_node as dev_pm_opp API Dave Gerlach
2017-02-03 17:29   ` [PATCH v5 3/4] cpufreq: ti: Add cpufreq driver to determine available OPPs at runtime Dave Gerlach
2017-02-03 17:29 ` [PATCH v5 2/4] Documentation: dt: add bindings for ti-cpufreq Dave Gerlach
2017-02-08 14:44   ` Rob Herring
2017-02-08 14:45     ` Dave Gerlach
2017-02-09  0:02       ` Rafael J. Wysocki [this message]
2017-02-09 15:36         ` Dave Gerlach
2017-02-09 15:35   ` [PATCH v6 " Dave Gerlach
2017-02-09 16:01     ` Rob Herring
2017-02-09 22:03     ` Rafael J. Wysocki
2017-02-10  3:13       ` Viresh Kumar
2017-02-10 12:28         ` Rafael J. Wysocki
     [not found]           ` <3046998.7dExGlRDb3-yvgW3jdyMHm1GS7QM15AGw@public.gmane.org>
2017-02-10 20:55             ` Dave Gerlach
2017-02-03 17:29 ` [PATCH v5 4/4] cpufreq: dt: Don't use generic platdev driver for ti-cpufreq platforms Dave Gerlach
2017-02-03 23:23 ` [PATCH v5 0/4] cpufreq: Introduce TI CPUFreq/OPP Driver Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5995162.mH49F4H7nS@aspire.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=d-gerlach@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukma@denx.de \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox