From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Frank Li <Frank.li@nxp.com>
Cc: <s-vadapalli@ti.com>, <bhelgaas@google.com>,
<conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
<krzk+dt@kernel.org>, <kw@linux.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-pci@vger.kernel.org>, <lpieralisi@kernel.org>,
<manivannan.sadhasivam@linaro.org>, <robh@kernel.org>,
<tony@atomide.com>, <vigneshr@ti.com>
Subject: Re: [PATCH v2 1/1] Revert "ARM: dts: Update pcie ranges for dra7"
Date: Fri, 23 May 2025 11:02:38 +0530 [thread overview]
Message-ID: <5a8a4f18-d5cc-4fd1-aeda-2e739502e0eb@ti.com> (raw)
In-Reply-To: <aC97HguxSt56BkHa@lizhi-Precision-Tower-5810>
On Thu, May 22, 2025 at 03:29:34PM -0400, Frank Li wrote:
Hello Frank,
> On Fri, Apr 11, 2025 at 11:34:54AM -0400, Frank Li wrote:
> > This reverts commit c761028ef5e27f477fe14d2b134164c584fc21ee.
> >
> > The commit being reverted updated the "ranges" property for the sake of
> > readability. However, this change is no longer appropriate due to the
> > following reasons:
> >
> > - On many SoCs, the PCIe parent bus translates CPU addresses to different
> > values before passing them to the PCIe controller.
> > - The reverted commit introduced a fake address translation, which violates
> > the fundamental DTS principle: the device tree should reflect actual
> > hardware behavior.
> >
> > Reverting this change prepares for the cleanup of the driver's
> > cpu_addr_fixup() hook.
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
>
> s-vadapalli:
>
> Any update about this patch? it prepare to remove cpu_addr_fixes()!
This patch looks good to me, but I was hoping that Tony Lindgren, who is
the author of the commit being reverted, would provide feedback as well.
Regards,
Siddharth.
next prev parent reply other threads:[~2025-05-23 5:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 15:34 [PATCH v2 1/1] Revert "ARM: dts: Update pcie ranges for dra7" Frank Li
2025-05-22 19:29 ` Frank Li
2025-05-23 5:32 ` Siddharth Vadapalli [this message]
2025-05-23 18:53 ` Frank Li
2025-05-29 17:11 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a8a4f18-d5cc-4fd1-aeda-2e739502e0eb@ti.com \
--to=s-vadapalli@ti.com \
--cc=Frank.li@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox