From: Kevin Hilman <khilman@linaro.org>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org, tony@atomide.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 9/9] ARM: OMAP4: PM: Now remove L4 per clockdomain static depedency with MPU
Date: Wed, 27 Mar 2013 11:46:50 -0700 [thread overview]
Message-ID: <87zjxo65ph.fsf@linaro.org> (raw)
In-Reply-To: <1361373527-21695-10-git-send-email-santosh.shilimkar@ti.com> (Santosh Shilimkar's message of "Wed, 20 Feb 2013 20:48:47 +0530")
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> UART driver slave idle issue has been taken care by driver using hwmod
> framework.
>
> So we can now ger rid off the L4 per clockdomain static dependency with
> MPU which was used to wrok around UART wakeup and console sluggishnesh issue
> on OMAP4 SOCs.
>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Nice.
Acked-by: Kevin Hilman <khilman@linaro.org>
> ---
> arch/arm/mach-omap2/pm44xx.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c
> index 1fd9662..1d03110 100644
> --- a/arch/arm/mach-omap2/pm44xx.c
> +++ b/arch/arm/mach-omap2/pm44xx.c
> @@ -134,7 +134,7 @@ int __init omap4_pm_init(void)
> {
> int ret;
> struct clockdomain *emif_clkdm, *mpuss_clkdm, *l3_1_clkdm;
> - struct clockdomain *ducati_clkdm, *l3_2_clkdm, *l4_per_clkdm;
> + struct clockdomain *ducati_clkdm, *l3_2_clkdm;
>
> if (omap_rev() == OMAP4430_REV_ES1_0) {
> WARN(1, "Power Management not supported on OMAP4430 ES1.0\n");
> @@ -159,16 +159,14 @@ int __init omap4_pm_init(void)
> emif_clkdm = clkdm_lookup("l3_emif_clkdm");
> l3_1_clkdm = clkdm_lookup("l3_1_clkdm");
> l3_2_clkdm = clkdm_lookup("l3_2_clkdm");
> - l4_per_clkdm = clkdm_lookup("l4_per_clkdm");
> ducati_clkdm = clkdm_lookup("ducati_clkdm");
> if ((!mpuss_clkdm) || (!emif_clkdm) || (!l3_1_clkdm) ||
> - (!l3_2_clkdm) || (!ducati_clkdm) || (!l4_per_clkdm))
> + (!l3_2_clkdm) || (!ducati_clkdm))
> goto err2;
>
> ret = clkdm_add_wkdep(mpuss_clkdm, emif_clkdm);
> ret |= clkdm_add_wkdep(mpuss_clkdm, l3_1_clkdm);
> ret |= clkdm_add_wkdep(mpuss_clkdm, l3_2_clkdm);
> - ret |= clkdm_add_wkdep(mpuss_clkdm, l4_per_clkdm);
> ret |= clkdm_add_wkdep(ducati_clkdm, l3_1_clkdm);
> ret |= clkdm_add_wkdep(ducati_clkdm, l3_2_clkdm);
> if (ret) {
prev parent reply other threads:[~2013-03-27 18:46 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 15:18 [PATCH 0/9] ARM: OMAP: Static deps, fiq, omap-smp cleanup Santosh Shilimkar
2013-02-20 15:18 ` [PATCH 1/9] ARM: OMAP4+: Use common scratchpad SAR RAM offsets for all architectures Santosh Shilimkar
2013-03-27 18:41 ` Kevin Hilman
2013-03-27 20:49 ` Santosh Shilimkar
2013-03-27 20:49 ` Tony Lindgren
2013-03-27 20:52 ` Santosh Shilimkar
2013-03-28 7:32 ` Santosh Shilimkar
2013-02-20 15:18 ` [PATCH 2/9] ARM: OMAP1: PM: Remove bogus fiq_[enable/disable] tuple Santosh Shilimkar
2013-02-20 16:09 ` Tony Lindgren
2013-02-20 16:14 ` Santosh Shilimkar
2013-02-20 15:18 ` [PATCH 3/9] ARM: OMAP2+: " Santosh Shilimkar
2013-03-27 18:36 ` Kevin Hilman
2013-03-27 19:02 ` Santosh Shilimkar
2013-03-28 7:37 ` Santosh Shilimkar
2013-02-20 15:18 ` [PATCH 4/9] ARM: OMAP4+: Remove the un-necessary cache flush from hotplug code Santosh Shilimkar
2013-03-27 18:43 ` Kevin Hilman
2013-03-27 20:47 ` Santosh Shilimkar
2013-03-28 7:29 ` Santosh Shilimkar
2013-02-20 15:18 ` [PATCH 5/9] ARM: OMAP4+: Remove un-necessary cacheflush in secondary CPU boot path Santosh Shilimkar
2013-02-20 15:18 ` [PATCH 6/9] ARM: OMAP4+: Remove out of placed smp_wmb() in secondary wakeup code Santosh Shilimkar
2013-02-21 12:55 ` Sergei Shtylyov
2013-02-21 12:59 ` Santosh Shilimkar
2013-02-20 15:18 ` [PATCH 7/9] ARM: OMAP4+: Move the CPU wakeup prepare code under smp_prepare_cpus() Santosh Shilimkar
2013-03-27 18:45 ` Kevin Hilman
2013-03-27 19:04 ` Santosh Shilimkar
2013-03-27 19:54 ` Kevin Hilman
2013-03-27 20:50 ` Santosh Shilimkar
2013-03-28 7:35 ` Santosh Shilimkar
2013-03-28 9:46 ` Russell King - ARM Linux
2013-03-28 9:58 ` Santosh Shilimkar
2013-03-28 12:04 ` Russell King - ARM Linux
2013-03-28 12:09 ` Santosh Shilimkar
2013-02-20 15:18 ` [PATCH 8/9] ARM: OMAP4: PM: Remove L4 wakeup depedency with MPU since errata fix exist now Santosh Shilimkar
2013-03-27 18:46 ` Kevin Hilman
2013-03-27 19:01 ` Peter Korsgaard
2013-02-20 15:18 ` [PATCH 9/9] ARM: OMAP4: PM: Now remove L4 per clockdomain static depedency with MPU Santosh Shilimkar
2013-03-27 18:46 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjxo65ph.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox