From: Kevin Hilman <khilman@ti.com>
To: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Cc: linux-omap@vger.kernel.org, tony@atomide.com,
santosh.shilimkar@ti.com, rnayak@ti.com, b-cousson@ti.com,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: OMAP2+: remove redundant sysconfig context restore
Date: Wed, 11 Apr 2012 17:34:55 -0700 [thread overview]
Message-ID: <87zkahlrdc.fsf@ti.com> (raw)
In-Reply-To: <1334133256-20475-1-git-send-email-tarun.kanti@ti.com> (Tarun Kanti DebBarma's message of "Wed, 11 Apr 2012 14:04:16 +0530")
Tarun Kanti DebBarma <tarun.kanti@ti.com> writes:
> Since hwmod framework now manages sysconfig context save/restore
> there is no more need to touch this register in driver. Hence,
> remove restore of sysconfig register in omap_timer_restore_context.
> This was causing incorrect context restore of sysconfig register.
>
> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>
While cleaning this up, you can remove it from 'struct timer_regs' in
<plat/dmtimer.h> as well, since the code you remove is the only user.
Kevin
> ---
> arch/arm/plat-omap/dmtimer.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
> index 652139c..15e7882 100644
> --- a/arch/arm/plat-omap/dmtimer.c
> +++ b/arch/arm/plat-omap/dmtimer.c
> @@ -82,8 +82,6 @@ static void omap_dm_timer_write_reg(struct omap_dm_timer *timer, u32 reg,
>
> static void omap_timer_restore_context(struct omap_dm_timer *timer)
> {
> - __raw_writel(timer->context.tiocp_cfg,
> - timer->io_base + OMAP_TIMER_OCP_CFG_OFFSET);
> if (timer->revision == 1)
> __raw_writel(timer->context.tistat, timer->sys_stat);
next prev parent reply other threads:[~2012-04-12 0:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 8:34 [PATCH] ARM: OMAP2+: remove redundant sysconfig context restore Tarun Kanti DebBarma
2012-04-11 8:43 ` Shilimkar, Santosh
2012-04-12 0:34 ` Kevin Hilman [this message]
2012-04-12 4:52 ` DebBarma, Tarun Kanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zkahlrdc.fsf@ti.com \
--to=khilman@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tarun.kanti@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox