[PATCH] ARM: OMAP2+: remove redundant sysconfig context restore

[PATCH] ARM: OMAP2+: remove redundant sysconfig context restore

[Tarun Kanti DebBarma]

Since hwmod framework now manages sysconfig context save/restore
there is no more need to touch this register in driver. Hence,
remove restore of sysconfig register in omap_timer_restore_context.
This was causing incorrect context restore of sysconfig register.

Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>
---
 arch/arm/plat-omap/dmtimer.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
index 652139c..15e7882 100644
--- a/arch/arm/plat-omap/dmtimer.c
+++ b/arch/arm/plat-omap/dmtimer.c
@@ -82,8 +82,6 @@ static void omap_dm_timer_write_reg(struct omap_dm_timer *timer, u32 reg,
 
 static void omap_timer_restore_context(struct omap_dm_timer *timer)
 {
-	__raw_writel(timer->context.tiocp_cfg,
-			timer->io_base + OMAP_TIMER_OCP_CFG_OFFSET);
 	if (timer->revision == 1)
 		__raw_writel(timer->context.tistat, timer->sys_stat);
 
-- 
1.7.0.4

Re: [PATCH] ARM: OMAP2+: remove redundant sysconfig context restore

[Shilimkar, Santosh]

CC'ing LAKML

On Wed, Apr 11, 2012 at 2:04 PM, Tarun Kanti DebBarma
<tarun.kanti@ti.com> wrote:
> Since hwmod framework now manages sysconfig context save/restore
> there is no more need to touch this register in driver. Hence,
> remove restore of sysconfig register in omap_timer_restore_context.
> This was causing incorrect context restore of sysconfig register.
>
> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>
> ---
>  arch/arm/plat-omap/dmtimer.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
> index 652139c..15e7882 100644
> --- a/arch/arm/plat-omap/dmtimer.c
> +++ b/arch/arm/plat-omap/dmtimer.c
> @@ -82,8 +82,6 @@ static void omap_dm_timer_write_reg(struct omap_dm_timer *timer, u32 reg,
>
>  static void omap_timer_restore_context(struct omap_dm_timer *timer)
>  {
> -       __raw_writel(timer->context.tiocp_cfg,
> -                       timer->io_base + OMAP_TIMER_OCP_CFG_OFFSET);
>        if (timer->revision == 1)
>                __raw_writel(timer->context.tistat, timer->sys_stat);
>

Looks good to me.

Acked-by: Santosh Shilimkar <santosh.shilimka@ti.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP2+: remove redundant sysconfig context restore

[Kevin Hilman]

Tarun Kanti DebBarma <tarun.kanti@ti.com> writes:

> Since hwmod framework now manages sysconfig context save/restore
> there is no more need to touch this register in driver. Hence,
> remove restore of sysconfig register in omap_timer_restore_context.
> This was causing incorrect context restore of sysconfig register.
>
> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>

While cleaning this up, you can remove it from 'struct timer_regs'  in
<plat/dmtimer.h> as well, since the code you remove is the only user.

Kevin

> ---
>  arch/arm/plat-omap/dmtimer.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
> index 652139c..15e7882 100644
> --- a/arch/arm/plat-omap/dmtimer.c
> +++ b/arch/arm/plat-omap/dmtimer.c
> @@ -82,8 +82,6 @@ static void omap_dm_timer_write_reg(struct omap_dm_timer *timer, u32 reg,
>  
>  static void omap_timer_restore_context(struct omap_dm_timer *timer)
>  {
> -	__raw_writel(timer->context.tiocp_cfg,
> -			timer->io_base + OMAP_TIMER_OCP_CFG_OFFSET);
>  	if (timer->revision == 1)
>  		__raw_writel(timer->context.tistat, timer->sys_stat);

Re: [PATCH] ARM: OMAP2+: remove redundant sysconfig context restore

[DebBarma, Tarun Kanti]

On Thu, Apr 12, 2012 at 6:04 AM, Kevin Hilman <khilman@ti.com> wrote:
> Tarun Kanti DebBarma <tarun.kanti@ti.com> writes:
>
>> Since hwmod framework now manages sysconfig context save/restore
>> there is no more need to touch this register in driver. Hence,
>> remove restore of sysconfig register in omap_timer_restore_context.
>> This was causing incorrect context restore of sysconfig register.
>>
>> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>
>
> While cleaning this up, you can remove it from 'struct timer_regs'  in
> <plat/dmtimer.h> as well, since the code you remove is the only user.
Oh yes I missed that. Thanks.
--
Tarun
>
> Kevin
>
>> ---
>>  arch/arm/plat-omap/dmtimer.c |    2 --
>>  1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
>> index 652139c..15e7882 100644
>> --- a/arch/arm/plat-omap/dmtimer.c
>> +++ b/arch/arm/plat-omap/dmtimer.c
>> @@ -82,8 +82,6 @@ static void omap_dm_timer_write_reg(struct omap_dm_timer *timer, u32 reg,
>>
>>  static void omap_timer_restore_context(struct omap_dm_timer *timer)
>>  {
>> -     __raw_writel(timer->context.tiocp_cfg,
>> -                     timer->io_base + OMAP_TIMER_OCP_CFG_OFFSET);
>>       if (timer->revision == 1)
>>               __raw_writel(timer->context.tistat, timer->sys_stat);
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html