From: Mark Brown <broonie@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Arnd Bergmann <arnd@kernel.org>, Tony Lindgren <tony@atomide.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jerome Neanne <jneanne@baylibre.com>,
Axel Lin <axel.lin@ingics.com>,
Yang Li <yang.lee@linux.alibaba.com>,
Yang Yingliang <yangyingliang@huawei.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] regulator: tps65219: fix Wextra warning
Date: Thu, 19 Jan 2023 11:13:21 +0000 [thread overview]
Message-ID: <Y8kl0YZwMO3nkaly@sirena.org.uk> (raw)
In-Reply-To: <b1f98c2a-3087-464e-b9fb-97e7c78cfdab@app.fastmail.com>
[-- Attachment #1: Type: text/plain, Size: 566 bytes --]
On Thu, Jan 19, 2023 at 09:07:38AM +0100, Arnd Bergmann wrote:
> It looks like you merged another workaround from Randy Dunlap now as
> commit 2bbba115c3c9 ("regulator: tps65219: use IS_ERR() to detect an error
> pointer"), but I think that one is just as wrong as the one I submitted:
> the 'rdev' variable still remains uninitialized, and checking its value
> after it has already been used is not helpful.
Right, that's just changing the way the result is parsed, it's
nothing to do with making sure things are initialised. It's just
a coccinelle style thing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2023-01-20 5:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 16:41 [PATCH] regulator: tps65219: fix Wextra warning Arnd Bergmann
2022-12-15 16:48 ` Mark Brown
2022-12-16 10:18 ` Arnd Bergmann
2023-01-19 8:07 ` Arnd Bergmann
2023-01-19 11:13 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8kl0YZwMO3nkaly@sirena.org.uk \
--to=broonie@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=axel.lin@ingics.com \
--cc=jneanne@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=tony@atomide.com \
--cc=yang.lee@linux.alibaba.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox