Re: [tmlind-omap:for-next 3/12] drivers/bus/ti-sysc.c:2494:13: error: variable 'error' set but not used

Re: [tmlind-omap:for-next 3/12] drivers/bus/ti-sysc.c:2494:13: error: variable 'error' set but not used

[Tony Lindgren]

* kernel test robot <lkp@intel.com> [211001 02:09]:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git for-next
> head:   7fd4d99072ce6b546bdcf99d32c8f7449abd7fa4
> commit: 9d881361206ebcf6285c2ec2ef275aff80875347 [3/12] bus: ti-sysc: Add quirk handling for reinit on context lost
> config: arm-allyesconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/commit/?id=9d881361206ebcf6285c2ec2ef275aff80875347
>         git remote add tmlind-omap https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git
>         git fetch --no-tags tmlind-omap for-next
>         git checkout 9d881361206ebcf6285c2ec2ef275aff80875347
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/bus/ti-sysc.c: In function 'sysc_reinit_modules':
> >> drivers/bus/ti-sysc.c:2494:13: error: variable 'error' set but not used [-Werror=unused-but-set-variable]
>     2494 |         int error = 0;
>          |             ^~~~~
>    cc1: all warnings being treated as errors
> 
> 
> vim +/error +2494 drivers/bus/ti-sysc.c
> 
>   2487	
>   2488	/* Caller needs to take list_lock if ever used outside of cpu_pm */
>   2489	static void sysc_reinit_modules(struct sysc_soc_info *soc)
>   2490	{
>   2491		struct sysc_module *module;
>   2492		struct list_head *pos;
>   2493		struct sysc *ddata;
> > 2494		int error = 0;
>   2495	
>   2496		list_for_each(pos, &sysc_soc->restored_modules) {
>   2497			module = list_entry(pos, struct sysc_module, node);
>   2498			ddata = module->ddata;
>   2499			error = sysc_reinit_module(ddata, ddata->enabled);
>   2500		}
>   2501	}
>   2502	

Thanks for the report, I'll post a patch to fix this. Not much we can do here
on errors and we already log errors in sysc_reinit_module.

Regards,

Tony