From: Tony Lindgren <tony@atomide.com>
To: Liang He <windhl@126.com>
Cc: p.zabel@pengutronix.de, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2] bus/ti-sys: Fix refcount leak bugs
Date: Tue, 28 Jun 2022 09:02:07 +0300 [thread overview]
Message-ID: <YrqZX+bwQYQNgZ6m@atomide.com> (raw)
In-Reply-To: <20220620145619.4074665-1-windhl@126.com>
* Liang He <windhl@126.com> [220620 17:51]:
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -751,6 +751,7 @@ static void sysc_init_stdout_path(struct sysc *ddata)
> goto err;
>
> uart = of_get_property(np, "stdout-path", NULL);
> + of_node_put(np);
> if (!uart)
> goto err;
>
Looks like you missed another of_node_put() after of_find_node_by_path()
in sysc_init_stdout_path(). Please add it and repost.
Thanks,
Tony
next prev parent reply other threads:[~2022-06-28 6:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 14:56 [PATCH v2] bus/ti-sys: Fix refcount leak bugs Liang He
2022-06-28 6:02 ` Tony Lindgren [this message]
2022-06-28 6:09 ` Liang He
2022-06-28 6:24 ` Liang He
2022-06-28 6:34 ` Tony Lindgren
2022-07-04 7:23 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrqZX+bwQYQNgZ6m@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox