From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Tony Lindgren <tony@atomide.com>, Lee Jones <lee@kernel.org>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mfd: palmas: Make similar OF and ID table
Date: Tue, 29 Aug 2023 17:46:24 +0300 [thread overview]
Message-ID: <ZO4EwAgDU0yefC/t@smile.fi.intel.com> (raw)
In-Reply-To: <20230828153144.75479-3-biju.das.jz@bp.renesas.com>
On Mon, Aug 28, 2023 at 04:31:44PM +0100, Biju Das wrote:
> Make similar OF and ID table to extend support for ID match using
> i2c_match_data(). Currently it works only for OF match tables as the
> driver_data is wrong for ID match.
...
> While at it, drop the inner leading commas for ID table.
Are you sure?
------------------v
> - { "palmas", },
> - { "twl6035", },
> - { "twl6037", },
> - { "tps65913", },
> + { "palmas", (kernel_ulong_t)&palmas_data },
> + { "twl6035", (kernel_ulong_t)&palmas_data },
> + { "twl6037", (kernel_ulong_t)&palmas_data },
> + { "tps65913", (kernel_ulong_t)&palmas_data },
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-29 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 15:31 [PATCH v2 0/2] Match data improvements for palmas driver Biju Das
2023-08-28 15:31 ` [PATCH v2 1/2] mfd: palmas: Constify .data in OF table and {palmas,tps65917}_irq_chip Biju Das
2023-08-29 14:47 ` Andy Shevchenko
2023-08-29 14:52 ` Biju Das
2023-08-28 15:31 ` [PATCH v2 2/2] mfd: palmas: Make similar OF and ID table Biju Das
2023-08-29 14:46 ` Andy Shevchenko [this message]
2023-08-29 14:51 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO4EwAgDU0yefC/t@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox