[PATCH v2 0/3] ARM: dts: omap: workarounds for Ethernet PHY strap on DRA71 and DRA72 EVMs

[PATCH v2 0/3] ARM: dts: omap: workarounds for Ethernet PHY strap on DRA71 and DRA72 EVMs

[Sekhar Nori]

Hi Tony,

Here are some patches to overcome incorrect Ethernet PHY strap settings
on DRA72x EVM Rev C and DRA71 EVM. Both of these boards use TI's DP83867
PHY.

The incorrect PHY strap settings cause a voilation of PHY specification
and need to be worked around in software as documented in the commit
messages. But there is no known issue that these patches fix.

Changes from v1:
- Add Grygorii's reviewed-by to 3/3
- Rebase on latest mainline master

Sekhar Nori (3):
  ARM: dts: dra71-evm: workaround incorrect DP83867 RX_CTRL pin strap
  ARM: dts: dra72-evm-revc: workaround incorrect DP83867 RX_CTRL pin
    strap
  ARM: omap2plus_defconfig: enable DP83867 phy driver

 arch/arm/boot/dts/dra71-evm.dts      | 2 ++
 arch/arm/boot/dts/dra72-evm-revc.dts | 3 +++
 arch/arm/configs/omap2plus_defconfig | 1 +
 3 files changed, 6 insertions(+)

-- 
2.9.0

[PATCH v2 1/3] ARM: dts: dra71-evm: workaround incorrect DP83867 RX_CTRL pin strap

[Sekhar Nori]

The DRA71 EVM straps the DP83867 GigaBit Ethernet phy's RX_DV/RX_CTRL pin
in mode 1. Unfortunately, the phy data manual disallows this.

Add "ti,dp83867-rxctrl-strap-quirk" property to the phy's device-tree node
to allow kernel to enable software workaround for this incorrect strap
setting. This is as suggested by the phy's datamanual and ensures proper
operation of this PHY.

This needs to be done for both instances of this PHY present on the board.

Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 arch/arm/boot/dts/dra71-evm.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/dra71-evm.dts b/arch/arm/boot/dts/dra71-evm.dts
index a6298eb56978..9897e8fa6845 100644
--- a/arch/arm/boot/dts/dra71-evm.dts
+++ b/arch/arm/boot/dts/dra71-evm.dts
@@ -191,6 +191,7 @@
 		ti,tx-internal-delay = <DP83867_RGMIIDCTL_250_PS>;
 		ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_8_B_NIB>;
 		ti,min-output-impedance;
+		ti,dp83867-rxctrl-strap-quirk;
 	};
 
 	dp83867_1: ethernet-phy@3 {
@@ -199,6 +200,7 @@
 		ti,tx-internal-delay = <DP83867_RGMIIDCTL_250_PS>;
 		ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_8_B_NIB>;
 		ti,min-output-impedance;
+		ti,dp83867-rxctrl-strap-quirk;
 	};
 };
 
-- 
2.9.0

[PATCH v2 2/3] ARM: dts: dra72-evm-revc: workaround incorrect DP83867 RX_CTRL pin strap

[Sekhar Nori]

The DRA72 EVM Rev C straps the DP83867 GigaBit Ethernet phy's RX_DV/RX_CTRL
pin in mode 1. Unfortunately, the phy data manual disallows this.

Add "ti,dp83867-rxctrl-strap-quirk" property to the phy's device-tree node
to allow kernel to enable software workaround for this incorrect strap
setting. This is as suggested by the phy's datamanual and ensures proper
operation of this PHY.

This needs to be done for both instances of this PHY present on the board.

Signed-off-by: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
---
 arch/arm/boot/dts/dra72-evm-revc.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/dra72-evm-revc.dts b/arch/arm/boot/dts/dra72-evm-revc.dts
index 3ecac56bf504..be18bc023c3f 100644
--- a/arch/arm/boot/dts/dra72-evm-revc.dts
+++ b/arch/arm/boot/dts/dra72-evm-revc.dts
@@ -70,6 +70,7 @@
 		ti,min-output-impedance;
 		interrupt-parent = <&gpio6>;
 		interrupts = <16 IRQ_TYPE_EDGE_FALLING>;
+		ti,dp83867-rxctrl-strap-quirk;
 	};
 
 	dp83867_1: ethernet-phy@3 {
@@ -80,5 +81,7 @@
 		ti,min-output-impedance;
 		interrupt-parent = <&gpio6>;
 		interrupts = <16 IRQ_TYPE_EDGE_FALLING>;
+		ti,dp83867-rxctrl-strap-quirk;
 	};
 };
+
-- 
2.9.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 3/3] ARM: omap2plus_defconfig: enable DP83867 phy driver

[Sekhar Nori]

TI's DP83867 phy is used on DRA72x EVM rev C and DRA71x
EVMs. Enable support for it in omap2plus_defconfig.

The driver is built into the kernel to help NFS booting.

Reviewed-by: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
Signed-off-by: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
---
 arch/arm/configs/omap2plus_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
index a120ae816260..d4afa2ca2537 100644
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -170,6 +170,7 @@ CONFIG_TI_CPTS=y
 # CONFIG_NET_VENDOR_WIZNET is not set
 CONFIG_AT803X_PHY=y
 CONFIG_DP83848_PHY=y
+CONFIG_DP83867_PHY=y
 CONFIG_MICREL_PHY=y
 CONFIG_SMSC_PHY=y
 CONFIG_PPP=m
-- 
2.9.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/3] ARM: dts: omap: workarounds for Ethernet PHY strap on DRA71 and DRA72 EVMs

[Grygorii Strashko]

On 08/09/2017 09:02 AM, Sekhar Nori wrote:
> Hi Tony,
> 
> Here are some patches to overcome incorrect Ethernet PHY strap settings
> on DRA72x EVM Rev C and DRA71 EVM. Both of these boards use TI's DP83867
> PHY.
> 
> The incorrect PHY strap settings cause a voilation of PHY specification
> and need to be worked around in software as documented in the commit
> messages. But there is no known issue that these patches fix.
> 
> Changes from v1:
> - Add Grygorii's reviewed-by to 3/3
> - Rebase on latest mainline master
> 
> Sekhar Nori (3):
>    ARM: dts: dra71-evm: workaround incorrect DP83867 RX_CTRL pin strap
>    ARM: dts: dra72-evm-revc: workaround incorrect DP83867 RX_CTRL pin
>      strap
>    ARM: omap2plus_defconfig: enable DP83867 phy driver
> 
>   arch/arm/boot/dts/dra71-evm.dts      | 2 ++
>   arch/arm/boot/dts/dra72-evm-revc.dts | 3 +++
>   arch/arm/configs/omap2plus_defconfig | 1 +
>   3 files changed, 6 insertions(+)
> 

Reviewed-by: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>

-- 
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/3] ARM: dts: omap: workarounds for Ethernet PHY strap on DRA71 and DRA72 EVMs

[Tony Lindgren]

* Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org> [170809 15:27]:
> On 08/09/2017 09:02 AM, Sekhar Nori wrote:
> > Here are some patches to overcome incorrect Ethernet PHY strap settings
> > on DRA72x EVM Rev C and DRA71 EVM. Both of these boards use TI's DP83867
> > PHY.
> > 
> > The incorrect PHY strap settings cause a voilation of PHY specification
> > and need to be worked around in software as documented in the commit
> > messages. But there is no known issue that these patches fix.
...

> Reviewed-by: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>

Applying dts changes into omap-for-v4.14/fixes-not-urgent
and defconfig into omap-for-v4.14/defconfig.

Thanks,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html