* [PATCH 00/33] cpufreq: manage common sysfs attributes from core
@ 2025-01-23 11:35 Viresh Kumar
2025-01-23 11:35 ` [PATCH 15/33] cpufreq: omap: Stop setting cpufreq_driver->attr field Viresh Kumar
2025-01-23 19:40 ` [PATCH 00/33] cpufreq: manage common sysfs attributes from core Rafael J. Wysocki
0 siblings, 2 replies; 3+ messages in thread
From: Viresh Kumar @ 2025-01-23 11:35 UTC (permalink / raw)
To: Rafael J. Wysocki, Alyssa Rosenzweig, AngeloGioacchino Del Regno,
Broadcom internal kernel review list, Christophe Leroy,
Cristian Marussi, Fabio Estevam, Florian Fainelli, Hector Martin,
Huacai Chen, Jiaxun Yang, Jonathan Hunter, Kevin Hilman,
Madhavan Srinivasan, Markus Mayer, Matthias Brugger,
Michael Ellerman, Naveen N Rao, Nicholas Piggin,
Pengutronix Kernel Team, Sascha Hauer, Shawn Guo, Sudeep Holla,
Sven Peter, Thierry Reding, Viresh Kumar, WANG Xuerui
Cc: linux-pm, Vincent Guittot, arm-scmi, asahi, imx, linux-arm-kernel,
linux-arm-msm, linux-kernel, linux-mediatek, linux-mips,
linux-omap, linuxppc-dev, linux-tegra, loongarch
Hello,
Most of the drivers add available and boost frequencies related attributes. This
patch series tries to avoid duplication and simplify driver's code by managing
these from core code.
A quick search revealed that only the drivers that set the
policy->freq_table field, enable these attributes. Which makes sense as
well, since the show_available_freqs() helper works only if the
freq_table is present.
In order to simplify drivers, create the relevant sysfs files forcefully
from cpufreq core.
Pushed here:
git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git cpufreq/core-attr
--
Viresh
Viresh Kumar (33):
cpufreq: Always create freq-table related sysfs file
cpufreq: dt: Stop setting cpufreq_driver->attr field
cpufreq: acpi: Stop setting common freq attributes
cpufreq: apple: Stop setting cpufreq_driver->attr field
cpufreq: bmips: Stop setting cpufreq_driver->attr field
cpufreq: brcmstb: Stop setting common freq attributes
cpufreq: davinci: Stop setting cpufreq_driver->attr field
cpufreq: e_powersaver: Stop setting cpufreq_driver->attr field
cpufreq: elanfreq: Stop setting cpufreq_driver->attr field
cpufreq: imx6q: Stop setting cpufreq_driver->attr field
cpufreq: kirkwood: Stop setting cpufreq_driver->attr field
cpufreq: longhaul: Stop setting cpufreq_driver->attr field
cpufreq: loongson: Stop setting cpufreq_driver->attr field
cpufreq: mediatek: Stop setting cpufreq_driver->attr field
cpufreq: omap: Stop setting cpufreq_driver->attr field
cpufreq: p4: Stop setting cpufreq_driver->attr field
cpufreq: pasemi: Stop setting cpufreq_driver->attr field
cpufreq: pmac: Stop setting cpufreq_driver->attr field
cpufreq: powernow: Stop setting cpufreq_driver->attr field
cpufreq: powernv: Stop setting common freq attributes
cpufreq: qcom: Stop setting cpufreq_driver->attr field
cpufreq: qoriq: Stop setting cpufreq_driver->attr field
cpufreq: sc520_freq: Stop setting cpufreq_driver->attr field
cpufreq: scmi: Stop setting cpufreq_driver->attr field
cpufreq: scpi: Stop setting cpufreq_driver->attr field
cpufreq: sh: Stop setting cpufreq_driver->attr field
cpufreq: spear: Stop setting cpufreq_driver->attr field
cpufreq: speedstep: Stop setting cpufreq_driver->attr field
cpufreq: tegra: Stop setting cpufreq_driver->attr field
cpufreq: vexpress: Stop setting cpufreq_driver->attr field
cpufreq: virtual: Stop setting cpufreq_driver->attr field
cpufreq: Remove cpufreq_generic_attrs
cpufreq: Stop checking for duplicate available/boost freq attributes
drivers/cpufreq/acpi-cpufreq.c | 1 -
drivers/cpufreq/apple-soc-cpufreq.c | 8 --------
drivers/cpufreq/bmips-cpufreq.c | 1 -
drivers/cpufreq/brcmstb-avs-cpufreq.c | 1 -
drivers/cpufreq/cpufreq-dt.c | 8 --------
drivers/cpufreq/cpufreq.c | 15 +++++++++++++++
drivers/cpufreq/davinci-cpufreq.c | 1 -
drivers/cpufreq/e_powersaver.c | 1 -
drivers/cpufreq/elanfreq.c | 1 -
drivers/cpufreq/freq_table.c | 8 --------
drivers/cpufreq/imx6q-cpufreq.c | 1 -
drivers/cpufreq/kirkwood-cpufreq.c | 1 -
drivers/cpufreq/longhaul.c | 1 -
drivers/cpufreq/loongson2_cpufreq.c | 1 -
drivers/cpufreq/loongson3_cpufreq.c | 1 -
drivers/cpufreq/mediatek-cpufreq-hw.c | 1 -
drivers/cpufreq/mediatek-cpufreq.c | 1 -
drivers/cpufreq/omap-cpufreq.c | 1 -
drivers/cpufreq/p4-clockmod.c | 1 -
drivers/cpufreq/pasemi-cpufreq.c | 1 -
drivers/cpufreq/pmac32-cpufreq.c | 1 -
drivers/cpufreq/pmac64-cpufreq.c | 1 -
drivers/cpufreq/powernow-k6.c | 1 -
drivers/cpufreq/powernow-k7.c | 1 -
drivers/cpufreq/powernow-k8.c | 1 -
drivers/cpufreq/powernv-cpufreq.c | 2 --
drivers/cpufreq/qcom-cpufreq-hw.c | 7 -------
drivers/cpufreq/qoriq-cpufreq.c | 1 -
drivers/cpufreq/sc520_freq.c | 1 -
drivers/cpufreq/scmi-cpufreq.c | 8 --------
drivers/cpufreq/scpi-cpufreq.c | 1 -
drivers/cpufreq/sh-cpufreq.c | 1 -
drivers/cpufreq/spear-cpufreq.c | 1 -
drivers/cpufreq/speedstep-centrino.c | 1 -
drivers/cpufreq/speedstep-ich.c | 1 -
drivers/cpufreq/speedstep-smi.c | 1 -
drivers/cpufreq/tegra186-cpufreq.c | 1 -
drivers/cpufreq/tegra194-cpufreq.c | 1 -
drivers/cpufreq/vexpress-spc-cpufreq.c | 1 -
drivers/cpufreq/virtual-cpufreq.c | 1 -
include/linux/cpufreq.h | 1 -
41 files changed, 15 insertions(+), 75 deletions(-)
--
2.31.1.272.g89b43f80a514
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 15/33] cpufreq: omap: Stop setting cpufreq_driver->attr field
2025-01-23 11:35 [PATCH 00/33] cpufreq: manage common sysfs attributes from core Viresh Kumar
@ 2025-01-23 11:35 ` Viresh Kumar
2025-01-23 19:40 ` [PATCH 00/33] cpufreq: manage common sysfs attributes from core Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2025-01-23 11:35 UTC (permalink / raw)
To: Rafael J. Wysocki, Kevin Hilman, Viresh Kumar
Cc: linux-pm, Vincent Guittot, linux-omap, linux-kernel
The cpufreq core handles this for basic attributes now, the driver can skip
setting them.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/omap-cpufreq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpufreq/omap-cpufreq.c b/drivers/cpufreq/omap-cpufreq.c
index 106220c0fd11..bbb01d93b54b 100644
--- a/drivers/cpufreq/omap-cpufreq.c
+++ b/drivers/cpufreq/omap-cpufreq.c
@@ -147,7 +147,6 @@ static struct cpufreq_driver omap_driver = {
.exit = omap_cpu_exit,
.register_em = cpufreq_register_em_with_opp,
.name = "omap",
- .attr = cpufreq_generic_attr,
};
static int omap_cpufreq_probe(struct platform_device *pdev)
--
2.31.1.272.g89b43f80a514
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 00/33] cpufreq: manage common sysfs attributes from core
2025-01-23 11:35 [PATCH 00/33] cpufreq: manage common sysfs attributes from core Viresh Kumar
2025-01-23 11:35 ` [PATCH 15/33] cpufreq: omap: Stop setting cpufreq_driver->attr field Viresh Kumar
@ 2025-01-23 19:40 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2025-01-23 19:40 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael J. Wysocki, Alyssa Rosenzweig, AngeloGioacchino Del Regno,
Broadcom internal kernel review list, Christophe Leroy,
Cristian Marussi, Fabio Estevam, Florian Fainelli, Hector Martin,
Huacai Chen, Jiaxun Yang, Jonathan Hunter, Kevin Hilman,
Madhavan Srinivasan, Markus Mayer, Matthias Brugger,
Michael Ellerman, Naveen N Rao, Nicholas Piggin,
Pengutronix Kernel Team, Sascha Hauer, Shawn Guo, Sudeep Holla,
Sven Peter, Thierry Reding, WANG Xuerui, linux-pm,
Vincent Guittot, arm-scmi, asahi, imx, linux-arm-kernel,
linux-arm-msm, linux-kernel, linux-mediatek, linux-mips,
linux-omap, linuxppc-dev, linux-tegra, loongarch
On Thu, Jan 23, 2025 at 12:38 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> Hello,
>
> Most of the drivers add available and boost frequencies related attributes. This
> patch series tries to avoid duplication and simplify driver's code by managing
> these from core code.
>
> A quick search revealed that only the drivers that set the
> policy->freq_table field, enable these attributes. Which makes sense as
> well, since the show_available_freqs() helper works only if the
> freq_table is present.
>
> In order to simplify drivers, create the relevant sysfs files forcefully
> from cpufreq core.
>
> Pushed here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git cpufreq/core-attr
Acked-by: Rafael J. Wysocki <rafael@kernel.org>
for the series.
Thanks!
> --
> Viresh
>
> Viresh Kumar (33):
> cpufreq: Always create freq-table related sysfs file
> cpufreq: dt: Stop setting cpufreq_driver->attr field
> cpufreq: acpi: Stop setting common freq attributes
> cpufreq: apple: Stop setting cpufreq_driver->attr field
> cpufreq: bmips: Stop setting cpufreq_driver->attr field
> cpufreq: brcmstb: Stop setting common freq attributes
> cpufreq: davinci: Stop setting cpufreq_driver->attr field
> cpufreq: e_powersaver: Stop setting cpufreq_driver->attr field
> cpufreq: elanfreq: Stop setting cpufreq_driver->attr field
> cpufreq: imx6q: Stop setting cpufreq_driver->attr field
> cpufreq: kirkwood: Stop setting cpufreq_driver->attr field
> cpufreq: longhaul: Stop setting cpufreq_driver->attr field
> cpufreq: loongson: Stop setting cpufreq_driver->attr field
> cpufreq: mediatek: Stop setting cpufreq_driver->attr field
> cpufreq: omap: Stop setting cpufreq_driver->attr field
> cpufreq: p4: Stop setting cpufreq_driver->attr field
> cpufreq: pasemi: Stop setting cpufreq_driver->attr field
> cpufreq: pmac: Stop setting cpufreq_driver->attr field
> cpufreq: powernow: Stop setting cpufreq_driver->attr field
> cpufreq: powernv: Stop setting common freq attributes
> cpufreq: qcom: Stop setting cpufreq_driver->attr field
> cpufreq: qoriq: Stop setting cpufreq_driver->attr field
> cpufreq: sc520_freq: Stop setting cpufreq_driver->attr field
> cpufreq: scmi: Stop setting cpufreq_driver->attr field
> cpufreq: scpi: Stop setting cpufreq_driver->attr field
> cpufreq: sh: Stop setting cpufreq_driver->attr field
> cpufreq: spear: Stop setting cpufreq_driver->attr field
> cpufreq: speedstep: Stop setting cpufreq_driver->attr field
> cpufreq: tegra: Stop setting cpufreq_driver->attr field
> cpufreq: vexpress: Stop setting cpufreq_driver->attr field
> cpufreq: virtual: Stop setting cpufreq_driver->attr field
> cpufreq: Remove cpufreq_generic_attrs
> cpufreq: Stop checking for duplicate available/boost freq attributes
>
> drivers/cpufreq/acpi-cpufreq.c | 1 -
> drivers/cpufreq/apple-soc-cpufreq.c | 8 --------
> drivers/cpufreq/bmips-cpufreq.c | 1 -
> drivers/cpufreq/brcmstb-avs-cpufreq.c | 1 -
> drivers/cpufreq/cpufreq-dt.c | 8 --------
> drivers/cpufreq/cpufreq.c | 15 +++++++++++++++
> drivers/cpufreq/davinci-cpufreq.c | 1 -
> drivers/cpufreq/e_powersaver.c | 1 -
> drivers/cpufreq/elanfreq.c | 1 -
> drivers/cpufreq/freq_table.c | 8 --------
> drivers/cpufreq/imx6q-cpufreq.c | 1 -
> drivers/cpufreq/kirkwood-cpufreq.c | 1 -
> drivers/cpufreq/longhaul.c | 1 -
> drivers/cpufreq/loongson2_cpufreq.c | 1 -
> drivers/cpufreq/loongson3_cpufreq.c | 1 -
> drivers/cpufreq/mediatek-cpufreq-hw.c | 1 -
> drivers/cpufreq/mediatek-cpufreq.c | 1 -
> drivers/cpufreq/omap-cpufreq.c | 1 -
> drivers/cpufreq/p4-clockmod.c | 1 -
> drivers/cpufreq/pasemi-cpufreq.c | 1 -
> drivers/cpufreq/pmac32-cpufreq.c | 1 -
> drivers/cpufreq/pmac64-cpufreq.c | 1 -
> drivers/cpufreq/powernow-k6.c | 1 -
> drivers/cpufreq/powernow-k7.c | 1 -
> drivers/cpufreq/powernow-k8.c | 1 -
> drivers/cpufreq/powernv-cpufreq.c | 2 --
> drivers/cpufreq/qcom-cpufreq-hw.c | 7 -------
> drivers/cpufreq/qoriq-cpufreq.c | 1 -
> drivers/cpufreq/sc520_freq.c | 1 -
> drivers/cpufreq/scmi-cpufreq.c | 8 --------
> drivers/cpufreq/scpi-cpufreq.c | 1 -
> drivers/cpufreq/sh-cpufreq.c | 1 -
> drivers/cpufreq/spear-cpufreq.c | 1 -
> drivers/cpufreq/speedstep-centrino.c | 1 -
> drivers/cpufreq/speedstep-ich.c | 1 -
> drivers/cpufreq/speedstep-smi.c | 1 -
> drivers/cpufreq/tegra186-cpufreq.c | 1 -
> drivers/cpufreq/tegra194-cpufreq.c | 1 -
> drivers/cpufreq/vexpress-spc-cpufreq.c | 1 -
> drivers/cpufreq/virtual-cpufreq.c | 1 -
> include/linux/cpufreq.h | 1 -
> 41 files changed, 15 insertions(+), 75 deletions(-)
>
> --
> 2.31.1.272.g89b43f80a514
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-23 19:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-23 11:35 [PATCH 00/33] cpufreq: manage common sysfs attributes from core Viresh Kumar
2025-01-23 11:35 ` [PATCH 15/33] cpufreq: omap: Stop setting cpufreq_driver->attr field Viresh Kumar
2025-01-23 19:40 ` [PATCH 00/33] cpufreq: manage common sysfs attributes from core Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox