From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Verma, Achal" <a-verma1@ti.com>,
Tom Joseph <tjoseph@cadence.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Krzysztof Wilczy_ski <kw@linux.com>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Bjorn Andersson <quic_bjorande@quicinc.com>,
Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
"N_colas F . R . A . Prado" <nfraprado@collabora.com>,
Mark Brown <broonie@kernel.org>, Rafa_ Mi_ecki <rafal@milecki.pl>,
Vignesh Raghavendra <vigneshr@ti.com>, Nishanth Menon <nm@ti.com>,
Milind Parab <mparab@cadence.com>,
Swapnil Kashinath Jakhade <sjakhade@cadence.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [EXTERNAL] Re: [PATCH 3/3] arm64: defconfig: enable J721e PCIe controller
Date: Sat, 13 May 2023 20:39:25 +0200 [thread overview]
Message-ID: <d137b401-5b4a-bab7-ec21-ea267bd07c41@linaro.org> (raw)
In-Reply-To: <3b5d7c3c-164d-0690-c2e8-2c7daec4865c@ti.com>
On 13/05/2023 19:58, Verma, Achal wrote:
>
> Hello Krzysztof,
> On 5/12/2023 12:53 PM, Krzysztof Kozlowski wrote:
>> On 12/05/2023 09:05, Achal Verma wrote:
>>> Enable Cadence PCIe controller and pci-j721e drivers to be built as
>>> kernel modules.
>>
>> Why? IOW, who needs them. Please provide rationale in the commit msg. I
>> am pretty sure I asked for this...
>>
> On TI's J7 SOCs, PCIe is composed of PCIe core from Cadence and TI
> wrapper. It is desired to have J7 PCIe working on upstream kernel by
> default. So to enable this I have pushed these defconfig changes.
>
> BTW, I am planning to hold this change until PCIe code changes (rest of
> the patches in this series) gets merged.
>
> Please let me know if there are more concern to this.
The concerns are that commit msg does not explain this. Please always
provide in commit msg answer to "why you are doing this". In case of
defconfig the answer to "why" is: "board foo bar with SoC baz uses it".
Best regards,
Krzysztof
prev parent reply other threads:[~2023-05-13 18:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 7:05 [PATCH 0/3] Add support to build pci-j721e as a kernel module Achal Verma
2023-05-12 7:05 ` [PATCH 1/3] PCI: cadence: Add support to build pcie-cadence library " Achal Verma
2023-05-12 7:05 ` [PATCH 2/3] PCIE: j721e: Add support to build pci-j721e " Achal Verma
2023-05-12 16:47 ` Bjorn Helgaas
2023-05-12 7:05 ` [PATCH 3/3] arm64: defconfig: enable J721e PCIe controller Achal Verma
2023-05-12 7:23 ` Krzysztof Kozlowski
2023-05-13 17:58 ` [EXTERNAL] " Verma, Achal
2023-05-13 18:39 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d137b401-5b4a-bab7-ec21-ea267bd07c41@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a-verma1@ti.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=geert+renesas@glider.be \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mparab@cadence.com \
--cc=nfraprado@collabora.com \
--cc=nm@ti.com \
--cc=quic_bjorande@quicinc.com \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=sjakhade@cadence.com \
--cc=tjoseph@cadence.com \
--cc=vigneshr@ti.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox