From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: <dri-devel@lists.freedesktop.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Nikhil Devshatwar <nikhil.nd@ti.com>,
<linux-omap@vger.kernel.org>, <stable@vger.kernel.org>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Subject: Re: [PATCH] drm/omap: sdi: fix bridge enable/disable
Date: Mon, 30 Nov 2020 11:31:07 +0200 [thread overview]
Message-ID: <e8b01da0-96af-7e98-2a62-fb6775cf5a4e@ti.com> (raw)
In-Reply-To: <20201128174528.GD551434@darkstar.musicnaut.iki.fi>
On 28/11/2020 19:45, Aaro Koskinen wrote:
> Hi,
>
> On Fri, Nov 27, 2020 at 10:52:41AM +0200, Tomi Valkeinen wrote:
>> When the SDI output was converted to DRM bridge, the atomic versions of
>> enable and disable funcs were used. This was not intended, as that would
>> require implementing other atomic funcs too. This leads to:
>>
>> WARNING: CPU: 0 PID: 18 at drivers/gpu/drm/drm_bridge.c:708 drm_atomic_helper_commit_modeset_enables+0x134/0x268
>>
>> and display not working.
>>
>> Fix this by using the legacy enable/disable funcs.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> Reported-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>> Fixes: 8bef8a6d5da81b909a190822b96805a47348146f ("drm/omap: sdi: Register a drm_bridge")
>> Cc: stable@vger.kernel.org # v5.7+
>> Tested-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
>
> Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Thanks! I pushed this to drm-misc-fixes. Hopefully with this and Sebastian's patch N900 display now
works.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-11-30 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 8:52 [PATCH] drm/omap: sdi: fix bridge enable/disable Tomi Valkeinen
2020-11-28 17:45 ` Aaro Koskinen
2020-11-30 9:31 ` Tomi Valkeinen [this message]
2020-11-28 22:02 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8b01da0-96af-7e98-2a62-fb6775cf5a4e@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=dri-devel@lists.freedesktop.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-omap@vger.kernel.org \
--cc=nikhil.nd@ti.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox