Re: [PATCHv3 1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible

[Romain Naour <romain.naour@smile.fr>]

Hello Andrew, Siddharth, All,

Le 08/01/2025 à 16:46, Siddharth Vadapalli a écrit :
> On Wed, Jan 08, 2025 at 09:09:37AM -0600, Andrew Davis wrote:
> 
> Hello Andrew,
> 
>> On 1/8/25 7:11 AM, Nishanth Menon wrote:
>>> On 14:46-20250107, Kevin Hilman wrote:
>>>> Nishanth Menon <nm@ti.com> writes:
>>>>
>>>>> On 15:07-20241205, Kevin Hilman wrote:
>>>>>>
>>>>>> On Mon, 02 Dec 2024 15:33:30 +0100, Romain Naour wrote:
>>>>>>> The ACSPCIE_PROXY_CTRL registers within the CTRL_MMR space of TI's J721e
>>>>>>> SoC are used to drive the reference clock to the PCIe Endpoint device via
>>>>>>> the PAD IO Buffers. Add the compatible for allowing the PCIe driver to
>>>>>>> obtain the regmap for the ACSPCIE_CTRL register within the System
>>>>>>> Controller device-tree node in order to enable the PAD IO Buffers.
>>>>>>>
>>>>>>> The Technical Reference Manual for J721e SoC with details of the
>>>>>>> ASCPCIE_CTRL registers is available at:
>>>>>>> https://www.ti.com/lit/zip/spruil1
>>>>>>>
>>>>>>> [...]
>>>>>>
>>>>>> Applied, thanks!
>>>>>>
>>>>>> [1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible
>>>>>>        commit: d8efc0b428856137608ffcbb6994da6041c9fe2a
>>>>>> [2/2] arm64: dts: ti: k3-j721e-beagleboneai64: Enable ACSPCIE output for PCIe1
>>>>>>        commit: 1d5e14a20dc60b440c60bec8489acfd45cdf7508
>>>>>>
>>>>>> Best regards,
>>>>>> -- 
>>>>>> Kevin Hilman <khilman@baylibre.com>
>>>>>>
>>>>> This will need a bit of fixup - See along the lines of the following.
>>>>> Additionally, we should be a bit careful about the dependency of dts
>>>>> mix up from two trees.
>>>>
>>>> sorry, these should be going through your tree in the first place.  They
>>>> are now dropped from my tree, please go ahead and take them along with
>>>> Andrews fixup.  Sorry for complicating things.
>>>
>>>
>>> Romain,
>>>
>>> There is additional fixups needed, unfortunately as well: syscon yaml
>>> has two lists based on which dt-schema version you use.. your patch
>>> fixed one list, but missed the other as well. Could you integrate the
>>> fixes and resubmit, please?
>>>
>>>
>>
>> Or since we already have 'ti,j784s4-acspcie-proxy-ctrl' for the same
>> reason, you could drop the first patch and re-use this compatible.
> 
> I had suggested this in the past since the ACSPCIE IP on J784S4 and J721E
> is the same, but Krzysztof insists that there will be hardware differences
> in the ACSPCIE block across J784S4 and J721E irrespective of what the
> datasheet says, as mentioned by Krzysztof at:
> https://lore.kernel.org/r/1bfdf1f1-7542-4149-a85d-2ac4b659b26b@kernel.org/
> Therefore Romain had to introduce a new compatible for J721E.

There is a pending patch series from Andrew [1] fixing
ti,j784s4-acspcie-proxy-ctrl compatible for the same reason.

Should I take it into account before resubmit?

[1] https://lore.kernel.org/linux-devicetree/20250103174524.28768-1-afd@ti.com/

Best regards,
Romain


> 
> Regards,
> Siddharth.