* Re: [PATCH net-next 01/11] net: stmmac: Make stmmac_pltfr_remove() return void
[not found] ` <20230402143025.2524443-2-u.kleine-koenig@pengutronix.de>
@ 2023-04-02 14:41 ` Jernej Škrabec
2023-04-03 15:55 ` Simon Horman
2023-04-03 20:39 ` Martin Blumenstingl
2 siblings, 0 replies; 3+ messages in thread
From: Jernej Škrabec @ 2023-04-02 14:41 UTC (permalink / raw)
To: Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Maxime Coquelin,
Shawn Guo, Sascha Hauer, Vladimir Zapolskiy, Neil Armstrong,
Kevin Hilman, Vinod Koul, Chen-Yu Tsai, Samuel Holland,
Nobuhiro Iwamatsu, Matthias Brugger, Uwe Kleine-König
Cc: Fabio Estevam, NXP Linux Team, Jerome Brunet, Martin Blumenstingl,
Bhupesh Sharma, AngeloGioacchino Del Regno, netdev, linux-stm32,
linux-arm-kernel, kernel, linux-amlogic, linux-oxnas, linux-sunxi,
linux-mediatek
Dne nedelja, 02. april 2023 ob 16:30:15 CEST je Uwe Kleine-König napisal(a):
> The function returns zero unconditionally. Change it to return void instead
> which simplifies some callers as error handing becomes unnecessary.
>
> The function is also used for some drivers as remove callback. Switch these
> to the .remove_new() callback. For some others no error can happen in the
> remove callback now, convert them to .remove_new(), too.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c | 9 +++------
> drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 9 +++------
> drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-oxnas.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 5 ++---
> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 2 +-
For sunxi:
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c | 4 +---
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 +---
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h | 2 +-
> 17 files changed, 22 insertions(+), 33 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 01/11] net: stmmac: Make stmmac_pltfr_remove() return void
[not found] ` <20230402143025.2524443-2-u.kleine-koenig@pengutronix.de>
2023-04-02 14:41 ` [PATCH net-next 01/11] net: stmmac: Make stmmac_pltfr_remove() return void Jernej Škrabec
@ 2023-04-03 15:55 ` Simon Horman
2023-04-03 20:39 ` Martin Blumenstingl
2 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-04-03 15:55 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Maxime Coquelin,
Shawn Guo, Sascha Hauer, Vladimir Zapolskiy, Neil Armstrong,
Kevin Hilman, Vinod Koul, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, Nobuhiro Iwamatsu, Matthias Brugger,
Fabio Estevam, NXP Linux Team, Jerome Brunet, Martin Blumenstingl,
Bhupesh Sharma, AngeloGioacchino Del Regno, netdev, linux-stm32,
linux-arm-kernel, kernel, linux-amlogic, linux-oxnas, linux-sunxi,
linux-mediatek
On Sun, Apr 02, 2023 at 04:30:15PM +0200, Uwe Kleine-König wrote:
> The function returns zero unconditionally. Change it to return void instead
> which simplifies some callers as error handing becomes unnecessary.
>
> The function is also used for some drivers as remove callback. Switch these
> to the .remove_new() callback. For some others no error can happen in the
> remove callback now, convert them to .remove_new(), too.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 01/11] net: stmmac: Make stmmac_pltfr_remove() return void
[not found] ` <20230402143025.2524443-2-u.kleine-koenig@pengutronix.de>
2023-04-02 14:41 ` [PATCH net-next 01/11] net: stmmac: Make stmmac_pltfr_remove() return void Jernej Škrabec
2023-04-03 15:55 ` Simon Horman
@ 2023-04-03 20:39 ` Martin Blumenstingl
2 siblings, 0 replies; 3+ messages in thread
From: Martin Blumenstingl @ 2023-04-03 20:39 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Maxime Coquelin,
Shawn Guo, Sascha Hauer, Vladimir Zapolskiy, Neil Armstrong,
Kevin Hilman, Vinod Koul, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, Nobuhiro Iwamatsu, Matthias Brugger,
Fabio Estevam, NXP Linux Team, Jerome Brunet, Bhupesh Sharma,
AngeloGioacchino Del Regno, netdev, linux-stm32, linux-arm-kernel,
kernel, linux-amlogic, linux-oxnas, linux-sunxi, linux-mediatek
On Sun, Apr 2, 2023 at 4:31 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> The function returns zero unconditionally. Change it to return void instead
> which simplifies some callers as error handing becomes unnecessary.
>
> The function is also used for some drivers as remove callback. Switch these
> to the .remove_new() callback. For some others no error can happen in the
> remove callback now, convert them to .remove_new(), too.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c | 9 +++------
> drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 9 +++------
> drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 2 +-
for dwmac-meson and dwmac-meson8b:
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-03 20:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230402143025.2524443-1-u.kleine-koenig@pengutronix.de>
[not found] ` <20230402143025.2524443-2-u.kleine-koenig@pengutronix.de>
2023-04-02 14:41 ` [PATCH net-next 01/11] net: stmmac: Make stmmac_pltfr_remove() return void Jernej Škrabec
2023-04-03 15:55 ` Simon Horman
2023-04-03 20:39 ` Martin Blumenstingl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox