Re: Broken Domain Validation in 6.1.84+

[John David Anglin <dave.anglin@bell.net>]

On 2024-04-06 11:06 a.m., James Bottomley wrote:
> On Sat, 2024-04-06 at 10:30 -0400, John David Anglin wrote:
>> On 2024-04-05 3:36 p.m., Bart Van Assche wrote:
>>> On 4/4/24 13:07, John David Anglin wrote:
>>>> On 2024-04-04 12:32 p.m., Bart Van Assche wrote:
>>>>> Can you please help with verifying whether this kernel warning
>>>>> is only
>>>>> triggered by the 6.1 stable kernel series or whether it is also
>>>>> triggered by a vanilla kernel, e.g. kernel v6.8? That will tell
>>>>>   us
>>>>> whether we need to review the upstream changes or the backports
>>>>>   on the v6.1 branch.
>>>> Stable kernel v6.8.3 is okay.
>>> Would it be possible to bisect this issue on the linux-6.1.y
>>> branch? That probably will be faster than reviewing all backports
>>> of SCSI patches on that branch.
>> The warning triggers with v6.1.81.  It doesn't trigger with v6.1.80.
> It's this patch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-6.1.y&id=cf33e6ca12d814e1be2263cb76960d0019d7fb94
>
> The specific problem being that the update to scsi_execute doesn't set
> the sense_len that the WARN_ON is checking.
>
> This isn't a problem in mainline because we've converted all uses of
> scsi_execute.  Stable needs to either complete the conversion or back
> out the inital patch.
This change depends on the above change:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-6.1.y&id=b73dd5f9997279715cd450ee8ca599aaff2eabb9

Thus, more than just the initial patch needs to be backed out.

Dave

-- 
John David Anglin  dave.anglin@bell.net