Linux PARISC architecture development
 help / color / mirror / Atom feed
From: Stoyan Gaydarov <stoyboyker@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Stoyan Gaydarov <stoyboyker@gmail.com>,
	kyle@mcmartin.ca, matthew@wil.cx, grundler@parisc-linux.org,
	linux-parisc@vger.kernel.org
Subject: [PATCH 17/25] [parisc] BUG to BUG_ON changes
Date: Tue, 10 Mar 2009 00:10:42 -0500	[thread overview]
Message-ID: <1236661850-8237-18-git-send-email-stoyboyker@gmail.com> (raw)
In-Reply-To: <1236661850-8237-17-git-send-email-stoyboyker@gmail.com>

Signed-off-by: Stoyan Gaydarov <stoyboyker@gmail.com>
---
 arch/parisc/kernel/pci-dma.c |   12 ++++--------
 1 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c
index df47895..2587563 100644
--- a/arch/parisc/kernel/pci-dma.c
+++ b/arch/parisc/kernel/pci-dma.c
@@ -480,8 +480,7 @@ static int pa11_dma_map_sg(struct device *dev, struct scatterlist *sglist, int n
 {
 	int i;
 
-	if (direction == DMA_NONE)
-	    BUG();
+	BUG_ON(direction == DMA_NONE);
 
 	for (i = 0; i < nents; i++, sglist++ ) {
 		unsigned long vaddr = sg_virt_addr(sglist);
@@ -496,8 +495,7 @@ static void pa11_dma_unmap_sg(struct device *dev, struct scatterlist *sglist, in
 {
 	int i;
 
-	if (direction == DMA_NONE)
-	    BUG();
+	BUG_ON(direction == DMA_NONE);
 
 	if (direction == DMA_TO_DEVICE)
 	    return;
@@ -511,16 +509,14 @@ static void pa11_dma_unmap_sg(struct device *dev, struct scatterlist *sglist, in
 
 static void pa11_dma_sync_single_for_cpu(struct device *dev, dma_addr_t dma_handle, unsigned long offset, size_t size, enum dma_data_direction direction)
 {
-	if (direction == DMA_NONE)
-	    BUG();
+	BUG_ON(direction == DMA_NONE);
 
 	flush_kernel_dcache_range((unsigned long) phys_to_virt(dma_handle) + offset, size);
 }
 
 static void pa11_dma_sync_single_for_device(struct device *dev, dma_addr_t dma_handle, unsigned long offset, size_t size, enum dma_data_direction direction)
 {
-	if (direction == DMA_NONE)
-	    BUG();
+	BUG_ON(direction == DMA_NONE);
 
 	flush_kernel_dcache_range((unsigned long) phys_to_virt(dma_handle) + offset, size);
 }
-- 
1.6.1.3


       reply	other threads:[~2009-03-10  5:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1236661850-8237-1-git-send-email-stoyboyker@gmail.com>
     [not found] ` <1236661850-8237-2-git-send-email-stoyboyker@gmail.com>
     [not found]   ` <1236661850-8237-3-git-send-email-stoyboyker@gmail.com>
     [not found]     ` <1236661850-8237-4-git-send-email-stoyboyker@gmail.com>
     [not found]       ` <1236661850-8237-5-git-send-email-stoyboyker@gmail.com>
     [not found]         ` <1236661850-8237-6-git-send-email-stoyboyker@gmail.com>
     [not found]           ` <1236661850-8237-7-git-send-email-stoyboyker@gmail.com>
     [not found]             ` <1236661850-8237-8-git-send-email-stoyboyker@gmail.com>
     [not found]               ` <1236661850-8237-9-git-send-email-stoyboyker@gmail.com>
     [not found]                 ` <1236661850-8237-10-git-send-email-stoyboyker@gmail.com>
     [not found]                   ` <1236661850-8237-11-git-send-email-stoyboyker@gmail.com>
     [not found]                     ` <1236661850-8237-12-git-send-email-stoyboyker@gmail.com>
     [not found]                       ` <1236661850-8237-13-git-send-email-stoyboyker@gmail.com>
     [not found]                         ` <1236661850-8237-14-git-send-email-stoyboyker@gmail.com>
     [not found]                           ` <1236661850-8237-15-git-send-email-stoyboyker@gmail.com>
     [not found]                             ` <1236661850-8237-16-git-send-email-stoyboyker@gmail.com>
     [not found]                               ` <1236661850-8237-17-git-send-email-stoyboyker@gmail.com>
2009-03-10  5:10                                 ` Stoyan Gaydarov [this message]
2009-03-13  4:51                                   ` [PATCH 17/25] [parisc] BUG to BUG_ON changes Kyle McMartin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1236661850-8237-18-git-send-email-stoyboyker@gmail.com \
    --to=stoyboyker@gmail.com \
    --cc=grundler@parisc-linux.org \
    --cc=kyle@mcmartin.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox