* [PATCH 17/25] [parisc] BUG to BUG_ON changes [not found] ` <1236661850-8237-17-git-send-email-stoyboyker@gmail.com> @ 2009-03-10 5:10 ` Stoyan Gaydarov 2009-03-13 4:51 ` Kyle McMartin 0 siblings, 1 reply; 2+ messages in thread From: Stoyan Gaydarov @ 2009-03-10 5:10 UTC (permalink / raw) To: linux-kernel; +Cc: Stoyan Gaydarov, kyle, matthew, grundler, linux-parisc Signed-off-by: Stoyan Gaydarov <stoyboyker@gmail.com> --- arch/parisc/kernel/pci-dma.c | 12 ++++-------- 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c index df47895..2587563 100644 --- a/arch/parisc/kernel/pci-dma.c +++ b/arch/parisc/kernel/pci-dma.c @@ -480,8 +480,7 @@ static int pa11_dma_map_sg(struct device *dev, struct scatterlist *sglist, int n { int i; - if (direction == DMA_NONE) - BUG(); + BUG_ON(direction == DMA_NONE); for (i = 0; i < nents; i++, sglist++ ) { unsigned long vaddr = sg_virt_addr(sglist); @@ -496,8 +495,7 @@ static void pa11_dma_unmap_sg(struct device *dev, struct scatterlist *sglist, in { int i; - if (direction == DMA_NONE) - BUG(); + BUG_ON(direction == DMA_NONE); if (direction == DMA_TO_DEVICE) return; @@ -511,16 +509,14 @@ static void pa11_dma_unmap_sg(struct device *dev, struct scatterlist *sglist, in static void pa11_dma_sync_single_for_cpu(struct device *dev, dma_addr_t dma_handle, unsigned long offset, size_t size, enum dma_data_direction direction) { - if (direction == DMA_NONE) - BUG(); + BUG_ON(direction == DMA_NONE); flush_kernel_dcache_range((unsigned long) phys_to_virt(dma_handle) + offset, size); } static void pa11_dma_sync_single_for_device(struct device *dev, dma_addr_t dma_handle, unsigned long offset, size_t size, enum dma_data_direction direction) { - if (direction == DMA_NONE) - BUG(); + BUG_ON(direction == DMA_NONE); flush_kernel_dcache_range((unsigned long) phys_to_virt(dma_handle) + offset, size); } -- 1.6.1.3 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 17/25] [parisc] BUG to BUG_ON changes 2009-03-10 5:10 ` [PATCH 17/25] [parisc] BUG to BUG_ON changes Stoyan Gaydarov @ 2009-03-13 4:51 ` Kyle McMartin 0 siblings, 0 replies; 2+ messages in thread From: Kyle McMartin @ 2009-03-13 4:51 UTC (permalink / raw) To: Stoyan Gaydarov; +Cc: linux-kernel, kyle, matthew, grundler, linux-parisc On Tue, Mar 10, 2009 at 12:10:42AM -0500, Stoyan Gaydarov wrote: > Signed-off-by: Stoyan Gaydarov <stoyboyker@gmail.com> > Hi Stoyan, Thanks for sending this, but Helge Deller has already submitted a similar patch queued for 2.6.30. Thanks, Kyle ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-13 4:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1236661850-8237-1-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-2-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-3-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-4-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-5-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-6-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-7-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-8-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-9-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-10-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-11-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-12-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-13-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-14-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-15-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-16-git-send-email-stoyboyker@gmail.com>
[not found] ` <1236661850-8237-17-git-send-email-stoyboyker@gmail.com>
2009-03-10 5:10 ` [PATCH 17/25] [parisc] BUG to BUG_ON changes Stoyan Gaydarov
2009-03-13 4:51 ` Kyle McMartin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox