Fwd: Bug#706050: logrotate: spurious "error: getting file ACL" messages

Fwd: Bug#706050: logrotate: spurious "error: getting file ACL" messages

[John David Anglin]

This is with 3.9-rc6.

Begin forwarded message:

> From: Paul Martin <pm@debian.org>
> Date: April 24, 2013 7:01:58 AM GMT-04:00
> To: Dave Anglin <dave.anglin@bell.net>, 706050@bugs.debian.org
> Cc: control@bugs.debian.org
> Subject: Re: Bug#706050: logrotate: spurious "error: getting file  
> ACL" messages
>
> tags 706050 pending
> thanks
>
> On Sun, Apr 21, 2013 at 09:49:08AM -0400, Dave Anglin wrote:
>> Installed 3.8.3-3 on system with ext3 file systems without ACL  
>> support.
>> Now get mail with following with following content:
>>
>> /etc/cron.daily/logrotate:
>> error: getting file ACL /var/log/mysql.log: Function not implemented
>> error: getting file ACL /var/log/syslog.1: Function not implemented
>
> [snip]
>
>> Shouldn't these be supressed?
>
> Yes, they should.
>
> The test is
>
>        if ((prev_acl = acl_get_fd(fdcurr)) == NULL) {
>                if (errno != ENOTSUP) {
>                        message(MESS_ERROR, "getting file ACL %s: %s 
> \n",
>                                currLog, strerror(errno));
>
>
> and your kernel is responding with ENOSYS instead.  This contradicts
> the manpage acl_get_fd(3):
>
>     [ENOTSUP]          The file system on which the file identified  
> by fd is
>                        located does not support ACLs, or ACLs are  
> disabled.
>
> Upstream haven't spotted this, so I'll fix the logic in the next  
> upload...
>
> -- 
> Paul Martin <pm@debian.org>
>

--
John David Anglin	dave.anglin@bell.net

Re: Bug#706050: logrotate: spurious "error: getting file ACL" messages

[Jeroen Roovers]

On Wed, 24 Apr 2013 07:27:11 -0400
John David Anglin <dave.anglin@bell.net> wrote:

> > and your kernel is responding with ENOSYS instead.  This contradicts
> > the manpage acl_get_fd(3):

Looks like [1], notified upstream at [2]. We shouldn't be issuing
ENOSYS at all here.


     jer


[1] https://bugs.gentoo.org/show_bug.cgi?id=460702
[2] http://lists.nongnu.org/archive/html/acl-devel/2012-12/msg00000.html

Re: Bug#706050: logrotate: spurious "error: getting file ACL" messages

[John David Anglin]

On 2013-04-24, at 7:36 AM, John David Anglin wrote:

> On 24-Apr-13, at 7:01 AM, Paul Martin wrote:
> 
>> The test is
>> 
>>       if ((prev_acl = acl_get_fd(fdcurr)) == NULL) {
>>               if (errno != ENOTSUP) {
>>                       message(MESS_ERROR, "getting file ACL %s: %s\n",
>>                               currLog, strerror(errno));
>> 
>> 
>> and your kernel is responding with ENOSYS instead.  This contradicts
>> the manpage acl_get_fd(3):
>> 
>>    [ENOTSUP]          The file system on which the file identified by fd is
>>                       located does not support ACLs, or ACLs are disabled.
> 
> Thanks, forwarded your response to the parisc-linux list for review.


The spurious mail  has come back with logrotate 3.8.7-2.  File system is ext4:
/dev/sdc6 on /var type ext4 (rw,relatime,data=ordered)

/etc/cron.daily/logrotate:
error: getting file ACL /var/log/apt/term.log: Operation not supported
error: getting file ACL /var/log/apt/history.log: Operation not supported
...

Dave
--
John David Anglin	dave.anglin@bell.net

Re: Bug#706050: logrotate: spurious "error: getting file ACL" messages

[James Bottomley]

On Sat, 2015-07-11 at 11:51 -0400, John David Anglin wrote:
> On 2013-04-24, at 7:36 AM, John David Anglin wrote:
> 
> > On 24-Apr-13, at 7:01 AM, Paul Martin wrote:
> > 
> >> The test is
> >> 
> >>       if ((prev_acl = acl_get_fd(fdcurr)) == NULL) {
> >>               if (errno != ENOTSUP) {
> >>                       message(MESS_ERROR, "getting file ACL %s: %s\n",
> >>                               currLog, strerror(errno));
> >> 
> >> 
> >> and your kernel is responding with ENOSYS instead.  This contradicts
> >> the manpage acl_get_fd(3):
> >> 
> >>    [ENOTSUP]          The file system on which the file identified by fd is
> >>                       located does not support ACLs, or ACLs are disabled.
> > 
> > Thanks, forwarded your response to the parisc-linux list for review.
> 
> 
> The spurious mail  has come back with logrotate 3.8.7-2.  File system is ext4:
> /dev/sdc6 on /var type ext4 (rw,relatime,data=ordered)
> 
> /etc/cron.daily/logrotate:
> error: getting file ACL /var/log/apt/term.log: Operation not supported
> error: getting file ACL /var/log/apt/history.log: Operation not supported
> ...

It looks like you built your kernel without CONFIG_EXT4_FS_POSIX_ACL.
The warning is harmless because ACLs aren't required for logs ... it's
merely trying to duplicate the ACL on the rotated file.

James

Re: Bug#706050: logrotate: spurious "error: getting file ACL" messages

[John David Anglin]

On 2015-07-12, at 4:15 AM, James Bottomley wrote:

> On Sat, 2015-07-11 at 11:51 -0400, John David Anglin wrote:
>> On 2013-04-24, at 7:36 AM, John David Anglin wrote:
>> 
>>> On 24-Apr-13, at 7:01 AM, Paul Martin wrote:
>>> 
>>>> The test is
>>>> 
>>>>      if ((prev_acl = acl_get_fd(fdcurr)) == NULL) {
>>>>              if (errno != ENOTSUP) {
>>>>                      message(MESS_ERROR, "getting file ACL %s: %s\n",
>>>>                              currLog, strerror(errno));
>>>> 
>>>> 
>>>> and your kernel is responding with ENOSYS instead.  This contradicts
>>>> the manpage acl_get_fd(3):
>>>> 
>>>>   [ENOTSUP]          The file system on which the file identified by fd is
>>>>                      located does not support ACLs, or ACLs are disabled.
>>> 
>>> Thanks, forwarded your response to the parisc-linux list for review.
>> 
>> 
>> The spurious mail  has come back with logrotate 3.8.7-2.  File system is ext4:
>> /dev/sdc6 on /var type ext4 (rw,relatime,data=ordered)
>> 
>> /etc/cron.daily/logrotate:
>> error: getting file ACL /var/log/apt/term.log: Operation not supported
>> error: getting file ACL /var/log/apt/history.log: Operation not supported
>> ...
> 
> It looks like you built your kernel without CONFIG_EXT4_FS_POSIX_ACL.
> The warning is harmless because ACLs aren't required for logs ... it's
> merely trying to duplicate the ACL on the rotated file.


You were correct, CONFIG_EXT4_FS_POSIX_ACL wasn't defined.  Adding this to the kernel
appears to suppress the spam email from logrotate.

Thanks,
Dave
--
John David Anglin	dave.anglin@bell.net

Re: Bug#706050: logrotate: spurious "error: getting file ACL" messages

[Paul Martin]

On Sat, Jul 11, 2015 at 11:51:12AM -0400, John David Anglin wrote:

> The spurious mail  has come back with logrotate 3.8.7-2.  File system is ext4:
> /dev/sdc6 on /var type ext4 (rw,relatime,data=ordered)
> 
> /etc/cron.daily/logrotate:
> error: getting file ACL /var/log/apt/term.log: Operation not supported
> error: getting file ACL /var/log/apt/history.log: Operation not supported
> ...

Are you running with SELinux enabled by any chance?

-- 
Paul Martin <pm@debian.org>

Re: Bug#706050: logrotate: spurious "error: getting file ACL" messages

[John David Anglin]

On 2015-07-16, at 2:55 AM, Paul Martin wrote:

> On Sat, Jul 11, 2015 at 11:51:12AM -0400, John David Anglin wrote:
> 
>> The spurious mail  has come back with logrotate 3.8.7-2.  File system is ext4:
>> /dev/sdc6 on /var type ext4 (rw,relatime,data=ordered)
>> 
>> /etc/cron.daily/logrotate:
>> error: getting file ACL /var/log/apt/term.log: Operation not supported
>> error: getting file ACL /var/log/apt/history.log: Operation not supported
>> ...
> 
> Are you running with SELinux enabled by any chance?


No.  As mentioned previously, CONFIG_EXT4_FS_POSIX_ACL=y makes problem go away.

Dave
--
John David Anglin	dave.anglin@bell.net