[parisc-linux] CONFIG_SERIAL_GSC

[parisc-linux] CONFIG_SERIAL_GSC

[Grant Grundler]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=X-roman8, Size: 607 bytes --]

Hi folks,
Can someone explain why "#define CONFIG_SERIAL_GSC" is in serial.h?

Users of asm/serial.h are:

grundler <765>find . -name '*.[ch]' | xargs fgrep "asm/serial.h"
./arch/mips/baget/vacserial.c:#include <asm/serial.h>
./drivers/char/ip2main.c:#include <asm/serial.h>
./drivers/char/mac_SCC.h:/* MSch: gone to <asm/serial.h> */
./drivers/char/serial.c:#include <asm/serial.h>
./drivers/char/synclink.c:#include <asm/serial.h>
./drivers/gsc/lasi.c:#include <asm/serial.h>


I have the impression it's going to be difficult to build a "PCI"
serial driver with CONFIG_SERIAL_GSC defined.

thanks,
grant

Re: [parisc-linux] CONFIG_SERIAL_GSC

[Philipp Rumpf]

> Can someone explain why "#define CONFIG_SERIAL_GSC" is in serial.h?

It shouldn't be.

> Users of asm/serial.h are:
> grundler <765>find . -name '*.[ch]' | xargs fgrep "asm/serial.h"
> ./arch/mips/baget/vacserial.c:#include <asm/serial.h>
> ./drivers/char/ip2main.c:#include <asm/serial.h>
> ./drivers/char/mac_SCC.h:/* MSch: gone to <asm/serial.h> */
> ./drivers/char/synclink.c:#include <asm/serial.h>

> ./drivers/char/serial.c:#include <asm/serial.h>
> ./drivers/gsc/lasi.c:#include <asm/serial.h>

These are the only two that concern us.

> I have the impression it's going to be difficult to build a "PCI"
> serial driver with CONFIG_SERIAL_GSC defined.

Wrong.  The serial driver is designed to handle several busses at the
same time.  That means you can have CONFIG_SERIAL (port based),
CONFIG_SERIAL_GSC, and PCI MMIO based serial all activated at the same
time and one serial port of each variation and everything should work.

All you need to do is call register_serial with a struct serial_struct *req
so req->io_type == SERIAL_IO_MEM and everything should work fine.

Of course newer boxes (c3k, j5k, c3600, j5600) don't have GSC at all, so
you'd like not do define CONFIG_GSC/CONFIG_SERIAL_GSC for those.  (Those
boxes seem to still have an HP-proprietary bus though, but I don't know
anything about that).

	Philipp Rumpf