From: John Marvin <jsm@udlkern.fc.hp.com>
To: parisc-linux@puffin.external.hp.com
Subject: [parisc-linux] ldcw in __pthread_acquire
Date: Fri, 15 Dec 2000 03:12:09 -0700 (MST) [thread overview]
Message-ID: <200012151012.DAA05988@udlkern.fc.hp.com> (raw)
I just ran into an unaligned data reference in user land. The problem is
that the routine __pthread_acquire (in libpthread) does a ldcw, but it is
not ensuring that the address it is operating on is 16 byte aligned (it is
operating on the address that was passed in as the first argument). Some
processors don't require the 16 byte alignment, but many do.
I haven't looked at the source (I just found the location by disassembly),
so I don't know what the root cause is. The actual ldcw is probably from
an inlined function or macro, e.g. spin_lock(). My first guess would be
that it is using the machine dependent spin_lock macro, but the procedure
which called __pthread_acquire is passing in a structure whose lock field
does not have the aligned(16) attribute.
I don't have time to look at this right now. Any volunteers?
John Marvin
jsm@fc.hp.com
next reply other threads:[~2000-12-15 10:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-15 10:12 John Marvin [this message]
2000-12-15 11:37 ` [parisc-linux] ldcw in __pthread_acquire Alan Modra
2000-12-15 16:37 ` Matthew Wilcox
2000-12-15 17:32 ` Jes Sorensen
2000-12-16 19:29 ` Matthew Wilcox
2000-12-16 21:58 ` Jes Sorensen
2000-12-17 4:31 ` Alan Modra
2000-12-17 1:22 ` Stan Sieler
2000-12-17 2:38 ` Alan Cox
2000-12-17 4:18 ` LaMont Jones
2000-12-18 0:29 ` Stan Sieler
2000-12-18 0:36 ` Alan Cox
2000-12-18 0:48 ` Stan Sieler
2000-12-18 0:59 ` Alan Cox
2000-12-18 4:43 ` LaMont Jones
2000-12-18 11:53 ` Alan Cox
2000-12-18 12:27 ` Philippe Benard
2000-12-18 14:40 ` LaMont Jones
2000-12-18 19:44 ` Stan Sieler
2000-12-18 19:54 ` Alan Cox
2000-12-18 20:15 ` Stan Sieler
2000-12-18 20:44 ` LaMont Jones
2000-12-18 21:56 ` Alan Cox
2000-12-18 22:26 ` LaMont Jones
2000-12-18 7:10 ` Philippe Benard
2000-12-18 12:06 ` Alan Cox
2000-12-18 14:49 ` LaMont Jones
2000-12-18 15:59 ` Matthew Wilcox
-- strict thread matches above, loose matches on Subject: below --
2000-12-15 10:26 John Marvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200012151012.DAA05988@udlkern.fc.hp.com \
--to=jsm@udlkern.fc.hp.com \
--cc=parisc-linux@puffin.external.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox