From: Grant Grundler <grundler@cup.hp.com>
To: Matthieu Delahaye <delahaym@esiee.fr>
Cc: parisc-linux@thepuffingroup.com
Subject: Re: [parisc-linux] Unregister driver patch
Date: Sun, 25 Feb 2001 21:30:03 -0800 [thread overview]
Message-ID: <200102260530.VAA23229@milano.cup.hp.com> (raw)
In-Reply-To: Your message of "Sun, 25 Feb 2001 12:02:38 PST." <3A98E64E.A8A9216A@esiee.fr>
Hi Matthieu,
Ok. I lied. One more issue with the patch in register_pa_dev().
Matthieu Delahaye wrote:
> @@ -145,16 +187,16 @@
> {
> struct pa_iodc_driver *driver = pa_drivers;
>
> - while ((0 == hp_dev->managed) && (NULL != driver)) {
> + while ((NULL == hp_dev->driver) && (NULL != driver)) {
>
> if (compare_spec(hp_dev,driver))
> - hp_dev->managed =
> - ((*driver->callback)(hp_dev,driver) == 0);
> + hp_dev->driver =
> + (((*driver->callback)(hp_dev,driver) == 0)?driv
> er:NULL);
>
> driver = driver->next;
> }
>
> - return hp_dev->managed;
> + return (hp_dev->driver==driver);
In the case a device is managed, "driver" points to "->next" after
we exit the loop and we end up returning false. Right?
I think "return (NULL != hp_dev->driver)" is the correct code.
grant
Grant Grundler
parisc-linux {PCI|IOMMU|SMP} hacker
+1.408.447.7253
next prev parent reply other threads:[~2001-02-26 5:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-24 15:56 [parisc-linux] Unregister driver patch Matthieu Delahaye
2001-02-25 6:16 ` Grant Grundler
2001-02-25 11:02 ` Matthieu Delahaye
2001-02-26 4:30 ` Grant Grundler
2001-02-26 16:38 ` Matthew Wilcox
2001-02-26 5:30 ` Grant Grundler [this message]
2001-02-26 10:00 ` Matthieu Delahaye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200102260530.VAA23229@milano.cup.hp.com \
--to=grundler@cup.hp.com \
--cc=delahaym@esiee.fr \
--cc=parisc-linux@thepuffingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox